Yup.
But more to the point: this file is not even installed anywhere. The patch was
added in 2002, and still applies because the file is in the source tree but it
hasn't been installed in the last 12 years.
Just drop the patch, and lets leave the patch as it is to avoid breaking
platforms to
Closed #987.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/987#event-2917551976___
Rpm-maint mailing list
@KOLANICH The patch was created by @joeyh in 2002, per `debian/changelog`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
>Also it'd be good to have the original author mentioned - surely Debian has
>package change history available somewhere?
It is stored in [the form of the
patch](https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/tempfile.patch)
in which it is written
>Description: Use the
Well, that's a good point. We'd be rendering this script unusable for what it
does by making it "more correct" on Linux where it's not even supposed to be
used at all. We also don't actually install these scripts since 2007 (see
commit 4e52d18de873a861447a589f52c85de2326cd863) so I think it's
Also... It appears `mktemp(1)` does not exist on AIX, which might be why this
script doesn't use it.
Cf.
https://stackoverflow.com/questions/10224921/how-to-create-a-temporary-file-with-portable-shell-in-a-secure-way
--
You are receiving this because you are subscribed to this thread.
Reply
@pmatilai
Original patch header information:
```
- vpkg-provides.sh, vpkg-provides2.sh: Use tempfile(1) for safe creation
of all temporary files. Many changes and untested. These scripts do not
work on linux anyway.
-- Joey Hess Thu, 19 Dec 2002 00:31:10 -0500
```
For what
Please squash the commits, we don't want two separate commits for this. Also
it'd be good to have the original author mentioned - surely Debian has package
change history available somewhere?
Other than that, mktemp seems pretty obviously right thing to do here. The only
question is whether
why not `mktemp`?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/987#issuecomment-568982369___
Rpm-maint mailing list
I am not the original author of the patch (and also in the patch metadata it is
written that the author is unknown, but the maintainer says he doesn't remember
any contributions whose author is unknown, the most likely the patch should be
also attributed to him) but I guess that `tempfile`
Why is this safe? And is this a universally available property?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
From:
https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/tempfile.patch
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/987
-- Commit Summary --
* Use the Debian standard (and safe) mechanism of
12 matches
Mail list logo
