Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/985#issuecomment-574158812___
Rpm-maint mailing list
Merged via #1006 . Thanks for the effort of bringing this upstream.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #985.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/985#event-2946530627___
Rpm-maint mailing list
@KOLANICH Here's a suggestion:
```
$ git commit --amend --author="Michal Čihař " --date="Sat, 11
Nov 2017 14:27:10 +0100"
```
With the following commit message:
```
tools/sepdebugcrcfix: Conditionally use MAP_POPULATE with mmap()
Not all architectures offer MAP_POPULATE. As MAP_POPULATE is
> How do you propose to change it?
Just note that MAP_POPULATE is safe to drop in this manner as it's only an
optimization, so future generations won't need to chase it down.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
>I think this desserves some better commit message
I have just preserved the message present in the patch. BTW, it LGTM. How do
you propose to change it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@KOLANICH pushed 1 commit.
9ca1ac7b62bede14906359e3cd07a8d9069df29f Fix compilation on platforms without
MAP_POPULATE
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
ignatenkobrain commented on this pull request.
from what I have read in the documentation, MAP_POPULATE will just speed-up
things. So if anybody will use this patch anyway, I think this desserves some
better commit message and just be merged.
That said, I am not sure if I am right :)
--
I feel like this patch is just asking for trouble. Given that it touches the
debuginfo generation code, I'm not terribly comfortable passing judgment here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://salsa.debian.org/pkg-rpm-team/rpm/raw/master/debian/patches/map-populate.patch
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/985
-- Commit Summary --
* Fix compilation on platforms without MAP_POPULATE
-- File
10 matches
Mail list logo
