Re: [Rpm-maint] [rpm-software-management/rpm] add back --target as global option (#142)

2017-04-04 Thread Panu Matilainen
Like I noted in my first comment, the --target in rpmbuild is different (it takes a comma-separated list) and can't be replaced this way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add back --target as global option (#142)

2017-04-02 Thread proyvind
I dropped the redundant --target from rpmbuild as well, leaving for you to see fit whether merge that one or not. ;) RE: "add back", I seem to have made false assumptions related to global --target having been in place @rpm5.org since forever, so I mistakenly figured that it preceded the 4.4.2

Re: [Rpm-maint] [rpm-software-management/rpm] add back --target as global option (#142)

2017-04-02 Thread proyvind
@proyvind pushed 1 commit. 73a6443 drop redundant --target option for rpmbuild as well -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] add back --target as global option (#142)

2017-02-17 Thread Panu Matilainen
pmatilai requested changes on this pull request. I can see how overriding the target could be useful for macro evaluation sometimes, but add *back*? When was it removed and why? If something was removed then the reasons for the removal need to be reconsidered instead of just blindly reverting.