Re: [Rpm-maint] [rpm-software-management/rpm] rpm2cpio and rpm2archive: don't write archive data to a terminal. (#116)

2017-01-07 Thread Dmitry V. Levin
First of all, the github review process is awful, a traditional post to the mailing list would be much better. wrt your patch, > fprintf(stderr, "%s: refusing to output archive data to a terminal.\n"); > fprintf(stderr, "%s: refusing to output cpio data to a terminal.\n"); what do you mean by

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2cpio and rpm2archive: don't write archive data to a terminal. (#116)

2017-01-07 Thread soig
On 6 January 2017 at 05:11, Neal Gompa (ニール・ゴンパ) wrote: > *@Conan-Kudo* approved this pull request. > > Looks fantastic to me! > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub >

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2cpio and rpm2archive: don't write archive data to a terminal. (#116)

2017-01-05 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. Looks fantastic to me! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] rpm2cpio and rpm2archive: don't write archive data to a terminal. (#116)

2017-01-05 Thread Peter Jones
rpm2cpio and rpm2archive happily write binary data to the output terminal. This happens, for example, when I'm typing a command such as "rpm2cpio foo.rpm | less" and I make a typo, hitting instead of the pipe key. This often results in hilarious (if bewildering) font and character encoding