Merged #1181 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1181#event-3243373851___
Rpm-maint mailing list
This very much breaks my pull request I'm preparing — it seems that once you
start working on pythondistdeps, everyone gets notification about it and starts
working on it too :) — but it's beautiful and I'm all for it!
--
You are receiving this because you are subscribed to this thread.
Reply
@Conan-Kudo approved this pull request.
Someone finally did something that has been on my TODO for me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Right, so it's an [upstream Python
guideline](https://www.python.org/dev/peps/pep-0008/#blank-lines) that I wasn't
even aware of. I'll just agree to disagree with that then, so nevermind :smile:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
Yes, flake8 warns on needing two blank lines, not one.
https://www.flake8rules.com/rules/E302.html
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
While on the subject - are all those added empty lines due to some flake8
warnings?
I like visual aides as much as the next guy, but I do disagree with wasting
perfectly good screen estate with two consecutive empty lines when one will do
the trick already :grin:
--
You are receiving this
Splitting to a separate commit would be great, no need to make a separate PR
though.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Would you like me to revert that part of the change? They are fairly
self-contained, so easy enough to pull out in a separate change.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Nice, but please don't mix whitespace changes with code changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@s-t-e-v-e-n-k pushed 1 commit.
0afbfbb67b8b5d8346271a7d8d2351ad4ed0f411 scripts/pythondistdeps: Switch to
argparse
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@ignatenkobrain commented on this pull request.
> +parser.add_argument('-P', '--provides', action='store_true', help='Print
> Provides')
+parser.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+parser.add_argument('-r', '--recommends', action='store_true',
@s-t-e-v-e-n-k commented on this pull request.
> +parser.add_argument('-P', '--provides', action='store_true', help='Print
> Provides')
+parser.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+parser.add_argument('-r', '--recommends', action='store_true',
@ignatenkobrain commented on this pull request.
> +parser.add_argument('-P', '--provides', action='store_true', help='Print
> Provides')
+parser.add_argument('-R', '--requires', action='store_true', help='Print
Requires')
+parser.add_argument('-r', '--recommends', action='store_true',
Stop using getopt, and switch to a modern solution for parsing
arguments. Drive-by fixing some flake8 warnings, mainly whitespace.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1181
-- Commit Summary --
*
14 matches
Mail list logo
