Re: [Rpm-maint] [rpm-software-management/rpm] %{dirname:foo} is returning foo (Issue #2928)

2024-03-07 Thread Florian Festi
Closed #2928 as completed via 9571e3d9a24ddda076be81f457e672036cd3db8b. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2928#event-12040968234 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] %{dirname:foo} is returning foo (Issue #2928)

2024-03-05 Thread Panu Matilainen
Indeed, there's no deeper meaning to the test, it's all about argument handling and nothing to do with dirname itself (the context of c5909bd8698e56ffa4d1bb380116d61d6b48b8dd makes it quite clear) -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] %{dirname:foo} is returning foo (Issue #2928)

2024-03-05 Thread Florian Festi
My suspicion is that %dirname was used there not to test for it returning the filename unchanged but it was chosen as leaving the parameter unchanged made it a good test case for undefined arguments. -- Reply to this email directly or view it on GitHub: