Merged #2914 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2914#event-12025012441
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
> The problem with not installing items is that one can't be certain if they
> are indeed not installed. They can be pulled in indirectly through some other
> dependency, or appear later on after a system update. That happens quietly,
> and will change the way rpm builds. The cmake option on
> That said... This does make the cmake file a bit noisier. I wonder what the
> actual use cases are for disabling these (versus just not installing the
> given build dependency in the first place, assuming a clean build system or
> container is set up for the build).
The problem with not
Yeah, while the patch here just mirrors what we already do, it does feel a bit
draconian.
The autotools-era standard was to autodiscover unless overridden one way or the
other, when moving to cmake I just took the shortest shortcut I could find:
make most stuff mandatory, allow disabling.
OK, the above cmake feature seems to only work with `find_packages()`, not
`pkg_check_modules()`...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2914#issuecomment-1978815299
You are receiving this because you are subscribed to this
That said... This does make the cmake file a bit noisier. I wonder what the
actual use cases are for disabling these (versus just not installing the given
build dependency in the first place, assuming a clean build system or container
is set up for the build).
A quick googling also reveals:
@Conan-Kudo approved this pull request.
Sure, I suppose.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2914#pullrequestreview-1916977215
You are receiving this because you are subscribed to this thread.
Message ID:
Now with the cmake options in place, this looks fine to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2914#issuecomment-1978795518
You are receiving this because you are subscribed to this thread.
Message ID:
We didn't even do this with the Autotools build scripts, I don't think we
should make it so strict in the CMake build script either.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2914#issuecomment-1954138148
You are receiving this
@pmatilai requested changes on this pull request.
These are all optional dependencies and must remain that way, some of these
dependencies aren't available outside Linux at all. Without the corresponding
cmake options this is a no-go.
--
Reply to this email directly or view it on GitHub:
10 matches
Mail list logo
