Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
#781 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746702064 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
Seems dup of #797 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746700437 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
Seems I figured out. After installing deps from file generated by `-bs` some macroses appear. that's what is changed in environment. So the bug is: not generating `.buildreqs.nosrc.rpm`. If it was generated, bug would not happen. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
@pmatilai there are no difference. Really. I have provided part of the shell script. Tell me how to debug, please. I strongly consider there is a bug in RPM, but con not knock it down. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Panu Matilainen
Rpm doesn't use the dependencies recorded into an src.rpm in any circumstance, the spec is always reparsed. I don't know what the difference between rpmbuild -bs and -br is in your environment, but that's where the issue is. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
Interesting... `-rr --nodeps` rewrites .src.rpm in a way that `dnf` INSTALLS `pkgconfig(systemd)` afterwards. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746625208 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
@pmatilai sorry for not explaining clearly. Seems it is another bug. When `-rr` says error about missing deps but does not generate `.buildreqs.nosrc.rpm` in some conditions. In generally – yes, it works as expected. Especially on pyproject srpms, where 3-5 iterations are possible. please

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
@pmatilai sorry for bash script, but I want just show what happens in our build script: ```bash unpriv rpmbuild "${defines[@]}" -bs "$spec_file" --rmspec srpm=("$RPMBUILD"/SRPMS/*.src.rpm) while :; do unpriv rpmbuild "${defines[@]}" -rr "$srpm" && exit_code=0 || exit_code=$?

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
@pmatilai I always run everything in a clear environment. i.e. in the container, yes. Does `rpmbuild -rr` re-parse .spec-file ? Thought it does not. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746570147 You are

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Panu Matilainen
Oh, I see it now. Try 'rpmspec --parse frr.spec' to see how it looks to rpm, and it becomes quite clear. The pkgconf(systemd) dependency comes from the `%{?selinux_requires}` macro. And if rpmbuild -bs is executed in an environment where that macro is not defined then it will miss those

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Panu Matilainen
Closed #2690 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#event-10548896970 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Panu Matilainen
I suggest you try reproducing it in a different environment. A clean container image or such. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1746536531 You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Panu Matilainen
The one thing -bs and -br *will* disagree with is dynamic buildrequires from %generate_buildrequires. I don't see that in the src.rpm but I don't know what macros and stuff you may have locally. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Коренберг Марк
@pmatilai Commented things – are my lines – I did not remove after experiments. Yes, our scripts build `.src.rpm` from `.spec` file and then (in the same environment) install build deps. The problem that `rpmbuild -rr` says about missing deps, but `dnf builddep` does not install them (does not

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Panu Matilainen
BTW, it's also technically possible to (externally) rewrite the specfile after launching a build on it, and end up with wildly different in the src.rpm than what the build was launched with. It would be a nasty thing to do of course, but technically possible, and could explain oddities like

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-04 Thread Panu Matilainen
The dependencies recorded in an src.rpm are only valid for the environment (including any cli-switches) it was generated in. It's entirely possible to end up with something quite different on a spec reparse, which is what happens on any build. As for pkg-config deps, I see this in the spec,

Re: [Rpm-maint] [rpm-software-management/rpm] Wrong src RPM deps parsing by rpmbuild (Issue #2690)

2023-10-03 Thread Коренберг Марк
Moreover, I don't understand how it appears in this srpm file. This file was made in our build scripts. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2690#issuecomment-1745146423 You are receiving this because you are subscribed to