Re: [Rpm-maint] [rpm-software-management/rpm] rpm expands macro args twice (#217)
Funny how things seem clearer without a headache...
Obviously one needs to be able to pass escaped macros as arguments, another
example to show current non-sensical behavior:
```
$ rpm --define "%foo() %1" --eval "%foo %{_lib}" --eval "%foo %%{_lib}"
lib64
lib64
```
I have a fix for that, just trying to decide whether the "escape mode" would
ever be useful outside macro internals. The %nil case is interesting, the
current behavior where the argument shifts by one is certainly not sensical.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/217#issuecomment-302349680___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm expands macro args twice (#217)
The latter case fixed now in commit 9ae7d1df313b7a2b9fd74fef5a176dcdce40b88b, thanks for the cases! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/217#issuecomment-302358315___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm expands macro args twice (#217)
I also think you should expand the macros after splitting the arguments, so that the behavior is more useful and compatible. Example: ``` %foo() 1:%1 2:%2 ``` And `rpm --eval "%foo %nil bar` should return `1: 2:bar` like before. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/217#issuecomment-302345943___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Make source package detection less error prone. (#218)
Use a simple heuristic instead of looking at the lead type when we can't decided if a header is from a source package or not. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/218 -- Commit Summary -- * Add RPMTAG_SOURCEPACKAGE to the source package header * Use a simple heuristic to test for source package headers -- File Changes -- M build/pack.c (2) M lib/header.c (10) M lib/header_internal.h (2) M lib/package.c (27) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/218.patch https://github.com/rpm-software-management/rpm/pull/218.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/218 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] AIX has system instead of root as the primary group (#215)
Oh and BTW, if this fixes the immediate issue you have and then we can deal with the build-side of things(%defattr and the like) in a separate patch later on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302375943___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] AIX has system instead of root as the primary group (#215)
Thanks @pmatilai . Is it okay if i open a new PR ? . I never tried updating a PR ;-( -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302376894___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] AIX has system instead of root as the primary group (#215)
Thats ok too :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302379516___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Three fixes for rpmdeps (#216)
First and last patch look good. Pushed. Thanks you very much! Wrt putting the --rpmfcdebug output to stdout: Can't you just redirect stderr for you use case? While stderr and stdout output is messed up in rpm the proposed patch really moves into the wrong direction. I am closing this PR for now. The topic is valid, though, but it needs to be looked at with a much larger scope that is probably not appropriate within this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/216#issuecomment-302379907___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Three fixes for rpmdeps (#216)
Closed #216. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/216#event-1087632114___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Warningsfixes (#191)
Closed #191. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/191#event-1087640612___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Warningsfixes (#191)
Pushed first patch. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/191#issuecomment-302381244___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] AIX has system instead of root as the primary group (#215)
@pmatilai I just opened a new PR. Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302382832___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Generalize primary (uid/gid=0) user & group for platforms (#219)
Platforms like AIX has system instead of root as the primary group (gid=0). This patch generalize these stuffs rather than hard coding in the code. This PR is opened to incorporate the changes needed after the review of another PR https://github.com/rpm-software-management/rpm/pull/215 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/219 -- Commit Summary -- * Generalize primary user/group for platforms -- File Changes -- M configure.ac (4) M lib/rpmfi.c (4) M lib/rpmug.c (12) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/219.patch https://github.com/rpm-software-management/rpm/pull/219.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/219 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm expands macro args twice (#217)
...and the initial case fixed in 767d61ca3dba9745d392fa28bbe09a209bd49522. Again, thanks for spotting and reporting! It's s much nicer to fix such things pre-release time at your leisure without having an angry mob of packagers yelling "you bastard you broke my stuff" at you :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/217#issuecomment-302370343___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] rpm expands macro args twice (#217)
Closed #217. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/217#event-1087571377___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] AIX has system instead of root as the primary group (#215)
Looks much better, thanks, please update this PR with the new version. Having to awk for the username seems a bit gross but then I would've expected `id` to take numbers since day one, which clearly is not the case (it doesn't work in RHEL-5 or -6 either) maybe we'll just have to live with it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302374047___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] AIX has system instead of root as the primary group (#215)
Superceded by #219. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302408410___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] set a %_specfile macro during build, holding full path to spec file (#202)
Nope, I don't like it any more than the last time around, and I don't see anything here that would change my mind - "without having to pass extra arguments" doesn't sound like a very convincing argument. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/202#issuecomment-302407964___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Generalize primary (uid/gid=0) user & group for platforms (#219)
Closed #219. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/219#event-1087841680___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for ARM 64bit (aarch64) - Add arm32 and arm64 macros (#173)
It is going nowhere. Let's close this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/173#issuecomment-302463158___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for ARM 64bit (aarch64) - Add arm32 and arm64 macros (#173)
Closed #173. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/173#event-1088142672___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add a new option --all-per-file to rpmdeps (#220)
This is an alternative solution to the part in https://github.com/rpm-software-management/rpm/pull/216 that was rejected. Rather than changing the behavior of the existing `--rpmfcdebug` option, this adds a new option `--all-per-file`, which outputs the same information as `--rpmfcdebug` does, but to stdout. The reason why this is needed and why not to just use `rpmdeps --rpmfcdebug ... 2>&1` is that if there is an error, the error message would then end up on stdout as well and never be shown to the user who then has no idea why the command failed (assuming that stdout is caught by some other process that uses the output from `rpmdeps` as its input). I am not very happy about the option name, `--all-per-file`, but it was the best I could come up with to indicate that it outputs all dependencies per input file. Feel free to suggest alternatives. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/220 -- Commit Summary -- * Add a new option --all-per-file to rpmdeps -- File Changes -- M tools/rpmdeps.c (7) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/220.patch https://github.com/rpm-software-management/rpm/pull/220.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/220 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Generalize primary (uid/gid=0) user & group for platforms (#219)
Like noted in #215, having to awk for the username seems a bit gross but then I would've expected id to take numbers since day one, which clearly is not the case (it doesn't work in RHEL-5 or -6 either) maybe we'll just have to live with it. There was a thinko/editing mistake in the patch (user_with_uid0 vs username_with_uid0, ditto for group) causing both to be defined as "" in config.h, but I fixed that up while committing. Also moved the test a bit earlier since it looked kinda out of place at the end. Anyway, merged manually now (commit 2329af6667d0c476924b9dffb4c52877f62d5484) , thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/219#issuecomment-302410624___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] AIX has system instead of root as the primary group (#215)
Closed #215. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/215#event-1087827090___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Generalize primary (uid/gid=0) user & group for platforms (#219)
Oh, my mistake. Skipped from my eyes. Thanks @pmatilai -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/219#issuecomment-302415732___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] set a %_specfile macro during build, holding full path to spec file (#202)
Closed #202. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/202#event-1087823736___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add support for ARM 64bit (aarch64) - Add arm32 and arm64 macros (#173)
Is this still going anywhere or can we close it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/173#issuecomment-302387209___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
