Re: [Rpm-maint] [rpm-software-management/rpm] rpm --import does not replace old keys with new keys (Issue #2577)

2023-09-13 Thread Panu Matilainen
I agree --import needs some sort of "update" operation. But any solution that may be developed in the future is not going to help the *now* of Chrome users as there's no way to get it deployed to all the (enterprise) distros out there. Google needs to use keys that are compatible with how

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: use directory ownership for transaction ordering (Issue #2148)

2023-09-13 Thread Panu Matilainen
(this is a "handsfree" item as using that info frees packagers from having to manually add dependencies for these) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2148#issuecomment-1718804671 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Bogus warning about files listed twice (Issue #2334)

2023-09-13 Thread Panu Matilainen
This is a dupe of #336, closing. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2334#issuecomment-1718800137 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Bogus warning about files listed twice (Issue #2334)

2023-09-13 Thread Panu Matilainen
Closed #2334 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2334#event-10367388450 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Make `%setup` work with archives regardless of inner structure (Issue #2664)

2023-09-13 Thread Panu Matilainen
Right, this closely relates to #2078 as well. Libarchive is currently an optional dependency, but a hard dep wouldn't be the end of the world. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2664#issuecomment-1718781153 You are

Re: [Rpm-maint] [rpm-software-management/rpm] Turn %prep into a normal build script (Issue #2205)

2023-09-13 Thread Panu Matilainen
(this is "handsfree" item because the aforementioned, ah, specialty prevents all sorts of interesting developements) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2205#issuecomment-1718802277 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Use Python Stable ABI for the bindings (Issue #2345)

2023-09-13 Thread Panu Matilainen
Hey, it's been quiet on this front for quite a while. Is this a case of "too busy with other things", or is there something more to it? Just asking in case somebody else wants to pickup this work. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add a new perl.prov script to generate normalized module versions (PR #2586)

2023-09-13 Thread Jitka Plesníková
Fedora has [perl-generator](https://src.fedoraproject.org/rpms/perl-generators) package since 2014. It contains perl.req, perl.prov and fileattrs based on rpm-4.11.2. Over the years, there have been some updates in dependency detection and bug fixes issues reported in Fedora. We also added

Re: [Rpm-maint] [rpm-software-management/rpm] Making the os_release function more strict (PR #2657)

2023-09-13 Thread Panu Matilainen
Heh, yeah sometimes the most obvious answer is just too obvious :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2657#issuecomment-1717115125 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Making the os_release function more strict (PR #2657)

2023-09-13 Thread Michal Domonkos
> Hmm, wouldn't `COMMAND sh -c ". /etc/os-release; echo ${var}"` achieve the > same thing, by letting the shell do the work instead? Yep, that's the "canonical" way to use `/etc/os-release`. For some reason, I didn't realize this when adding this cmake helper. @dmikushin, feel free to update

Re: [Rpm-maint] [rpm-software-management/rpm] Making the os_release function more strict (PR #2657)

2023-09-13 Thread Michal Domonkos
Indeed. It makes one wonder why the file is formatted in a shell-like fashion :smile: Also, I just noticed this is also what `man os-release` illustrates in the `Example 3. Reading os-release in sh(1)` section. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix GCC compiler error (PR #2656)

2023-09-13 Thread Panu Matilainen
Oh, this "wonderful" quirk of C99. I wonder why newer gcc doesn't complain because I don't think it's legit in C11 either. Fixed a little differently in 34d983fa2a9b9276fc540b6bd554605b2c72689a because I hate the way those locally added blocks mess up the git history (or blame rather), and for

Re: [Rpm-maint] [rpm-software-management/rpm] Fix GCC compiler error (PR #2656)

2023-09-13 Thread Panu Matilainen
Closed #2656. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2656#event-10356304616 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Making the os_release function more strict (PR #2657)

2023-09-13 Thread Panu Matilainen
Hmm, wouldn't `COMMAND sh -c ". /etc/os-release; echo ${var}"` achieve the same thing, by letting the shell do the work instead? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2657#issuecomment-1717082230 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Removing --clearenv, because bubblewrap 0.4.0 does not support it (PR #2658)

2023-09-13 Thread Panu Matilainen
An old version not supporting something is not a valid reason to drop an important flag, see 1b70fd23bc45d2ec8a97c09b06fc3d7011b34cfc. In general RHEL-latest is the ballpark line where where things need to compile + work, bubblewrap 0.4.0 is RHEL-8 era and so doesn't count, but even 9 has only

Re: [Rpm-maint] [rpm-software-management/rpm] Making the os_release function more strict (PR #2657)

2023-09-13 Thread Michal Domonkos
@dmnks requested changes on this pull request. Mentioned above. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2657#pullrequestreview-1623916057 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Removing --clearenv, because bubblewrap 0.4.0 does not support it (PR #2658)

2023-09-13 Thread Panu Matilainen
Or rather, just document the version requirement. Writing tests for every dark corner gets old real fast. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2658#issuecomment-1717230615 You are receiving this because you are subscribed to

[Rpm-maint] [rpm-software-management/rpm] RFE: introduce plugin API version + load-time checking (Issue #2662)

2023-09-13 Thread Panu Matilainen
As our plugins become public there needs to be some ways to check they're compiled for a compatible version of rpm. Many will get that enforcement through rpm soname but technically there's no requirement for a plugin to link to librpm* and .. better safe than sorry with mysterious bugreports

Re: [Rpm-maint] [rpm-software-management/rpm] Removing --clearenv, because bubblewrap 0.4.0 does not support it (PR #2658)

2023-09-13 Thread Michal Domonkos
Indeed, `--clearenv` is there to ensure we run the tests in a clean environment. It also means we don't have selectively unset the various env vars in the container that could interfere with the test. The current tests *might* still work even without `--clearenv` but we don't want to change

Re: [Rpm-maint] [rpm-software-management/rpm] Removing --clearenv, because bubblewrap 0.4.0 does not support it (PR #2658)

2023-09-13 Thread Michal Domonkos
Closed #2658. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2658#event-10356637571 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] Make the plugin API public (PR #2661)

2023-09-13 Thread Panu Matilainen
Weve procrastinated on making this API public for about ten years now, and in the meanwhile there has been exactly one disruptive change to the API. As in, it mightve just as well been public all along. There will always be more things to improve wrt any API, but were not going to hold this

Re: [Rpm-maint] [rpm-software-management/rpm] Removing --clearenv, because bubblewrap 0.4.0 does not support it (PR #2658)

2023-09-13 Thread Michal Domonkos
> For the record, we're currently > [working](https://github.com/rpm-software-management/rpm/issues/2643) on a > unified backend that will get rid of distro-specific scripts and only use > podman images. Bubblewrap may or may not be required on the development > system, I'm still not entirely

Re: [Rpm-maint] [rpm-software-management/rpm] Removing --clearenv, because bubblewrap 0.4.0 does not support it (PR #2658)

2023-09-13 Thread Michal Domonkos
Oh yup, we would have to check for that manually as there doesn't seem to be an RPM-like construct for program versions in `find_program()`. In that case, yes, we'll just document that in the README file as part of #2611. -- Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Source + header spring cleaning (PR #2660)

2023-09-13 Thread Panu Matilainen
Details in the commits, but executive summary is to force some structure to the fast and loose way private includes are used. While at it, clean up the top-level source directory to be free of source code, it doesnt really belong there. Looks huge, but for all practical purposes this is just

Re: [Rpm-maint] [rpm-software-management/rpm] Source + header spring cleaning (PR #2660)

2023-09-13 Thread Panu Matilainen
Merged #2660 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2660#event-10357896313 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: make rpm plugin API public (#1536)

2023-09-13 Thread Panu Matilainen
Closed #1536 as completed via #2661. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1536#event-10358631174 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Make the plugin API public (PR #2661)

2023-09-13 Thread Panu Matilainen
Merged #2661 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2661#event-10358630689 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add a testcase for librpm development (PR #2663)

2023-09-13 Thread Panu Matilainen
Merged #2663 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2663#event-10359617114 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Add a testcase for librpm development (PR #2663)

2023-09-13 Thread Panu Matilainen
Shouldve been in 6ec0e4069e61fca3a5391c65effe72b2c782730d but at that time cmake in Fedora had a dependency on rpm making this hard or at least ugly. With that dependency fixed and workarounds removed from the test-suite, we can now run cmake in there. You can view, comment on, or merge this

Re: [Rpm-maint] [rpm-software-management/rpm] Add a testcase for librpm development (PR #2663)

2023-09-13 Thread Panu Matilainen
@pmatilai pushed 1 commit. cfc79e1e7426e07aeef9e3d2b663878285ddf22b Add a testcase for librpm development -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2663/files/c90ce91e239a1bb41cc305fc452f3c56987015ae..cfc79e1e7426e07aeef9e3d2b663878285ddf22b You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] Make `%setup` work with archives regardless of inner structure (Issue #2664)

2023-09-13 Thread ニール・ゴンパ
Note that because of compatibility concerns, we'd probably want this new behavior in a new macro. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2664#issuecomment-1718404293 You are receiving this because you are subscribed to this

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Standardize on OCI images for test-suite, even locally (Issue #2643)

2023-09-13 Thread ニール・ゴンパ
Keep in mind, we need a way to run it directly on the host, because all this fanciness you're talking about doesn't exist on non-Linux platforms. In particular, I would like to be able to run the test suite for RPM on macOS still.  -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Standardize on OCI images for test-suite, even locally (Issue #2643)

2023-09-13 Thread ニール・ゴンパ
I will also point out there are openSUSE containers that use DNF too.  -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2643#issuecomment-1718407495 You are receiving this because you are subscribed to this thread. Message ID:

[Rpm-maint] [rpm-software-management/rpm] Make `%setup` work with archives regardless of inner structure (Issue #2664)

2023-09-13 Thread ニール・ゴンパ
In a conversation in [`#devel:fedoraproject.org`](https://matrix.to/#/#devel:fedoraproject.org) with @penguinpee, I realized that there's a potential quality of life improvement we could look into making around `%setup`: Making it so we don't ever need to use `-n`. It started with asking