Re: [Rpm-maint] Getting make check to work

2013-03-07 Thread Mark Wielaard
On Wed, 2013-03-06 at 15:28 +0200, Panu Matilainen wrote: ./configure CPPFLAGS=`pkg-config --cflags nss` --with-external-db make make check [...] And finally, thanks for complaining about this, really. One can only explain known bugs so many times before it gets so irritating as to

Re: [Rpm-maint] FSM hooks for rpm plugin

2013-03-07 Thread Reshetova, Elena
On 03/06/2013 05:01 PM, Reshetova, Elena wrote: What's missing is that another call to the hook is needed in fsmMkdirs() for the unowned directories, and there we should perhaps pass in the unowned aspect somehow. Having a separate argument for that seems like an overkill though... maybe we

Re: [Rpm-maint] FSM hooks for rpm plugin

2013-03-07 Thread Panu Matilainen
On 03/07/2013 03:59 PM, Reshetova, Elena wrote: On 03/06/2013 05:01 PM, Reshetova, Elena wrote: What's missing is that another call to the hook is needed in fsmMkdirs() for the unowned directories, and there we should perhaps pass in the unowned aspect somehow. Having a separate argument for

Re: [Rpm-maint] FSM hooks for rpm plugin

2013-03-07 Thread Panu Matilainen
On 03/07/2013 04:27 PM, Reshetova, Elena wrote: If we now see a proper use case: like pre-commit can be used for content checking or even checksum calculation (I would still probably prefer to calculate it when it is read from archive: feels a bit safer that way, while I understand logically

Re: [Rpm-maint] FSM hooks for rpm plugin

2013-03-07 Thread Panu Matilainen
On 03/07/2013 07:55 PM, Panu Matilainen wrote: On 03/07/2013 04:27 PM, Reshetova, Elena wrote: If instead of hook 2) we have a post fsm commit hook that with proper parameter, I think it can be serving the same purpose. The only thing is that setting permissions before rpm does it isn't

Re: [Rpm-maint] FSM hooks for rpm plugin

2013-03-07 Thread Panu Matilainen
On 03/07/2013 08:05 PM, Panu Matilainen wrote: On 03/07/2013 07:55 PM, Panu Matilainen wrote: On 03/07/2013 04:27 PM, Reshetova, Elena wrote: If instead of hook 2) we have a post fsm commit hook that with proper parameter, I think it can be serving the same purpose. The only thing is that