On Thu, 2016-05-26 at 17:00 +0200, Mark Wielaard wrote:
> I am integrating this patch with the patches I posted that integrate the
> debuginfo package handling from fedora and the new testcases and wanted
> to make the behavior configurable so a distro can setup a macro to
> define what they want.
Hi,
I skimmed through your patches and they seem ok to me from a coding style point
of view. I would suggest just cosmetic changes like replacing asprintf() with
rasprintf() and on some places 8 spaces are used instead of tab
for indentation.
The problem with patches is that they move some logic
Closed #67.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/67#event-679528823___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
Closed #40.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/40#event-679528736___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
I really can't see this changes going in upstream. Beside the duplication of a
lot of code, duplication of the API there are lots of unresolved - probably
even unnoticed - issues. Including but not limited to:
* Support in dependency solvers
* UI
* Update requiring changes in both DBs
*
