Re: [Rpm-maint] [rpm-software-management/rpm] couple of fixes for pythondistdeps.py (#83)

2016-08-22 Thread Igor Gnatenko
Merged #83. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/83#event-76234___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] build: fgetc returns int, not char. (#82)

2016-08-22 Thread ニール・ゴンパ
Looks excellent to me!  -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/82#issuecomment-241387139___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] pythondistdeps.py: Ensure that dist data used has py_version data (#80)

2016-08-22 Thread Igor Gnatenko
Closed #80. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/80#event-762844884___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

[Rpm-maint] [rpm-software-management/rpm] couple of fixes for pythondistdeps.py (#83)

2016-08-22 Thread Igor Gnatenko
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/83 -- Commit Summary -- * pythondistdeps.py: Ensure that dist data used has py_version data * pythondistdeps.py: show warning if version is not found * pythondistdeps.py:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for RISC-V (#81)

2016-08-22 Thread rwmjones
> @@ -243,6 +247,9 @@ arch_canon: mipsr6el: mipsr6el 20 > arch_canon: mips64r6: mips64r6 21 > arch_canon: mips64r6el: mips64r6el 21 > > +arch_canon: riscv: riscv64 22 The rest of the file uses single tabs between fields, and as a result doesn't line up either. -- You

Re: [Rpm-maint] [rpm-software-management/rpm] build: fgetc returns int, not char. (#82)

2016-08-22 Thread Igor Gnatenko
LGTM! nice catch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/82#issuecomment-241352151___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for RISC-V (#81)

2016-08-22 Thread Igor Gnatenko
> @@ -243,6 +247,9 @@ arch_canon: mipsr6el: mipsr6el 20 > arch_canon: mips64r6: mips64r6 21 > arch_canon: mips64r6el: mips64r6el 21 > > +arch_canon: riscv: riscv64 22 one more tab? ;) -- You are receiving this because you are subscribed to this thread. Reply to this

[Rpm-maint] [rpm-software-management/rpm] build: fgetc returns int, not char. (#82)

2016-08-22 Thread rwmjones
Returning the value into a char is a mistake on all platforms, but is particularly bad on RISC-V. On that platform (like ARM) char is unsigned. Therefore EOF (-1) is returned as 255, and the subsequent test 'c == EOF' ('255 == -1') fails causing an infinite loop. Signed-off-by: Richard W.M.

[Rpm-maint] [rpm-software-management/rpm] Add support for RISC-V (#81)

2016-08-22 Thread rwmjones
These patches add support for the RISC-V architecture. For further information, see https://fedoraproject.org/wiki/Architectures/RISC-V You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/81 -- Commit Summary -- * RISCV 64-bit