Re: [Rpm-maint] [rpm-software-management/rpm] Create binary rpm packages in parallel? (better multiple CPU core utilization) (#211)
Best way would be to simply create a pull request from a finalized branch of yours (without unecessary amounts of WIP commits) pushed to a forked rpm repo of yours. Then it would make sense to rather continue discuss the subject and also the implementation of. Regardless of upstream maintainter's interest, I can rest assure you that there are others who have interest , making it wortwhile to create a PR for anyways. :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/211#issuecomment-305285733___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (jbj, #198) (#225)
Here's a pull request of what posted by @n3npq Jeff in #198. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/225 -- Commit Summary -- * Colorized rpmlog() output (jbj, #198) -- File Changes -- M rpmio/rpmlog.c (148) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/225.patch https://github.com/rpm-software-management/rpm/pull/225.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/225 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Create binary rpm packages in parallel? (better multiple CPU core utilization) (#211)
I actually have this working now. The improvements for us (the Yocto project) are quite dramatic, together with the switchover to multithreaded xz compression the process takes several times less for many bigger packages. I had to do these things: 1) split the binary packaging loop body into its own function 2) set up the task execution and joining with appropriate data structures for handling each task 3) fix a few data races (like Jeff predicted): particularly the shared string pool structure was completely thread unsafe, and there a couple of other issues around copying header data between packages, and usage of static local variables in a couple of places. I'm going to polish the patches, and will provide a link in a couple of days. If there's interest from upstream maintainers, I can turn it into a pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/211#issuecomment-305258563___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Create binary rpm packages in parallel? (better multiple CPU core utilization) (#211)
I've also just started looking into this as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/211#issuecomment-305240602___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)
Pushed as e96fde89c6e0ac59da5cb22fa310235a9918aa7a -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/157#issuecomment-305188662___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)
Closed #157. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/157#event-1104183049___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add comments for SHA-2 file digest variants (#223)
There's no good place anywhere in rpm to document the meaning of individual tags I'm afraid. I was about to say you should use the rpm.files/fi APIs instead of tag values for file information but seems retrieving the digest algo is not supported, sigh... Anyway, much easier to merge than argue, thanks for the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/223#issuecomment-305163151___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add comments for SHA-2 file digest variants (#223)
Merged #223. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/223#event-1104017277___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] File dependency generation regression (#224)
It seems all the dependencies get collected into the first file, ie index 0. So probably the index isn't getting incremented, perhaps because of moving to callbacks (but didn't really look). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/224#issuecomment-305109210___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] File dependency generation regression (#224)
sorry for breaking it =( -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/224#issuecomment-305106716___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] File dependency generation regression (#224)
Commit 8f509d669b9ae79c86dd510c5a4bc5109f60d733 causes file dependencies to be
recorded on wrong files. In rpm source directory:
```
[pmatilai@sopuli rpm]$ wget
http://ftp.funet.fi/pub/mirrors/fedora.redhat.com/pub/fedora/linux/releases/25/Workstation/source/tree/Packages/p/popt-1.16-7.fc24.src.rpm
[pmatilai@sopuli rpm]$ make -j4 && make install DESTDIR=/tmp/rtest/
[...]
[pmatilai@sopuli rpm]$ rpm -qp --fileprovide
$(RPM_CONFIGDIR=/tmp/rtest/usr/lib/rpm ./rpmbuild --rebuild --nocheck
popt-1.16-7.fc24.src.rpm 2>&1|grep ^Wrote | head -1|awk '{print $2}')|grep
libpopt
/etc/popt.d libpopt.so.0(LIBPOPT_0)(64bit) libpopt.so.0()(64bit)
/lib64/libpopt.so.0
/lib64/libpopt.so.0.0.0
```
After reverting commit git revert 8f509d669b9ae79c86dd510c5a4bc5109f60d733,
repeat the steps from make -j4 onwards to get the expected:
```
/lib64/libpopt.so.0
/lib64/libpopt.so.0.0.0 libpopt.so.0(LIBPOPT_0)(64bit) libpopt.so.0()(64bit)
```
Since package generation is affected this is a blocker to any kind of public
release.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/224___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
