Re: [Rpm-maint] [rpm-software-management/rpm] Use LANG=C.UTF-8 instead of LANG=C during package build by default (#227)
I'm fairly certain `C.UTF-8` only exists in glibc, which is a problem for users of rpm running on other OSes (macOS, OS/2, AIX, etc.) or libc libraries on Linux (musl, dietlibc, etc.). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/227#issuecomment-305874793___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Metatags (#107)
I never really entirely understood what you meant by key:value, could you provide an example? :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/107#issuecomment-305873269___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
I'd say "wuzz out" is clear enough, while also more suggestive ;) for pkgconfig files, this isn't really just a pure upstream problem, the foo.pc file is usually generated from ie. flags passed to configure.. And wrt. masking problems, a lot of the brp scripts simply fixes stuff easy to detect and fix, while being too widespread not worth the efforts of spend much time on pushing fixes for each and every package which the scripts are meant to fix and free us of.. ;) It's meant to decrease the maintenance burden, not the other way araound ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230#issuecomment-305871513___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (jbj, #198) (#225)
proyvind commented on this pull request.
> @@ -237,6 +237,89 @@ const char * rpmlogLevelPrefix(rpmlogLvl pri)
return prefix;
}
+static const char * rpmlogLevelColor(rpmlogLvl pri)
+{
+return rpmlogMsgPrefixColor[pri&0x7];
+}
+
+static int rpmlogDefault(FILE *stdlog, rpmlogRec rec)
+{
+static const char fubar[] =
+ "Error occurred during writing of a log message";
+FILE *msgout = (stdlog ? stdlog : stderr);
+const char * colorOn = isatty(fileno(msgout))
which he already did, I now notice :p
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/225#discussion_r119919458___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
> The idea of that trimming away extra slashes in pkgconfig files having a high > risk of causing breakage (despite of it's triviality), not even if it's clear > that it's desirable is irrational. This should be properly fixed in upstream pkgconfig files, though. Otherwise we're just masking the problem. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230#issuecomment-305869515___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
> why changing "wuzz out" to "quit" in comment? in order to not offend some > unlikely person, or just plain political correctness (not really mutually > exclusive)? Not really for offensiveness. I didn't know what you meant by that. I edited for clarity. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230#issuecomment-305869337___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
@proyvind If you want to fix things, feel free to do so in your original PR. Also feel free to pull my changes in. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230#issuecomment-305869164___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
which I discovered that was me who had done.. :p my local branch on current workstation wasn't updated.. ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230#issuecomment-305860395___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
splitting the brp-check-elf-files script however, thx, I was planning on it ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230#issuecomment-305857069___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
ah, you were right about the missing brp-fix-pkgconfig script though, I'll rather fix it in the original PR -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230#issuecomment-305854866___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
disable_fix_foo are poor grammar, and not only 'disable' found to be consitent with was %_disable_source_fetch.. why changing "wuzz out" to "quit" in comment? in order to not offend some unlikely person, or just plain political correctness (not really mutually exclusive)? For pkgconfig, I made it more than evidently clear it being useful (and never dropped from #122). It's the root cause for majority of all double slashes in paths with the result of different hacks added to debugedit without the actual ability to really workaround the issues for all scenarious.. The idea of that trimming away extra slashes in pkgconfig files having a high risk of causing breakage (despite of it's triviality), not even if it's clear that it's desirable is irrational. Fixing the pkgconfig files and the actual root cause of most double slash issues with debugedit is hard to dispute as being desired over hacks and breakages with debugedit caused by not fixing the actual cause, which this script does.. I don't see the rationale for creating a new PR rather than just commenting on the existing one, nor much for the changes either. Changing single comments in scripts fully authored by for no technical/practical reasons is what to be considered as poor etiquette.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230#issuecomment-305853299___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (jbj, #198) (#225)
proyvind commented on this pull request.
> @@ -237,6 +237,89 @@ const char * rpmlogLevelPrefix(rpmlogLvl pri)
return prefix;
}
+static const char * rpmlogLevelColor(rpmlogLvl pri)
+{
+return rpmlogMsgPrefixColor[pri&0x7];
+}
+
+static int rpmlogDefault(FILE *stdlog, rpmlogRec rec)
+{
+static const char fubar[] =
+ "Error occurred during writing of a log message";
+FILE *msgout = (stdlog ? stdlog : stderr);
+const char * colorOn = isatty(fileno(msgout))
I only commited as-is to a separate branch to make PR from without testing as a
favour to @n3npq, unless he attends to, I'll probably get to it eventually.. ;)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/225#discussion_r119895426___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Python macro improvements (#221)
My archive of unpacked .spec file disputes @ignatenkobrain comment above --
backward compatibility matters
[herrold@centos-7 SPECS]$ grep "\%py" *spec | grep -v ":#" | wc
39 1461953
[herrold@centos-7 SPECS]$ grep "\%py" *spec | grep -v ":#"
BitTorrent.spec:%pyrequires_eq python-modules
compat-wxPython.spec:- use %%python_sitelib macro
denyhosts.spec:- Include everything under %%python_sitelib to pick up any
egg-info files that
eric3.spec:%pyrequires_eq python-modules
eric3.spec:%py_comp $RPM_BUILD_ROOT%{py_sitedir}/*
eric3.spec:%py_ocomp $RPM_BUILD_ROOT%{py_sitedir}/*
eric3.spec:- Release 3. STBR for Ac. %pyrequires_eq python-modules -> R:
python-modules. Eric is pure Python app.
gpsd.spec:- Use %%python_sitelib for python site-files stuff.
postgresql.spec:%if %python
postgresql.spec:%if %python
postgresql.spec:Conflicts: python < %pyver, python >= %pynextver
postgresql.spec:%if %python
postgresql.spec:%if %python
postgresql.spec:%if %python
postgresql.spec:%if %python
postgresql.spec:%if %python
postgresql.spec:%if %python
PyKDE-3.7.spec:echo yes | %pythonprog build.py \
PyKDE.spec:- Req: python-abi = %%python_ver
PyQt4.spec:- use %%python_sitearch
PyQt.spec:- Req: python-abi = %%python_ver
PyQt.spec:- use/Require: %%python_sitearch
python-dialog.spec:- Change %%python_sitearch to %%python_sitelib as sitearch
references
python-lazy-object-proxy.spec:%{?python_provide:%python_provide
python2-%{srcname}}
python-lazy-object-proxy.spec:%{?python_provide:%python_provide
python3-%{srcname}}
python-lazy-object-proxy.spec:%py2_build
python-lazy-object-proxy.spec:%py3_build
python-lazy-object-proxy.spec:%py2_install
python-lazy-object-proxy.spec:%py3_install
python-pandas.spec:%py3_build
python-pandas.spec:%py3_install
python-parsimonious.spec:%py2_build
python-parsimonious.spec:%py2_install
python-PyKDE.spec:%pyrequires_eqpython
python-PyKDE.spec:%py_comp $RPM_BUILD_ROOT%{py_sitedir}
python-PyKDE.spec:%py_ocomp $RPM_BUILD_ROOT%{py_sitedir}
python.spec:- add %%python3_version to the rpm macros (rhbz#719082)
python.spec:- add %%py3dir macro to macros.python3 (to be used during unified
python 2/3
rrdtool.spec:- Define %%python_version *before* its needed (#237826)
[herrold@centos-7 SPECS]$
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/221#issuecomment-305812544___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (jbj, #198) (#225)
n3npq commented on this pull request.
> @@ -237,6 +237,89 @@ const char * rpmlogLevelPrefix(rpmlogLvl pri)
return prefix;
}
+static const char * rpmlogLevelColor(rpmlogLvl pri)
+{
+return rpmlogMsgPrefixColor[pri&0x7];
+}
+
+static int rpmlogDefault(FILE *stdlog, rpmlogRec rec)
+{
+static const char fubar[] =
+ "Error occurred during writing of a log message";
+FILE *msgout = (stdlog ? stdlog : stderr);
+const char * colorOn = isatty(fileno(msgout))
RPM output is often useless in a pager because of inconsistent usage between
stdout/stderr while logging. Complicated operations (-Uvh, -ba) that run many
scripts cannot colorize without applying patterns using sed.
So adding a --color=WHEN option (instead of a simple colorization of the the
log prefix) is likely not worth the effort.
BTW, adding comments after C statements, not in the midst of a statement,
provides better context. The snippet above appears to be coercing an integer
return into a const char * pointer.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/225#discussion_r119872437___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
@Conan-Kudo pushed 1 commit. 7248529 Rename brp-fix-eol to brp-fix-line-endings -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/230/files/d587a79528bdb00b8a4a76685db5ec42e04e1299..72485299860e566729d1370375f2bb0951bcdac8 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] WIP: Add brp helper scripts derived from spec-helper (#230)
This PR includes #122 and attempts to address the remaining feedback. So far, the following changes have been made: * pkgconfig manipulation was dropped. The script wasn't even included in #122, and it's not clear it was a desirable change, anyway. * 'dont' was changed to 'disable', to be more consistent with other things in rpm * all brp scripts are now marked as executable, so that they would actually run * Small change in the comment in `brp-remove-rpath` You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/230 -- Commit Summary -- * add helper script for automatically cleaning backup files from buildroot * add brp script for removing any /usr/share/info/dir files created * add helper script for automatically relativizing symlinks in buildroot * add helper script for removing libtool .la files from buildroot * add brp script for automatically converting DOS to UNIX style EOL * add brp script for removing standard search paths from rpaths * add brp script for enforcing correct permissions for certain files * add brp script for automatically fixing non-XDG compliant .desktop files * add brp script for automatically creating library symlinks using ldconfig * add brp script to check elf files unused libs * add script for checking elf files for undefined symbols * add disablers for existing brp- scripts * Change 'dont' to 'disable' for brp script flags * Make all brp-* scripts executable * brp-remove-rpath: change "wuzz out" to "quit" in comment -- File Changes -- M platform.in (19) M scripts/Makefile.am (10) A scripts/brp-check-elf-files-for-undefined-symbols (31) A scripts/brp-check-elf-files-for-unused-libraries (33) A scripts/brp-clean-files (37) A scripts/brp-fix-desktop-files (17) A scripts/brp-fix-eol (16) A scripts/brp-fix-file-permissions (33) M scripts/brp-java-gcjcompile (0) M scripts/brp-python-bytecompile (0) A scripts/brp-relink-symlinks (30) A scripts/brp-remove-info-dir (15) A scripts/brp-remove-libtool-files (14) A scripts/brp-remove-rpath (49) M scripts/brp-strip-shared (0) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/230.patch https://github.com/rpm-software-management/rpm/pull/230.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/230 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use LANG=C.UTF-8 instead of LANG=C during package build by default (#227)
Since this was introduced into glibc just less then two years ago \[[1]\], I'd expect the commit message to be more elaborate about reasoning, backward compatibility etc. [1]: https://sourceware.org/glibc/wiki/Proposals/C.UTF-8 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/227#issuecomment-305731433___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use LANG=C.UTF-8 instead of LANG=C during package build by default (#227)
I removed the quotes in last rebased commit. What do you mean about the commit message should explain more? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/227#issuecomment-305729036___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Python macro improvements (#221)
I am wondering if we should remove all this python stuff from RPM because no one should use %python_sitelib due to py2/py3 things and such.. RPM doesn't depend on python.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/221#issuecomment-305722414___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Colorized rpmlog() output (jbj, #198) (#225)
ignatenkobrain commented on this pull request.
> @@ -237,6 +237,89 @@ const char * rpmlogLevelPrefix(rpmlogLvl pri)
return prefix;
}
+static const char * rpmlogLevelColor(rpmlogLvl pri)
+{
+return rpmlogMsgPrefixColor[pri&0x7];
+}
+
+static int rpmlogDefault(FILE *stdlog, rpmlogRec rec)
+{
+static const char fubar[] =
+ "Error occurred during writing of a log message";
+FILE *msgout = (stdlog ? stdlog : stderr);
+const char * colorOn = isatty(fileno(msgout))
I would prefer to have some macro/option to force enabling/disabling colors
(like a --color[=WHEN] where WHEN is "auto", "always", "never")...
because when you would be passing that to `less`, you could pass `-R` and it
will show you colors in pager... Quite useful.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/225#pullrequestreview-41716172___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use LANG=C.UTF-8 instead of LANG=C during package build by default (#227)
ignatenkobrain commented on this pull request. While I generally agree to this change (not sure if it really should be done in RPM), commit message could explain more. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/227#pullrequestreview-41715151___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Use LANG=C.UTF-8 instead of LANG=C during package build by default (#227)
ignatenkobrain commented on this pull request.
> @@ -778,7 +778,7 @@ package or when debugging this package.\
RPM_PACKAGE_VERSION=\"%{VERSION}\"\
RPM_PACKAGE_RELEASE=\"%{RELEASE}\"\
export RPM_PACKAGE_NAME RPM_PACKAGE_VERSION RPM_PACKAGE_RELEASE\
- LANG=C\
+ LANG=\"C.UTF-8\"\
not need for quoting
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/227#pullrequestreview-41714920___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Override ghost+dir filesizes (#229)
for directories and ghost files we do not want to
record their size in binary rpms
to make builds more reproducible.
See https://reproducible-builds.org/ for why this matters.
Note: I'm not sure if this is the best/correct way to do this, but at least it
made the packages build bit-identical where they did not before.
To test add to %install section:
```
cd %{buildroot}/some/packaged/dir
for i in $(seq 1 $RANDOM) ; do touch xxx$i ; done
rm xxx*
```
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/229
-- Commit Summary --
* Override ghost+dir filesizes
-- File Changes --
M build/files.c (3)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/229.patch
https://github.com/rpm-software-management/rpm/pull/229.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/229
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Do not store digests of ghost files (#228)
Do not store digests of ghost files
when the files exist during build time.
The hash will never be used for verification anyway.
This helps making packages build more reproducibly.
To test use
```
echo $RANDOM > %{buildroot}/var/cache/ghostfile
%files
%ghost /var/cache/ghostfile
```
and check with `rpm -qp --dump $RPM`
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/228
-- Commit Summary --
* Do not store digests of ghost files
-- File Changes --
M build/files.c (2)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/228.patch
https://github.com/rpm-software-management/rpm/pull/228.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/228
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Use LANG=C.UTF-8 instead of LANG=C during package build by default (#227)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/227 -- Commit Summary -- * Use LANG=C.UTF-8 instead of LANG=C during package build by default -- File Changes -- M macros.in (2) M scripts/check-buildroot (2) M scripts/check-rpaths-worker (4) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/227.patch https://github.com/rpm-software-management/rpm/pull/227.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/227 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
