Re: [Rpm-maint] [PATCH] Only process regular files when generating build-ids

2017-01-05 Thread Panu Matilainen
On 01/05/2017 02:08 PM, Mark Wielaard wrote: On Thu, Jan 05, 2017 at 12:27:52PM +0200, Panu Matilainen wrote: It looks commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 intends to skip symlinks since it filters on S_ISREG(), but since uses fstat() on already open()'ed file it ends up stat()'ing

Re: [Rpm-maint] [PATCH] Only process regular files when generating build-ids

2017-01-05 Thread Mark Wielaard
On Thu, Jan 05, 2017 at 12:27:52PM +0200, Panu Matilainen wrote: > It looks commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 intends to skip > symlinks since it filters on S_ISREG(), but since uses fstat() > on already open()'ed file it ends up stat()'ing the symlink target. > Flip stat() + open()

[Rpm-maint] [PATCH] Only process regular files when generating build-ids

2017-01-05 Thread Panu Matilainen
Versioned shared libraries typically have several symlinks pointing to them directly and indirectly. When %_build_id_links is set to compat or separate this causes bogus warnings about duplicate build-ids. It looks commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 intends to skip symlinks since it