Re: [Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

2017-07-21 Thread Florian Festi
Pushed. On 07/21/2017 01:24 PM, Mark Wielaard wrote: > Hi, > > On Thu, 2017-07-20 at 17:06 +0300, Dmitry V. Levin wrote: >> I'm not sure what sys/mkdev.h does, but glibc's sys/sysmacros.h certainly >> undefines major, minor, and makedev prior to defining its own versions of >> these macros. >>

Re: [Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

2017-07-21 Thread Mark Wielaard
Hi, On Thu, 2017-07-20 at 17:06 +0300, Dmitry V. Levin wrote: > I'm not sure what sys/mkdev.h does, but glibc's sys/sysmacros.h certainly > undefines major, minor, and makedev prior to defining its own versions of > these macros. > > My guess is that these undefs are not needed. You are right.

Re: [Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

2017-07-20 Thread Dmitry V. Levin
On Wed, Jul 19, 2017 at 02:49:38PM +0200, Mark Wielaard wrote: > glibc 2.25 introduced (really long and annoying) warnings for each use > of the major/minor macros from the wrong header: > > lib/cpio.c: In function ‘rpmcpioHeaderWrite’: > lib/cpio.c:245:13: warning: In the GNU C Library, "major"

[Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

2017-07-19 Thread Mark Wielaard
glibc 2.25 introduced (really long and annoying) warnings for each use of the major/minor macros from the wrong header: lib/cpio.c: In function ‘rpmcpioHeaderWrite’: lib/cpio.c:245:13: warning: In the GNU C Library, "major" is defined by . For historical compatibility, it is currently defined