Re: [Rpm-maint] [PATCH v2] Unbreak short-circuited binary builds (RhBug:1434235)

2017-03-24 Thread Panu Matilainen
On 03/23/2017 04:37 PM, Mark Wielaard wrote: On Wed, 2017-03-22 at 14:37 +0200, Panu Matilainen wrote: Guess there's some unhandled corner left still :) Yeah, that was because my fix was bogus :{ It didn't construct the linkpath correctly (because it was relative). It checked with readlink

Re: [Rpm-maint] [PATCH v2] Unbreak short-circuited binary builds (RhBug:1434235)

2017-03-23 Thread Mark Wielaard
On Wed, 2017-03-22 at 14:37 +0200, Panu Matilainen wrote: > Guess there's some unhandled corner left still :) Yeah, that was because my fix was bogus :{ It didn't construct the linkpath correctly (because it was relative). It checked with readlink (), but that doesn't fully expand the links, it

Re: [Rpm-maint] [PATCH v2] Unbreak short-circuited binary builds (RhBug:1434235)

2017-03-22 Thread Panu Matilainen
On 03/22/2017 01:34 PM, Mark Wielaard wrote: On Tue, 2017-03-21 at 14:15 +0200, Panu Matilainen wrote: Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited binary builds (which can be handy for testing when working on large packages), eg: rpmbuild -bi foo.spec; rpmbuild

[Rpm-maint] [PATCH v2] Unbreak short-circuited binary builds (RhBug:1434235)

2017-03-21 Thread Panu Matilainen
Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited binary builds (which can be handy for testing when working on large packages), eg: rpmbuild -bi foo.spec; rpmbuild -bb --short-circuit foo.spec The problem is that in a short-circuited build all the links already exist and