Re: [Rpm-maint] [rpm-software-management/rpm] Fix preun scriptlet failure not aborting rpm erase (#74)

2016-07-08 Thread ニール・ゴンパ
Looks good to me as well, just a matter of @ffesti or @lkardos doing the final review to pull it in. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix preun scriptlet failure not aborting rpm erase (#74)

2016-07-06 Thread frediz
Ok thanks for the review. Thanks also for confirming it wasn't intended in the patch, it could have be a change in the policy which I also wondered. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix preun scriptlet failure not aborting rpm erase (#74)

2016-07-06 Thread Panu Matilainen
Looks good to me, the change of behavior was certainly unintended in commit f4a49c3. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Fix preun scriptlet failure not aborting rpm erase (#74)

2016-07-05 Thread frediz
Since commit f4a49c3d446bb180ca6b30a4337065fb6511e641 ( Unceremoniously eliminate rpmpsmNext() ), when a preun scriptlet is failing, rpm continues to be erased. Handling return code of runInstScript. You can view, comment on, or merge this pull request online at: