Funny how things seem clearer without a headache...
Obviously one needs to be able to pass escaped macros as arguments, another
example to show current non-sensical behavior:
```
$ rpm --define "%foo() %1" --eval "%foo %{_lib}" --eval "%foo %%{_lib}"
lib64
lib64
```
I have a fix for that, just
The latter case fixed now in commit 9ae7d1df313b7a2b9fd74fef5a176dcdce40b88b,
thanks for the cases!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I also think you should expand the macros after splitting the arguments, so
that the behavior is more useful and compatible. Example:
```
%foo() 1:%1 2:%2
```
And `rpm --eval "%foo %nil bar` should return `1: 2:bar` like before.
--
You are receiving this because you are subscribed to this
Use a simple heuristic instead of looking at the lead type when we can't
decided if a header is from a source package or not.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/218
-- Commit Summary --
* Add
Oh and BTW, if this fixes the immediate issue you have and then we can deal
with the build-side of things(%defattr and the like) in a separate patch later
on.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Thanks @pmatilai . Is it okay if i open a new PR ? . I never tried updating a
PR ;-(
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Thats ok too :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302379516___
Rpm-maint mailing list
First and last patch look good. Pushed. Thanks you very much!
Wrt putting the --rpmfcdebug output to stdout: Can't you just redirect stderr
for you use case?
While stderr and stdout output is messed up in rpm the proposed patch really
moves into the wrong direction. I am closing this PR for
Closed #216.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/216#event-1087632114___
Rpm-maint mailing list
Closed #191.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/191#event-1087640612___
Rpm-maint mailing list
Pushed first patch. Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/191#issuecomment-302381244___
Rpm-maint mailing list
@pmatilai I just opened a new PR. Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302382832___
Rpm-maint
Platforms like AIX has system instead of root as the primary group (gid=0).
This patch generalize these stuffs rather than hard coding in the code. This PR
is opened to incorporate the changes needed after the review of another PR
https://github.com/rpm-software-management/rpm/pull/215
You can
...and the initial case fixed in 767d61ca3dba9745d392fa28bbe09a209bd49522.
Again, thanks for spotting and reporting! It's s much nicer to fix such
things pre-release time at your leisure without having an angry mob of
packagers yelling "you bastard you broke my stuff" at you :)
--
You are
Closed #217.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/217#event-1087571377___
Rpm-maint mailing list
Looks much better, thanks, please update this PR with the new version.
Having to awk for the username seems a bit gross but then I would've expected
`id` to take numbers since day one, which clearly is not the case (it doesn't
work in RHEL-5 or -6 either) maybe we'll just have to live with it.
Superceded by #219.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302408410___
Rpm-maint mailing list
Nope, I don't like it any more than the last time around, and I don't see
anything here that would change my mind - "without having to pass extra
arguments" doesn't sound like a very convincing argument.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
Closed #219.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/219#event-1087841680___
Rpm-maint mailing list
It is going nowhere. Let's close this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/173#issuecomment-302463158___
Rpm-maint
Closed #173.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/173#event-1088142672___
Rpm-maint mailing list
This is an alternative solution to the part in
https://github.com/rpm-software-management/rpm/pull/216 that was rejected.
Rather than changing the behavior of the existing `--rpmfcdebug` option, this
adds a new option `--all-per-file`, which outputs the same information as
`--rpmfcdebug` does,
Like noted in #215, having to awk for the username seems a bit gross but then I
would've expected id to take numbers since day one, which clearly is not the
case (it doesn't work in RHEL-5 or -6 either) maybe we'll just have to live
with it.
There was a thinko/editing mistake in the patch
Closed #215.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#event-1087827090___
Rpm-maint mailing list
Oh, my mistake. Skipped from my eyes. Thanks @pmatilai
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #202.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/202#event-1087823736___
Rpm-maint mailing list
Is this still going anywhere or can we close it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/173#issuecomment-302387209___
27 matches
Mail list logo
