Re: [Rpm-maint] [PATCH] Support eu-strip --reloc-debug-sections with find-debuginfo -r

On Thu, 2011-05-26 at 16:39 +0200, devzero2000 wrote: On Wed, May 25, 2011 at 11:36 PM, Mark Wielaard m...@redhat.com wrote: The attached patch adds an -r argument flag to find-debuginfo. When that flag is given then find-debuginfo will invoke eu-strip with --reloc-debug-sections

[Rpm-maint] [PATCH] plugins/systemd_inhibit.c: Define DBUS_TYPE_UNIX_FD if undefined.

Older dbus versions (at least 1.2.24) don't define it by default. --- plugins/systemd_inhibit.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/systemd_inhibit.c b/plugins/systemd_inhibit.c index badcc9e..1dd66e6 100644 --- a/plugins/systemd_inhibit.c +++

Re: [Rpm-maint] [PATCH] plugins/systemd_inhibit.c: Define DBUS_TYPE_UNIX_FD if undefined.

. An alternative would be checking for dbus 1.3+ which has DBUS_TYPE_UNIX_FD. See attached. Cheers, Mark From 5220c09a6a41e1b7cd9ec721409a7a069f9cc2b6 Mon Sep 17 00:00:00 2001 From: Mark Wielaard m...@redhat.com Date: Tue, 5 Mar 2013 20:35:19 +0100 Subject: [PATCH] Require dbus = 1.3

[Rpm-maint] Getting make check to work

}' literally. I am configuring with: --with-external-db \ CPPFLAGS=-I/usr/include/nspr4 -I/usr/include/nss3 -I/usr/include/db4 Does this ring any bell? Thanks, Mark From 8ee4a07b970a834547dff1d95343a9ff86cb4597 Mon Sep 17 00:00:00 2001 From: Mark Wielaard m...@redhat.com Date: Tue, 5 Mar 2013 21:52:36

Re: [Rpm-maint] Getting make check to work

On Wed, 2013-03-06 at 15:28 +0200, Panu Matilainen wrote: ./configure CPPFLAGS=`pkg-config --cflags nss` --with-external-db make make check [...] And finally, thanks for complaining about this, really. One can only explain known bugs so many times before it gets so irritating as to

[Rpm-maint] [PATCH] Don't use hardcoded paths to tools/scripts in find-debuginfo.sh.

This prevents installation and testing in any other location than /usr/lib/rpm. Signed-off-by: Mark Wielaard <m...@redhat.com> --- scripts/find-debuginfo.sh | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh

Re: [Rpm-maint] [PATCH 3/4] Add sepdebugcrcfix to fixup old style gnu_debuglink CRC checksum.

On Tue, 2016-06-07 at 10:33 +0200, Thierry Vignaud wrote: > On 6 June 2016 at 23:00, Mark Wielaard <m...@redhat.com> wrote: > > Some old tools might still use the .gnu_debuglink section to find > > separate debuginfo files instead of build-id style lookups. When > > dw

[Rpm-maint] [PATCH 2/4] Add dwz debuginfo compression support.

by me. Signed-off-by: Mark Wielaard <m...@redhat.com> --- macros.debug | 13 macros.in| 2 +- scripts/find-debuginfo.sh| 53 ++ tests/data/SPECS/hello2.spec | 62 +++ tests/rpmbu

[Rpm-maint] Some rpm debuginfo improvements

Hi, As discussed on rpm-ecosystem I am working on some debuginfo improvements. Some improvements have been accepted as new feature for Fedora 25: https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo I am keeping track of all ideas here:

Re: [Rpm-maint] [PATCH] RFC: Add build-id links to rpm for all ELF.

On Thu, Jun 02, 2016 at 04:35:55PM +0200, Mark Wielaard wrote: > Yeah, I had to move the symlinking code from find-debuginfo.sh (which > uses debugedit to get the build-ids) to the main rpm code since there is > no way for find-debuginfo.sh to add anything to an existing package fi

[Rpm-maint] [PATCH 4/4] Add build-id links to rpm for all ELF files.

the various settings using the new keyword "buildid". Signed-off-by: Mark Wielaard <m...@redhat.com> --- build/Makefile.am | 4 + build/files.c | 375 configure.ac | 15 + macros.in | 28

[Rpm-maint] [PATCH 3/4] Add sepdebugcrcfix to fixup old style gnu_debuglink CRC checksum.

. The original fix was created by Jan Kratochvil based on code from GNU binutils BFD. https://bugzilla.redhat.com/show_bug.cgi?id=971119 I added a testcase to make sure the CRCs were all correctly updated after dwz has run to compress a debuginfo package. Signed-off-by: Mark Wielaard <m...@redhat.

[Rpm-maint] [PATCH 1/4] Add find-debuginfo.sh -m minisymtab support.

was added to Fedora rpm by Alexander Larsson. Lubos Kardos fixed a bug in it when strip -g was used. I added some configuration macros and two testcases to check the basic support works and for the strip -g bug. Signed-off-by: Mark Wielaard <m...@redhat.com> --- Makefile.am

Re: [Rpm-maint] [PATCH] RFC: Add build-id links to rpm for all ELF.

Hi all, On Wed, 2016-04-13 at 20:59 +0200, Mark Wielaard wrote: > This is an RFC patch to move the main ELF file build-id symlinks > from the debuginfo package into the main package and to use a > different base directory for the main ELF file build-id symlink. > Use /usr/lib/.buil

[Rpm-maint] [PATCH 6/7] Make it possible to have unique build-ids across build versions/releases.

Introduce a new macro _unique_build_ids that when set will pass the version and release to find-debuginfo.sh and debugedit to recalculate the build-id of ELF files. Includes two new testcases to make sure the new setting works as expected both when set and unset. Signed-off-by: Mark Wielaard &l

[Rpm-maint] [PATCH 5/7] Add build-id links to rpm for all ELF files.

the various settings using the new keyword "buildid". Signed-off-by: Mark Wielaard <m...@redhat.com> --- build/Makefile.am | 4 + build/files.c | 375 configure.ac | 15 + macros.in | 28

Re: [Rpm-maint] [PATCH 3/4] Add sepdebugcrcfix to fixup old style gnu_debuglink CRC checksum.

Hi Thierry, On Mon, 2016-06-13 at 14:33 +0200, Thierry Vignaud wrote: > Could you provide a small example? From the bug report it isn't clear if > > it really is a bug with that particular fix or that it is caused by bad > > usage of attributes. If we have a small example we can create a test > >

[Rpm-maint] [PATCH 2/7] Add dwz debuginfo compression support.

by me. Signed-off-by: Mark Wielaard <m...@redhat.com> --- macros.debug | 13 macros.in| 2 +- scripts/find-debuginfo.sh| 53 ++ tests/data/SPECS/hello2.spec | 62 +++ tests/rpmbu

Re: [Rpm-maint] [PATCH] RFC: Add build-id links to rpm for all ELF.

On Thu, 2016-05-26 at 17:00 +0200, Mark Wielaard wrote: > I am integrating this patch with the patches I posted that integrate the > debuginfo package handling from fedora and the new testcases and wanted > to make the behavior configurable so a distro can setup a macro to > define wh

[Rpm-maint] [PATCH] Add option to have unique debug file names across version/release/arch.

Introduce a new macro _unique_debug_names that when set will pass --unique-debug-arch "%{_arch}" to find-debuginfo.sh to create debuginfo files which end in "--..debug" instead of simply ".debug". Adds testcases for dwz and buildid with and without unique debug fi

[Rpm-maint] [PATCH] configure --with-external-db should fall back to internal if not specified.

configure.ac implies that there is a fall back to the internal db if no external one is specified or found. But that doesn't work since with_external_db defaults to no when not --with[out]-external-db isn't given. Fix that by defaulting to "maybe" and then first check for an external db before

[Rpm-maint] [PATCH] Make sure CPPFLAGS are setup correctly for finding nspr.h

If we have pkgconfig make sure CPPFLAGS are setup correctly for the nss -I include path. Otherwise the checks to find nspr.h will fail. --- configure.ac | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configure.ac b/configure.ac index fd73b33..3befb15 100644 --- a/configure.ac +++

Re: [Rpm-maint] [PATCH] configure --with-external-db should fall back to internal if not specified.

On Fri, 2016-03-18 at 17:17 +0100, Mark Wielaard wrote: > configure.ac implies that there is a fall back to the internal db if > no external one is specified or found. But that doesn't work since > with_external_db defaults to no when not --with[out]-external-db isn't >

[Rpm-maint] [PATCH] RFC: Add build-id links to rpm for all ELF.

This is an RFC patch to move the main ELF file build-id symlinks from the debuginfo package into the main package and to use a different base directory for the main ELF file build-id symlink. Use /usr/lib/.build-id instead of /usr/lib/debug/.build-id There are two reasons for doing this. The main

[Rpm-maint] [PATCH 2/2] Add sepdebugcrcfix to fixup old style gnu_debuglink CRC checksum.

. The original fix was created by Jan Kratochvil based on code from GNU binutils BFD. https://bugzilla.redhat.com/show_bug.cgi?id=971119 I added a testcase to make sure the CRCs were all correctly updated after dwz has run to compress a debuginfo package. Signed-off-by: Mark Wielaard <m...@redhat.

[Rpm-maint] [PATCH 1/2] Add dwz debuginfo compression support.

by me. Signed-off-by: Mark Wielaard <m...@redhat.com> --- macros.debug | 13 macros.in| 2 +- scripts/find-debuginfo.sh| 53 ++ tests/data/SPECS/hello2.spec | 62 +++ tests/rpmbu

[Rpm-maint] [PATCH] Add find-debuginfo.sh -m minisymtab support.

macros.debug is added that is used to generate debuginfo packages in the rpmbuild.at testsuite. The original rpm-4.10.0-minidebuginfo.patch in Fedora was created by Panu Matilainen and Lubos Kardos. Signed-off-by: Mark Wielaard <m...@redhat.com> --- Makefile.am

Re: [Rpm-maint] [PATCH] Add find-debuginfo.sh -m minisymtab support.

On Wed, 2016-05-11 at 22:29 +0300, Panu Matilainen wrote: > On 05/11/2016 05:41 PM, Mark Wielaard wrote: > > The original rpm-4.10.0-minidebuginfo.patch in Fedora was created by > > Panu Matilainen and Lubos Kardos. > > Credit where credit is due: I merely added

Re: [Rpm-maint] [PATCH 0/3] find-debuginfo.sh speedup

Hi, On Fri, 2016-07-01 at 22:43 +0200, Michal Marek wrote: > this series allows find-debuginfo.sh to run in parallel. It also makes the > duplicate build-id links predictable. The build-id link code was completely rewritten in one of the patches I wrote some weeks ago:

[Rpm-maint] [PATCH] Add option to have unique debug source dirs across version/release/arch.

From: Mark Wielaard <m...@klomp.org> Introduce a new macro _unique_debug_srcs that when set will pass --unique-debug-src-base "%{name}" to find-debuginfo.sh which will move sources into a unique "--." directory under /usr/src/debug/ and makes debugedit rewrite the sou

Re: [Rpm-maint] [PATCH] Add option to have unique debug source dirs across version/release/arch.

On Tue, 2017-02-28 at 21:34 +0100, Mark Wielaard wrote: > @@ -305,7 +317,18 @@ do_file() >if [ ! -z "$ver_rel" ]; then > build_id_seed="--build-id-seed=$ver_rel" >fi > - id=$(${lib_rpm_dir}/debugedit -b "$RPM_BUILD_DIR" -d /usr/src

[Rpm-maint] [PATCH] Include new test data spec files in EXTRA_DIST.

From: Mark Wielaard <m...@klomp.org> Commit bbfe1f8 (Add build-id links to rpm for all ELF files) and Commit bbfe1f8 (Make it possible to have unique build-ids across build versions/releases) Introduced new test spec files (hello-r2.spec, hello2cp.spec and hello2ln.spec)

Re: [Rpm-maint] [PATCH] Include new test data spec files in EXTRA_DIST.

On Wed, 2017-03-01 at 15:28 +0100, Mark Wielaard wrote: > From: Mark Wielaard <m...@klomp.org> > > Commit bbfe1f8 (Add build-id links to rpm for all ELF files) and > Commit bbfe1f8 (Make it possible to have unique build-ids across build > versions/release

[Rpm-maint] [PATCH] debugedit: Support String/Line table rewriting for larger/smaller paths.

From: Mark Wielaard <m...@klomp.org> debugedit --base to --dest rewriting of debug source file paths only supported dest paths that were smaller or equal than the base path (and the size should differ more than 1 character for correct debug lines). All paths were changed "in place&qu

[Rpm-maint] [PATCH] Fix misleading-indentation in rpmplugins.c

!= NULL. Signed-off-by: Mark Wielaard <m...@redhat.com> --- lib/rpmplugins.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/rpmplugins.c b/lib/rpmplugins.c index 1022024..97e5d30 100644 --- a/lib/rpmplugins.c +++ b/lib/rpmplugins.c @@ -214,10 +214,11 @@ static rpmRC rpmp

[Rpm-maint] [PATCH] Fix mini-symtab in find-debuginfo.sh for arches with function descriptors.

--format=sysv style to match the ELF symbol type directly instead of using the somewhat ambiguous symbol type char used in --format=posix style in binutils nm. https://bugzilla.redhat.com/show_bug.cgi?id=1052415 Signed-off-by: Mark Wielaard <m...@redhat.com> --- scripts/find-debuginfo.sh | 5 ++

[Rpm-maint] [PATCH] find-debuginfo.sh: Don't copy extra sections into .gnu_debugdata.

-allocated PROGBITS or NOTE sections. https://bugzilla.redhat.com/show_bug.cgi?id=1382394 Signed-off-by: Mark Wielaard <m...@redhat.com> --- scripts/find-debuginfo.sh | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/scripts/find-debuginfo.sh b/scripts/find-debugi

[Rpm-maint] [PATCH] Fix libdw configure check.

commit a82119 "configure.ac: use LIBDW always conditionally" contained a typo that caused WITH_LIBDW_LIB never to be set when you were using libelf. Fixed by reverting the "!=" to "=" again. Signed-off-by: Mark Wielaard <m...@redhat.com> --- configure.ac | 2 +

Re: [Rpm-maint] RPM 4.13.0 rc2 released

On Fri, 2016-10-21 at 12:33 +0300, Panu Matilainen wrote: > On 10/21/2016 12:09 PM, Thierry Vignaud wrote: > > On 21 October 2016 at 08:51, Panu Matilainen wrote: > > > Please test and report any anomalies. From rc2 to final only regression > fixes will be allowed.

Re: [Rpm-maint] [rpm-software-management/rpm] Build fixes related to (#108)

On Thu, Dec 08, 2016 at 11:57:50PM -0800, DNF Bot wrote: > Can one of the admins verify this patch? Could you please include the patch you want to see verified in your message? Thanks, Mark ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

[Rpm-maint] [PATCH] Link testing/usr/bin to testing/bin.

Some tests running under fakechroot started failing because scripts tried to execute /usr/bin/rm but inside the testing chroot /usr/bin and /bin aren't linked. Just symlink testing/usr/bin to testing/bin to simulate a unified /usr setup. Signed-off-by: Mark Wielaard <m...@redhat.com> ---

[Rpm-maint] Unable to build after Stop messing with CFLAGS from configure patch

themselves? Thanks, Mark >From 7a17a1eeb058cbafe59863ea40e8b0f697ca6bc8 Mon Sep 17 00:00:00 2001 From: Mark Wielaard <m...@redhat.com> Date: Fri, 9 Dec 2016 09:31:58 +0100 Subject: [PATCH] Define AM_CFLAGS inside the Makefile.am files themselves. Trying to include AM_CFLAGS through a configu

Re: [Rpm-maint] [rpm-software-management/rpm] Build fixes related to (#108)

Hi rpm-maint, On Thu, 2016-12-08 at 15:08 -0800, Thomas Petazzoni wrote: > You can view, comment on, or merge this pull request online at: > > https://github.com/rpm-software-management/rpm/pull/108 I am not sure what to make of this mail message, or how to properly reply. It is somewhat

Re: [Rpm-maint] [PATCH] Unbreak short-circuited binary builds

On Thu, Jan 05, 2017 at 03:40:42PM +0200, Panu Matilainen wrote: > > > When checking for pre-existing links see if they already point to > > > the right file and in that case just reuse it instead of creating new > > > ones. > > > > > @@ -1572,6 +1573,16 @@ static int addNewIDSymlink(FileList

Re: [Rpm-maint] [PATCH] Unbreak short-circuited binary builds

On Thu, Jan 05, 2017 at 01:47:28PM +0200, Panu Matilainen wrote: > Commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 broke short-circuited > binary builds (which can be handy for testing when working on large > packages), eg: > rpmbuild -bi foo.spec; rpmbuild -bb --short-circuit foo.spec > >

Re: [Rpm-maint] [PATCH] Only process regular files when generating build-ids

On Thu, Jan 05, 2017 at 12:27:52PM +0200, Panu Matilainen wrote: > It looks commit bbfe1f86b2e4b5c0bd499d9f3dd9de9c9c20fff2 intends to skip > symlinks since it filters on S_ISREG(), but since uses fstat() > on already open()'ed file it ends up stat()'ing the symlink target. > Flip stat() + open()

Re: [Rpm-maint] [PATCH] Link testing/usr/bin to testing/bin.

On Fri, Dec 09, 2016 at 11:36:19AM +0100, Mark Wielaard wrote: > Some tests running under fakechroot started failing because scripts tried > to execute /usr/bin/rm but inside the testing chroot /usr/bin and /bin > aren't linked. Just symlink testing/usr/bin to testing/bin to simulate &g

Re: [Rpm-maint] [PATCH 2/5] Only build bundled fts if system has a bad version that doesn't handle LFS

On Fri, 2017-03-24 at 11:15 +0200, Panu Matilainen wrote: > On 03/23/2017 08:21 PM, Gleb Fotengauer-Malinovskiy wrote: > > diff --git a/configure.ac b/configure.ac > > index bdcb741..687d58c 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -717,6 +717,9 @@ AC_CHECK_FUNCS( > >

Re: [Rpm-maint] [PATCH v2] Unbreak short-circuited binary builds (RhBug:1434235)

ey already point to the right file and in that case just reuse it instead of creating new ones. Keep track of duplicate build-ids found by noticing existing links that point to different targets. But don't do this for compat links, they should just point to the last (duplicate) main build-id symlin

[Rpm-maint] [PATCH] build/files.c (generateBuildIDs): Fix small memory leak.

From: Mark Wielaard <m...@klomp.org> mainiddir and debugiddir are allocated through rpmGetPath () and should be released when done. Signed-off-by: Mark Wielaard <m...@klomp.org> --- build/files.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/build/files.c b/build/files.c i

[Rpm-maint] [PATCH] debugedit: Fix cross-endian build-id reading and updating section data.

From: Mark Wielaard <m...@klomp.org> debugedit doesn't read raw mmap data any longer. Which made the complex way to read the build-id unnecessary (and it was broken for cross-endian). Just use gelf_getnote to read the notes. Also in some special cases when only the debug_info or build_i

Re: [Rpm-maint] [rpm-software-management/rpm] error: Missing build-id in /builddir/build/BUILDROOT/... (#177)

On Wed, 2017-03-15 at 20:50 +0100, Mark Wielaard wrote: > I couldn't replicate this with the current fedora guile-2.0.14-1 > package. There the .go files are not actual ELF files. So rpm will not > complain about them not having a build-id. If that has changed in with > guile 2.1.8

[Rpm-maint] [PATCH] build/files.c: Only check build-ids for executable files in the main package.

From: Mark Wielaard <m...@klomp.org> generateBuildIDs should mimic what find-debuginfo.sh does. Only check build-ids for executable files in non-debuginfo packages. This moves the isDbg check up so the is executeble check can be done when the file is part of the main package. This

[Rpm-maint] [PATCH] tests/rpmbuildid.at: Make file sed regexp more strict to extract BuildID.

From: Mark Wielaard <m...@klomp.org> Like commit f0a5819 for rpmbuild.at. In the case of rpmbuildid.at the sed expression looked to work, but only matched by accident. Make the sed regexp more strict by only matching a hex-string. And properly "escape" [ and ] which inside an

[Rpm-maint] [PATCH] debugedit: Fix edit_dwarf2_line replace_dirs -> replace_files typo.

From: Mark Wielaard <m...@klomp.org> We wouldn't replace the changed file names if replace_dirs was false, but replace_files was true. This could overrun the new debug_line data buffer if the original file name was larger than the replacement. It wasn't found before because often when w

[Rpm-maint] [PATCH] build/files.c (processPackageFiles): Don't call generateBuildIDs for noarch.

From: Mark Wielaard <m...@klomp.org> We don't want to do build-id processing for noarch packages. It might be that noarch packages do contain architecture depended files, but those are already handled by processBinaryFiles. This fixes the building of openbios in fedora.

[Rpm-maint] [PATCH] Make sure to reset file attributes for generated build-id directories.

From: Mark Wielaard <m...@klomp.org> [Note this patch is currently being tested in Fedora. See bug below.] When creating the build-id directories we should reset the file attributes to the defaults. Otherwise if the file list contained an %attr or %defattr the directories would co

Re: [Rpm-maint] [rpm-software-management/rpm] error: Missing build-id in /builddir/build/BUILDROOT/... (#177)

On Wed, 2017-03-15 at 10:10 -0700, John Dulaney wrote: > When scratch building a source rpm (0) in koji (1), I receive the following > error in the build log: > > error: Missing build-id in > /builddir/build/BUILDROOT/guile-2.1.8-1.fc27.x86_64/usr/lib64/guile/2.2/ccache/language/elisp/spec.go >

[Rpm-maint] [PATCH] Make rpmsign tests work for builddir != srcdir.

The gpg HOME is in the builddir testing directory. But the keys to import are in the srcdir data/keys directory. Signed-off-by: Mark Wielaard <m...@klomp.org> --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am

[Rpm-maint] [PATCH] debugedit: Only output comp_dir under build dir (once).

#641022 (commit c707ab). Both fixes are necessary in case of an unexpected mode for a directory actually in the build root that we want to include in the source list. Signed-off-by: Mark Wielaard <m...@klomp.org> --- tools/debugedit.c | 39 --- 1 file c

[Rpm-maint] [PATCH] debugedit: Add -n, --no-recompute-build-id.

. %_no_recompute_build_ids can not be used together with %_unique_build_ids. Signed-off-by: Mark Wielaard <m...@klomp.org> --- macros.in | 7 ++- scripts/find-debuginfo.sh | 20 +++- tests/rpmbuildid.at | 122 ++

[Rpm-maint] [PATCH] find-debuginfo.sh: Only add minisymtab for executables or shared libraries.

It only makes sense to add a minisymtab for executables and shared libraries. Other executable ELF files (like kernel modules) don't need it. Since those don't have a dynsym section trying to add it will fail and produce confusing errors from nm. Signed-off-by: Mark Wielaard <m...@klomp.

[Rpm-maint] [PATCH] build/files.c: Unset __debug_package implies missing build-ids aren't fatal.

From: Mark Wielaard <m...@klomp.org> Historically we have only checked build_ids when __debug_package was defined. So don't terminate the build if __debug_package is unset, even when _missing_build_ids_terminate_build is. Only warn. Signed-off-by: Mark Wielaard <m...@klomp.org>

Re: [Rpm-maint] [PATCH] generateBuildIDs: Don't warn or error for object files without build-id.

On Thu, 2017-03-09 at 12:22 +0200, Panu Matilainen wrote: > On 03/09/2017 10:34 AM, Mark Wielaard wrote: > > From: Mark Wielaard <m...@klomp.org> > > > > Only loadable ELF images (executables, shared libraries, kernel modules) > > should have build-ids. So don't

[Rpm-maint] [PATCH] tests/tpmbuild.at: Make file sed regexp more strict to extract BuildID.

From: Mark Wielaard <m...@klomp.org> In some testcases we extract the BuildID with the file command. Unfortunately the file command output changed slightly between versions. Make the sed regexp more strict by only matching a hex-string. Also properly "escape" [ and ] which in

[Rpm-maint] [PATCH] generateBuildIDs: Don't warn or error for object files without build-id.

From: Mark Wielaard <m...@klomp.org> Only loadable ELF images (executables, shared libraries, kernel modules) should have build-ids. So don't warn or error out when an object file is found without one. Signed-off-by: Mark Wielaard <m...@klomp.org> --- build/files.c | 15 +++

Re: [Rpm-maint] [rpm-software-management/rpm] debug edit build generation is endian dependent when cross-compiling? (#171)

On Sun, 2017-03-05 at 09:48 -0800, Jeff Johnson wrote: > For rpm portability with older versions of elfutils, this harmless sanity > check might be useful: > > (excuse the different hash functions in use in the patch snippet below) > @@ -1533,40 +1493,12 @@ >/* Now format the build ID bits

Re: [Rpm-maint] [PATCH] debugedit: Support String/Line table rewriting for larger/smaller paths.

On Sat, 2017-03-04 at 11:28 +0200, Panu Matilainen wrote: > I dont feel qualified to really review this, and perhaps others are > feeling the same way since it's been out there for a week now with no > comments at all. > > Because this seems quite awesome (even if also a bit scary), to avoid >

Re: [Rpm-maint] [rpm-software-management/rpm] debug edit build generation is endian dependent when cross-compiling? (#171)

On Sun, 2017-03-05 at 09:58 -0800, Jeff Johnson wrote: > Portability of debugedit.c on systems that do not support #include > (solaris, *BSD) can be achieved by duplicating certain DWARF > standard constants: I think you reversed the patch you are proposing again. I'll leave it to others to say

Re: [Rpm-maint] [rpm-software-management/rpm] debug edit build generation is endian dependent when cross-compiling? (#171)

On Sun, 2017-03-05 at 09:09 -0800, Jeff Johnson wrote: > rpm5.org carries this patch from Yocto: > https://patchwork.openembedded.org/patch/46887 > which likely should be added when updating debug edit.c soon. It is slightly hard to review a patch to a patch. Could you extract the precise

[Rpm-maint] [PATCH] Warn and create empty debugsource package if there are no sources.

Signed-off-by: Mark Wielaard <m...@klomp.org> --- scripts/find-debuginfo.sh | 13 + tests/rpmbuild.at | 33 + 2 files changed, 46 insertions(+) diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh index d8725ad..9b3815a

[Rpm-maint] [PATCH] Add two testcases for generating debugsource packages.

-off-by: Mark Wielaard <m...@klomp.org> --- tests/Makefile.am | 1 + tests/data/SPECS/hello-cd.spec | 29 tests/rpmbuild.at | 62 ++ 3 files changed, 92 insertions(+) create mode 100644 tests/data/SPECS

Re: [Rpm-maint] [PATCH 2/2] Test split debuginfo packages with RemovePathPostfixes.

On Fri, 2017-07-28 at 23:24 +0200, Mark Wielaard wrote: > If split debuginfo code doesn't know about RemovePathPostfixes it fails: > > error: Installed (but unpackaged) file(s) found: >/usr/lib/debug/bin/hello.foobar-1.0-1.x86_64.debug This one also now passes with

Re: [Rpm-maint] [PATCH 1/2] Test split debuginfo packages with excluded files.

On Fri, 2017-07-28 at 23:24 +0200, Mark Wielaard wrote: > If split debuginfo code doesn't know about excluded files it fails: > > error: Installed (but unpackaged) file(s) found: >/usr/lib/debug/bin/hello3-1.0-1.x86_64.debug And with Igor's fixes this tes

Re: [Rpm-maint] [PATCH] Add rpmbuild debuginfo subpackages tests.

On Fri, 2017-07-28 at 21:55 +0200, Mark Wielaard wrote: > This adds various tests for making sure multiple subpackages are build > correctly. Without debuginfo subpackages, with subpackages, subpackages > with unique debug file and source dir paths and with separate debugsourc

Re: [Rpm-maint] [PATCH] Warn and create empty debugsource package if there are no sources.

Hi, On Fri, 2017-07-28 at 15:29 +0200, Mark Wielaard wrote: > + if [ ! -s "$srcout" ]; then > +echo >&2 "*** WARNING: No source files found. Creating empty > debugsource package" > +# Create the empty directory. > +# See also debug

Re: [Rpm-maint] [PATCH] Warn and create empty debugsource package if there are no sources.

On Wed, 2017-08-02 at 17:43 +0200, Igor Gnatenko wrote: > On Wed, 2017-08-02 at 13:09 +0200, Mark Wielaard wrote: > > Do we want to be nicer to packages that don't include sources like > > this? > > Or should we just declare that this is probably a packaging issue > >

[Rpm-maint] [PATCH] find-debuginfo.sh: Add --keep-section and --remove-section for eu-strip.

=1465997 Signed-off-by: Mark Wielaard <m...@klomp.org> --- scripts/find-debuginfo.sh | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh index 5613391..e19ce9b 100755 --- a/scripts/find-debuginfo.sh

Re: [Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

ined in another header in the first place. Thanks, Mark From 77a745abd88f278b4c29aadefb2f6c5d47bde5e6 Mon Sep 17 00:00:00 2001 From: Mark Wielaard <m...@klomp.org> Date: Wed, 19 Jul 2017 14:43:28 +0200 Subject: [PATCH] config: Detect major/minor warnings and include the correct system head

[Rpm-maint] [PATCH] find-debuginfo.sh: Remove non-allocated NOBITS sections from minisymtab.

. Signed-off-by: Mark Wielaard <m...@klomp.org> --- scripts/find-debuginfo.sh | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh index e19ce9b..2fa95e8 100755 --- a/scripts/find-debuginfo.sh +++ b/scripts/find-debugi

[Rpm-maint] [PATCH] config: Detect major/minor warnings and include the correct system header.

M_FIELD(hdr->devMajor, dev, field); ^~ Adjust the configure check and undef the warning producing macros to get rid of the wrong definitions and use the macros from the right include. Tested against RHEL7 (glibc 2.17) and Fedora 26 (glibc 2.25). Signed-o

[Rpm-maint] [PATCH] replaceSigDigests is only used with IMAEVM.

The replaceSigDigests function is only used in includeFileSignatures when WITH_IMAEVM is defined. If not warning is generated. Signed-off-by: Mark Wielaard <m...@klomp.org> --- sign/rpmgensig.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sign/rpmgensig.c b/sign/rpmgensig.c

[Rpm-maint] [PATCH] debugedit: skip_dir_prefix should check for dir separator.

named similar to the package source dir (which cargo on fedora does, by adding a directory named cargo-vendor in the builddir itself). Signed-off-by: Mark Wielaard <m...@klomp.org> --- tools/debugedit.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/debug

[Rpm-maint] [PATCH] find-debuginfo.sh: Filter out all like fake file names.

trings "" and "". Just filter out all '(^|/)<[a-z _-]+>$'. They are fake files! This is mainly to appease the rustc compiler which generates lots of different variants to encode some instruction sequence is part of an compiler generated macro expansion. Signed-off-b

[Rpm-maint] [PATCH] find-debuginfo.sh: Use 'return', not 'continue', to break out do_file().

meaningful in a `for', `while', or `until' loop https://bugzilla.redhat.com/show_bug.cgi?id=1465170 Signed-off-by: Mark Wielaard <m...@klomp.org> --- scripts/find-debuginfo.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/find-debuginfo.sh b/scripts/find-de

[Rpm-maint] [PATCH 2/3] Use a file list to add build-id files to pkgList.

-by: Mark Wielaard <m...@klomp.org> --- build/files.c | 74 ++- 1 file changed, 33 insertions(+), 41 deletions(-) diff --git a/build/files.c b/build/files.c index c7debdc..cb7def6 100644 --- a/build/files.c +++ b/build/files.c @@ -1614,6 +1

[Rpm-maint] [PATCH 3/3] Change mkattr to always create a %defattr with explicitly set modes.

pendent of any umask settings. This works as is for both files and directories, so no file argument is necessary anymore. https://bugzilla.redhat.com/show_bug.cgi?id=1452893 https://bugzilla.redhat.com/show_bug.cgi?id=1458839 Signed-off-by: Mark Wielaard <m...@klomp.org> --- build/files.c | 17

[Rpm-maint] [PATCH 1/3] Extract package file list processing in separate functions.

Extract two functions resetPackageFilesDefaults() and addPackageFileList() from processPackageFiles(). This will make it possible to add multiple (generated) file lists to a package later. Signed-off-by: Mark Wielaard <m...@klomp.org> --- build/files.c

[Rpm-maint] [PATCH 1/2] Test split debuginfo packages with excluded files.

If split debuginfo code doesn't know about excluded files it fails: error: Installed (but unpackaged) file(s) found: /usr/lib/debug/bin/hello3-1.0-1.x86_64.debug Signed-off-by: Mark Wielaard <m...@klomp.org> --- tests/Makefile.am | 1 + tests/data/SPEC

[Rpm-maint] [PATCH 2/2] Test split debuginfo packages with RemovePathPostfixes.

If split debuginfo code doesn't know about RemovePathPostfixes it fails: error: Installed (but unpackaged) file(s) found: /usr/lib/debug/bin/hello.foobar-1.0-1.x86_64.debug Signed-off-by: Mark Wielaard <m...@klomp.org> --- tests/Makefile.am | 1 + ..

[Rpm-maint] [PATCH] Add rpmbuild debuginfo subpackages tests.

This adds various tests for making sure multiple subpackages are build correctly. Without debuginfo subpackages, with subpackages, subpackages with unique debug file and source dir paths and with separate debugsources. Signed-off-by: Mark Wielaard <m...@klomp.org> --- tests/Makef

[Rpm-maint] [PATCH] Make sure that debugsourcefiles.list is generated in the build dir.

The %_debugsource_template expects the debugsourcefiles.list file to be in the (current) build dir. Make sure that is always the case even if find-debuginfo.sh was invoked in a different (sub) directory by adding the build dir path as explicit argument to -S. Signed-off-by: Mark Wielaard &l

[Rpm-maint] [PATCH] find-debuginfo.sh: Don't create dwz multi file if there is only one .debug.

.debug file. Signed-off-by: Mark Wielaard <m...@klomp.org> --- scripts/find-debuginfo.sh | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/scripts/find-debuginfo.sh b/scripts/find-debuginfo.sh index aaf4c75..7ab39a2 100755 --- a/scripts/find-debuginfo.sh +++ b/s

[Rpm-maint] [PATCH] Update find-debuginfo.sh options and macros documentation.

This adds some missing documentation for rpm macros and find-debuginfo.sh options that were recently added (or renamed). -j N, --build-id-seed SEED, --unique-debug-suffix SUFFIX and --unique-debug-src-base BASE. Signed-off-by: Mark Wielaard <m...@klomp.org> --- macros.in

Re: [Rpm-maint] [PATCH] Use a file list to add build-id files to pkgList and explicitly set attrs.

From 739796798ac854f80ae2f0d677f74bca734055f7 Mon Sep 17 00:00:00 2001 From: Mark Wielaard <m...@klomp.org> Date: Wed, 21 Jun 2017 16:57:13 +0200 Subject: [PATCH] Use a file list to add build-id files to pkgList and explicitly set attrs. mkattr used "-" as default mode which would

[Rpm-maint] [PATCH] rpmbuild: Reset attrFlags in generateBuildIDs.

Debuginfo directories and files could be marked as configuration files if the file list ended with a config file. Patch by Panu Matilainen. Testcase by me. https://bugzilla.redhat.com/show_bug.cgi?id=1449732 Signed-off-by: Mark Wielaard <m...@klomp.org> --- build/f

Re: [Rpm-maint] [PATCH] rpmbuild: Reset attrFlags in generateBuildIDs.

ut the attached which just uses /bin and /etc. The actual path used doesn't really matter for the test and this should work whatever --prefix you happen to configure with. Thanks, Mark >From 396a52016dfde76a6d3c89b15d998a30341517b5 Mon Sep 17 00:00:00 2001 From: Mark Wielaard <m...@klomp.org>

[Rpm-maint] [PATCH] Use a file list to add build-id files to pkgList and explicitly set attrs.

those files using the defaults mode/attr settings as if they were part of the original package file list. https://bugzilla.redhat.com/show_bug.cgi?id=1452893 https://bugzilla.redhat.com/show_bug.cgi?id=1458839 Signed-off-by: Mark Wielaard <m...@klomp.org> --- build/files.c

[Rpm-maint] [PATCH] Add debugsource recommends to debuginfo packages.

findDebugsourcePackage. Use it to add a requires to the main debuginfo file and/or the debuginfo subpackages. Extend the various rpmbuild.at tests that create debugsource and/or debuginfo subpackages to check the debugsource (or main debuginfo) package is recommended. Signed-off-by: Mark Wielaard &l

Re: [Rpm-maint] [PATCH] Add debugsource recommends to debuginfo packages.

On Thu, 2017-09-21 at 10:41 +0300, Panu Matilainen wrote: > Moving an entire function while also changing it is a bit of a no- > no, because it's makes it hard to see what actually changed. Moving > things around also obfuscates git history, which is why I prefer > adding a prototype to the top of

  1   2   >