Re: [Rpm-maint] [PATCH] debugedit: Support String/Line table rewriting for larger/smaller paths.

2017-03-06 Thread Panu Matilainen
On 03/06/2017 01:15 PM, Mark Wielaard wrote: On Sat, 2017-03-04 at 11:28 +0200, Panu Matilainen wrote: I dont feel qualified to really review this, and perhaps others are feeling the same way since it's been out there for a week now with no comments at all. Because this seems quite awesome

Re: [Rpm-maint] [PATCH] debugedit: Support String/Line table rewriting for larger/smaller paths.

2017-03-06 Thread Mark Wielaard
On Sat, 2017-03-04 at 11:28 +0200, Panu Matilainen wrote: > I dont feel qualified to really review this, and perhaps others are > feeling the same way since it's been out there for a week now with no > comments at all. > > Because this seems quite awesome (even if also a bit scary), to avoid >

Re: [Rpm-maint] [PATCH] debugedit: Support String/Line table rewriting for larger/smaller paths.

2017-03-06 Thread Thierry Vignaud
On 4 March 2017 at 10:28, Panu Matilainen wrote: >> From: Mark Wielaard >> >> debugedit --base to --dest rewriting of debug source file paths only >> supported dest paths that were smaller or equal than the base path >> (and the size should differ more

Re: [Rpm-maint] [PATCH] debugedit: Support String/Line table rewriting for larger/smaller paths.

2017-03-04 Thread Panu Matilainen
On 02/27/2017 05:28 PM, Mark Wielaard wrote: From: Mark Wielaard debugedit --base to --dest rewriting of debug source file paths only supported dest paths that were smaller or equal than the base path (and the size should differ more than 1 character for correct debug lines).

[Rpm-maint] [PATCH] debugedit: Support String/Line table rewriting for larger/smaller paths.

2017-02-27 Thread Mark Wielaard
From: Mark Wielaard debugedit --base to --dest rewriting of debug source file paths only supported dest paths that were smaller or equal than the base path (and the size should differ more than 1 character for correct debug lines). All paths were changed "in place". Which could