Closed #215.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#event-1087827090___
Rpm-maint mailing list
Superceded by #219.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302408410___
Rpm-maint mailing list
@pmatilai I just opened a new PR. Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302382832___
Rpm-maint
Thats ok too :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#issuecomment-302379516___
Rpm-maint mailing list
Thanks @pmatilai . Is it okay if i open a new PR ? . I never tried updating a
PR ;-(
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Oh and BTW, if this fixes the immediate issue you have and then we can deal
with the build-side of things(%defattr and the like) in a separate patch later
on.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Looks much better, thanks, please update this PR with the new version.
Having to awk for the username seems a bit gross but then I would've expected
`id` to take numbers since day one, which clearly is not the case (it doesn't
work in RHEL-5 or -6 either) maybe we'll just have to live with it.
@pmatilai Just made few changes as you suggested. See here
https://github.com/aixoss/rpm/commit/2aa6af684319f314407a1eaf58177209f14415f0
About the bunch of %defattr's , since i am not familiar with the code that much
so that i didn't touch that part. If you have any suggestions , please let me
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/215#pullrequestreview-37991936___
