Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
OK, this has not made progress for nearly a year. While there may be some use in further thinking about this the current patch does just not cut it. I am closing this for now. Feel free to continue the discussion on the mailing list or in a new, improved PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#issuecomment-370415455___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
Closed #176. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#event-1504075897___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
Look above and you will find that naming was and still is my concern. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#issuecomment-297813233___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
I wonder if they should be named more similar to bcond_with. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#issuecomment-297742840___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
> I think the problem here is that these macros do use the same name for both > the bcond variable and the configure switch. You are right. Gentoo has [`use_enable`](https://gitweb.gentoo.org/proj/portage.git/tree/bin/ebuild.sh?id=033e7b68cc5495ab43498a73940be23b919aa5cf#n254) and [`use_with`](https://gitweb.gentoo.org/proj/portage.git/tree/bin/ebuild.sh?id=033e7b68cc5495ab43498a73940be23b919aa5cf#n236) , which are more or less prototypes of these macros, can accept two parameters which make them more flexible. I see your point. I will rework the macros to act more like their Gentoo counterparts. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#issuecomment-297703769___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
I think the problem here is that these macros do use the same name for both the bcond variable and the configure switch. I'd rather think that the interesting cases are where you need to have some high level bcond switch may be even resulting in multiple copnfigure switches of different names. Using the same name is especially weird for the disable and without cases. I really cannot see the use case where you would have to pass --with-foo just to have foo disabled in the configure script. I can imagine disabling other features while enabling foo. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#issuecomment-297698504___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
I'd defer to @pmatilai and @ffesti on this, but from my point of view, I'd just name them something like `cfg_enable`, `cfg_disable`, `cfg_with`, `cfg_without`... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#issuecomment-286532743___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
Mmm... You are right, of course. It's been some time, since I've created the
patch and apparently I have forgotten the details.
Anyway there are many configure-like scripts that accept
--enable-/--disable-/--with-/--without- options, not necessarily generated with
autotools. I have found these macros very useful in my work and want to share
them. However, for the patch to be complete there should be a pair of macros
that generate --with-/--without- options. Unfortunately %{with}/%{without} are
not available. How would you name the macros and would you accept them together
with enable/disable?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/176#issuecomment-286523801___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
The with/without macros don't quite work the same way, as they don't assume autotools underneath. Your enable/disable macros do. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#issuecomment-286435578___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
To generate arguments for configure scripts. Take a look a few lines above at
%{with}/%{without} macros. My macros do exactly the same but for
--enable-/--disable-.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/176#issuecomment-286433430___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)
Not that I see anything particularly wrong with this, but, umm, why do you want this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#issuecomment-286406247___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
