[rrd-developers] [PATCH] rrdcached: Fix permissions of the default socket.

2010-11-23 Thread Florian Forster
From: Florian Forster If neither the "-l" nor the "-P" options have been given, a UNIX domain socket at a default location is created. However, due to a missing initialization in this case, the "permissions" field will be left at zero (no command allowed). Th

Re: [rrd-developers] RRDTOOL 1.4.4 fetch with RRDCACHED_ADDRESS

2010-11-19 Thread Florian Forster
Hi swami, On Thu, Nov 18, 2010 at 05:13:07PM -0800, swami wrote: > 2) create rrd >/usr/local/third-party/rrd/bin/rrdtool create > /var/stats/rrd_data/remote_peer_data/rp4.rrd -s 3\ this doesn't work with the current SVN version of RRDtool: Because CREATE is issued via the daemon as well

Re: [rrd-developers] RRD C API's for RRDCACHED

2010-11-13 Thread Florian Forster
On Sat, Nov 13, 2010 at 10:58:33AM +, Alex Bennee wrote: > On 12 November 2010 19:39, Florian Forster wrote: > > the RRDCacheD interface uses a set of separate functions, prefixed > > by "rrdc_" (mnemonic: RRD Client). The functions are similar in > > syntax to

Re: [rrd-developers] RRD C API's for RRDCACHED

2010-11-12 Thread Florian Forster
Hi, On Fri, Nov 12, 2010 at 10:49:28AM -0800, swami wrote: > If i start using rrdcached , is there a variation in the C API calls i > am using currently (rrdupdate , create ) ? If so , what and how do i > get this compiled in. the RRDCacheD interface uses a set of separate functions, prefixed by

[rrd-developers] [PATCH] src/rrd_client.c: Fix a potential segmentation fault in "get_path".

2010-06-30 Thread Florian Forster
The "get_path" function is called at least from "rrdc_update" without checking for a connection first. In that case the "sd_path" pointer may be NULL, so dereferencing it without checking for NULL is not good behavior. This patch checks all arguments of the "get_path" function and returns an error

[rrd-developers] [PATCH 1/2] RRDCacheD: Fix a typo in an error message.

2010-04-29 Thread Florian Forster
From: Florian Forster --- src/rrd_daemon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c index 25675a1..b80ddc4 100644 --- a/src/rrd_daemon.c +++ b/src/rrd_daemon.c @@ -1572,7 +1572,7 @@ static int handle_request_fetch

[rrd-developers] [PATCH 2/2] rrdfetch(1): Document restricted time parsing when using the daemon.

2010-04-29 Thread Florian Forster
From: Florian Forster --- doc/rrdfetch.pod |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/doc/rrdfetch.pod b/doc/rrdfetch.pod index 0052aa6..49b8fc2 100644 --- a/doc/rrdfetch.pod +++ b/doc/rrdfetch.pod @@ -58,6 +58,13 @@ For a list of accepted formats, see the B

[rrd-developers] [PATCH] RRDCacheD: FETCH command: Remove call to "rrd_parsetime".

2010-04-28 Thread Florian Forster
From: Florian Forster "rrd_parsetime" uses (many) global variables and is thus not thread-safe. Using it in the FETCH command reproducably segfaults the caching daemon. This replacement will only work with "simple" integers, i. e. times specified as "1272470594&quo

[rrd-developers] [PATCH] src/rrd_client.[ch]: Relicense under the MIT license.

2010-04-25 Thread Florian Forster
Relicense the RRDCacheD client interface under the MIT license. This allows the interface to be used from non-GPL applications by copying the source code files into the projects source tree. The other copyright holders, Kevin Brintnall and Sebastian Harl, have agreed to this step via email in Apri

Re: [rrd-developers] Relicensing of src/rrd_client.[ch]

2010-04-06 Thread Florian Forster
On Tue, Apr 06, 2010 at 11:41:15PM +0200, Tobias Oetiker wrote: > Florian, can you share the motivation behind the licensing change ? I was asked today if it was possible to add support for sending data to rrdcached to a proprietary application. My first thought was "yes, of course" but then reali

Re: [rrd-developers] Relicensing of src/rrd_client.[ch]

2010-04-06 Thread Florian Forster
On Tue, Apr 06, 2010 at 11:03:07PM +0200, Sebastian Harl wrote: > Since the client interface is compiled into librrd (which makes that > combined work subject to terms of the GPL), a user could not make use > of librrd but would rather have to include rrd_client.[ch] in her own > source tree. Righ

[rrd-developers] Relicensing of src/rrd_client.[ch]

2010-04-06 Thread Florian Forster
Hi Kevin and Sebastian, I would like to open up the rrdcached client interface so it can be used from non-GPL applications. For that I would like to re-license the two files src/rrd_client.h and src/rrd_client.c to a more permissible license. I was thinking about using the MIT license or the

Re: [rrd-developers] git-svn clone of the rrdtool?

2010-03-30 Thread Florian Forster
Hi Alex, On Mon, Mar 29, 2010 at 06:56:23PM +0100, Alex Bennee wrote: > Before I spend any more cycles on this I was wondering if any > contributors have already done a successful import of just the program > with it's version tags into git? I have an automatically updated Git version of trunk/ o

Re: [rrd-developers] [PATCH] RRDCacheD: Add the "FETCH" command.

2010-03-17 Thread Florian Forster
Hi Tobi, On Wed, Feb 24, 2010 at 11:04:39PM +0100, Tobias Oetiker wrote: > > Add a "FETCH" command to RRDCacheD which behaves like a (simplified > > version of) rrdfetch(1). > [...] > > I guess it's time to branche again ... I like your aproach to > integrating this functionality into rrdgraph vi

Re: [rrd-developers] [PATCH] RRDCacheD: Add the "FETCH" command.

2010-02-24 Thread Florian Forster
Hi Tobi, On Wed, Feb 24, 2010 at 11:04:39PM +0100, Tobias Oetiker wrote: >I like your aproach to integrating this functionality into rrdgraph via >the daemon argument ... (have not yet looked at the code) ... thanks :) I chose it for its simplicity and flexibility. Since there are already several

Re: [rrd-developers] [PATCH] src/rrd_graph.[ch]: Implemented the ":daemon=..." option for "DEF:" commands.

2010-02-24 Thread Florian Forster
Hi Thorsten, On Wed, Feb 24, 2010 at 01:02:57PM -0800, Thorsten von Eicken wrote: > Very cool! So now the main missing piece is the creation of RRD files, > correct? I think so. For a completely networked solution, I think you'd need create, write and read via networking sockets, i.e. "CREATE", "

[rrd-developers] [PATCH] src/rrd_graph.[ch]: Implemented the ":daemon=..." option for "DEF:" commands.

2010-02-24 Thread Florian Forster
From: Florian Forster Rather than calling "FLUSH" for each RRD file needed for drawing a graph and then accessing the file directly, use the "FLUSH" command to receive the data required for drawing a graph. The daemon can now be specified in one of three ways: * A new o

[rrd-developers] [PATCH] RRDCacheD: Add the "FETCH" command.

2010-02-24 Thread Florian Forster
From: Florian Forster Add a "FETCH" command to RRDCacheD which behaves like a (simplified version of) rrdfetch(1). This has advantages over calling "FLUSH" from within the "client", especially if the daemon is accessed using a network socket. For one, it makes it e

[rrd-developers] [PATCH] src/rrd_format.c: Implemented "cf_to_string".

2010-02-24 Thread Florian Forster
From: Florian Forster A simple helper function to turn an "enum cf_en" to a string. The returned pointer points to static memory and doesn't need to be freed. --- src/rrd_format.c | 20 src/rrd_tool.h |2 ++ 2 files changed, 22 insertions(+), 0 del

[rrd-developers] [PATCH] src/rrd_fetch.c: Use "rrdc_fetch" if daemon is available.

2010-02-24 Thread Florian Forster
From: Florian Forster Instead of flushing the file via the connection to the daemon and then accessing it directly, use the "FETCH" command to access the file via the RRDCacheD. This removes ambiguities with absolute and relative paths and makes it possible to read data from files th

[rrd-developers] [PATCH] Fix checking for "simple integers"

2010-01-14 Thread Florian Forster
Hi, in src/rrd_update.c there is this code (which is checking for "simple integers"): if ( ( updvals[ds_idx + 1][0] < '0' || updvals[ds_idx + 1][0] > '9' ) && updvals[ds_idx + 1][0] != '-' && updvals[ds_idx + 1][0] != 'U' && updvals[ds_idx + 1][0] == '\0' ) {

Re: [rrd-developers] [rrd] Re: rrdcached performance with >200k nodes

2010-01-13 Thread Florian Forster
Hi, On Wed, Jan 13, 2010 at 11:08:44AM +0100, Mirek Lauš wrote: > 31,901,245,144 ???:strcmp'2 [/lib/libc.so.7] there are only three places where “strcmp” is used: * When initializing the journaling code. Should be run at startup only. * When checking for permission. This is called at least as

Re: [rrd-developers] rrdcached + collectd issues

2009-10-10 Thread Florian Forster
Hi Thorsten, On Fri, Oct 09, 2009 at 04:41:55PM -0700, Thorsten von Eicken wrote: > > This sounds like collectd not sending updates to rrdcached. If they > > are not in the journal, then rrdcached has not received them. > > Yes, the question is whether it's collectd's fault or rrdcached's > faul

Re: [rrd-developers] rrdcached + collectd issues

2009-10-10 Thread Florian Forster
client.c (I just checked). With the attached patch against revision 1934 I was able to build the rrdcached plugin of collectd without problems. Regards, —octo -- Florian octo Forster Hacker in training GnuPG: 0x91523C3D http://verplant.org/ commit 0299e04d2ed41324a38f6d3d90e1614a0b0e3f0d Author: Flori

Re: [rrd-developers] [PATCH] rrd_client: Do not rewrite path names when accessing remote daemons.

2009-10-07 Thread Florian Forster
Hi, sorry if I'm bringing up a point that was already denied, but I have to admit that reading through that entire discussion is totally tiresome … On Sun, Oct 04, 2009 at 01:14:24PM +0200, Tobias Oetiker wrote: > I think the current implementation where only relative paths are > allowed for remo

Re: [rrd-developers] threaded support for rrdcached calls

2009-09-14 Thread Florian Forster
Hi A. J., On Thu, Sep 03, 2009 at 09:06:15AM -0400, AJ Ragusa wrote: > I was looking through the 1.4rc2 and I don't see a thread safe call to > rrd_update that supports rrdcached. Should I be calling rrdc_update > directly in my code and is that thread safe? yes, probably calling “rrdc_updat

Re: [rrd-developers] getting rid of some of the LOCALE magic

2009-09-04 Thread Florian Forster
Hi, On Fri, Sep 04, 2009 at 09:54:37AM +0200, Tobias Oetiker wrote: > this causes the locale settings to be reset to whatever the > coresponding environment variable sais ... this is nice when people > set the LC_* variable in the surrounding code ... but it cause > unexpected behaviour, if people

Re: [rrd-developers] [PATCH] Suggestion for API extension (rrd_dump)

2009-08-17 Thread Florian Forster
Hi, On Mon, Aug 17, 2009 at 12:21:02AM +0200, Tobias Oetiker wrote: > repeating the same string hmmm > > +cb(" \"http://oss.oetiker.ch/rrdtool/rrdtool.dtd\";>\n", > +strlen(" \"http://oss.oetiker.ch/rrdtool/rrdtool.dtd\";>\n"), user); > > also the combination > > snprin

[rrd-developers] [PATCH 2/2] rrdcached(1): Document the -P option and update the security considerations.

2009-08-11 Thread Florian Forster
From: Florian Forster Signed-off-by: Florian Forster --- doc/rrdcached.pod | 110 - 1 files changed, 83 insertions(+), 27 deletions(-) diff --git a/doc/rrdcached.pod b/doc/rrdcached.pod index 5113c2d..460899c 100644 --- a/doc/rrdcached.pod

[rrd-developers] [PATCH 1/2] src/rrd_daemon.c: Switch to per-socket, per-command permissions.

2009-08-11 Thread Florian Forster
From: Florian Forster This patch introduces per-socket, per-command permissions to the RRD caching daemon, RRDCacheD. This allows administrators to limit access to the daemon in a fine-grained manner. The patch removes the command line option `-L' and introduces `-P' instead. The o

[rrd-developers] Small fix for autoconf

2009-08-10 Thread Florian Forster
Hi, with my Debian Testing box I had to apply the following small changes to the `configure.ac' file in order to make `autoconf' happy. Don't know what the problem precisely is – m4 and its square parenthesis is too high for me ;) Also, autogen.sh specifies `-I config', but there is no config dir

Re: [rrd-developers] RRDCacheD - Client rewriting path

2009-08-10 Thread Florian Forster
Hi Tobi, On Tue, Aug 11, 2009 at 07:48:30AM +0200, Tobias Oetiker wrote: > > * Some magical version of the functions will check some sort of > > environment and call the appropriate function. > > this is to maintain the present interface ? well, I would much rather see the end of that argv

Re: [rrd-developers] RRDCacheD - Client rewriting path

2009-08-10 Thread Florian Forster
Hi, I have talked to Sebastian in person about this, but I think it'd be good if I repeat this here: On Sat, Aug 08, 2009 at 12:22:26PM +0200, Yann Jouanin wrote: > It seems the behavior of RRD client when using RRDCacheD can make > trouble when using RRDCacheD on another host than the one where

Re: [rrd-developers] [PATCH 5/5] src/rrd_graph.c: Use `rrdc_fetch' if daemon is available.

2009-05-25 Thread Florian Forster
Hi Tobi, > what is the idea behinde implementing remote access in graph explicity > instead of just telling fetch about it and having it handle this > transparently ? I think we've talked about this before and we all agreed that adding some special syntax to the CDEF options is the way to go. I i

Re: [rrd-developers] [PATCH 1/5] src/rrd_daemon.c: Switch to per-socket, per-command permissions.

2009-05-25 Thread Florian Forster
Hi Kevin, On Sat, May 23, 2009 at 04:30:17PM -0500, kevin brintnall wrote: > Any ideas on how the authorization scheme may change once we have > per-user authentication (i.e. with client certs)? my plan for authentication was something along these lines: -P flush,stats/flushall,update All com

Re: [rrd-developers] [PATCH 2/5] src/rrd_daemon.c: Add the "FETCH" command.

2009-05-25 Thread Florian Forster
Hi Kevin, On Sat, May 23, 2009 at 04:57:03PM -0500, kevin brintnall wrote: > On Sat, May 23, 2009 at 01:04:25PM +0200, Florian Forster wrote: > > +static int handle_request_fetch (listen_socket_t *sock, /* {{{ */ > > +char *buffer, size_t buffer_size) > > For all handler

[rrd-developers] [PATCH 3/5] src/rrd_client.[ch]: Add `rrdc_fetch'.

2009-05-23 Thread Florian Forster
From: Florian Forster The `rrdc_fetch' command has the same interface as `rrd_fetch_r' and behaves just like it, except that it will read the value from the RRD caching daemon, using the `FETCH' command. Signed-off-by: Florian Forster --- src/rrd_

[rrd-developers] [PATCH 4/5] src/rrd_fetch.c: Use `rrdc_fetch' if daemon is available.

2009-05-23 Thread Florian Forster
From: Florian Forster Signed-off-by: Florian Forster --- src/rrd_fetch.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/rrd_fetch.c b/src/rrd_fetch.c index 23be6e0..4d4e7e3 100644 --- a/src/rrd_fetch.c +++ b/src/rrd_fetch.c @@ -167,14 +167,17 @@ int

[rrd-developers] [PATCH 2/5] src/rrd_daemon.c: Add the "FETCH" command.

2009-05-23 Thread Florian Forster
From: Florian Forster The `FETCH' command can be used to execute a `rrd_fetch_r' on the server and will return the data via the network connection. Signed-off-by: Florian Forster --- src/rrd_daemon.c | 183 +- 1 files ch

[rrd-developers] [PATCH 1/5] src/rrd_daemon.c: Switch to per-socket, per-command permissions.

2009-05-23 Thread Florian Forster
From: Florian Forster This patch introduces per-socket, per-command permissions to the RRD caching daemon, RRDCacheD. This allows administrators to limit access to the daemon in a fine-grained manner. The patch removes the command line option `-L' and introduces `-P' instead. The o

[rrd-developers] [PATCH 5/5] src/rrd_graph.c: Use `rrdc_fetch' if daemon is available.

2009-05-23 Thread Florian Forster
From: Florian Forster Signed-off-by: Florian Forster --- src/rrd_graph.c | 65 +++--- 1 files changed, 28 insertions(+), 37 deletions(-) diff --git a/src/rrd_graph.c b/src/rrd_graph.c index a0de36e..601a509 100644 --- a/src/rrd_graph.c +++ b

Re: [rrd-developers] [PATCH] rrdcached server-side authentication

2009-05-06 Thread Florian Forster
Hi, On Tue, May 05, 2009 at 08:58:37AM -0500, kevin brintnall wrote: > Until we have per-command authorization, I'm thinking we should add a > 3rd type of socket that requires authentication for everything. This > type would be appropriate for any untrusted connections. This would > let us maint

Re: [rrd-developers] [PATCH] rrdcached server-side authentication

2009-05-03 Thread Florian Forster
Hi Kevin, Tobi, Sebstian and list, thanks Kevin for this initial implementation :) I didn't read the source code yet, so please forgive me if I misunderstand some details. On Wed, Apr 29, 2009 at 03:14:18AM +, kevin brintnall wrote: > A user connecting on a low-privilege socket may upgrade to

Re: [rrd-developers] [RRDCacheD] Developing RRDCacheD as separate project (was: Authentication)

2009-04-11 Thread Florian Forster
Hi Tobi, On Fri, Apr 10, 2009 at 10:20:48PM +0200, Tobias Oetiker wrote: > (sorry for not answering sooner, I am currently hiking in the > mountains and my net access is somewhat restricted). there is no rush, enjoy your trip :) Paper is patient, e-mail is persistent ;) > I have the impression t

Re: [rrd-developers] [RRDCacheD] Developing RRDCacheD as separate project (was: Authentication)

2009-04-11 Thread Florian Forster
Hi Kevin, thanks for your reply, it was very important for me to hear your point, too. On Fri, Apr 10, 2009 at 08:14:19AM -0500, kevin brintnall wrote: > (1) The daemon may require access to internal structures/functions at some > time. Please, PLEASE, don't ever do that! Having a well defin

Re: [rrd-developers] [RRDCacheD] Developing RRDCacheD as separate project (was: Authentication)

2009-04-10 Thread Florian Forster
Hi Tobi, Thorsten, Kevin, and list, sorry I took my time to answer – I wanted to sleep on this first and don't make any premature decisions. On Thu, Apr 09, 2009 at 04:31:02PM +0200, Tobias Oetiker wrote: > I love the rrdcached functionality and all the work you did on it and > I would not want t

Re: [rrd-developers] [RRDCacheD] Authentication (was: Why / How / When is version 1.2 developed?)

2009-04-08 Thread Florian Forster
Hi Tobi, On Wed, Apr 08, 2009 at 06:27:33PM +0200, Tobias Oetiker wrote: > well in the sense that no 'secret' information can get out ... but you > may remember that I raised this question right when the whole daemon > thing started ... yes, I do remember. And my position on that today is the sam

Re: [rrd-developers] Add `FETCH' command to rrdcached

2009-04-08 Thread Florian Forster
Hi Tobi, On Wed, Apr 08, 2009 at 06:08:18PM +0200, Tobias Oetiker wrote: > > > a) looking at the patch I see that the flushing operation is > > >included in rrd_graph (this is not new). > > > > It is? I can't find it: > > -- 8< -- > > o...@leeloo:~/rrdtool-trunk.git $ git branch | fgrep '*' >

Re: [rrd-developers] [RRDCacheD] Authentication (was: Why / How / When is version 1.2 developed?)

2009-04-08 Thread Florian Forster
Hi Tobi, On Wed, Apr 08, 2009 at 07:38:06AM +0200, Tobias Oetiker wrote: > I have been telling people about the daemon feature at recent talks > and the auth question came up often ... the reason fetch is tipping > the scale for me is that with this functionality rrdcached goes > from a 'submit on

Re: [rrd-developers] Add `FETCH' command to rrdcached

2009-04-08 Thread Florian Forster
Hi Tobi, On Mon, Apr 06, 2009 at 05:11:25PM +0200, Tobias Oetiker wrote: > I would want to schedule this for 1.5 though and not rush it into 1.4 I'd prefer to see this in 1.4, since I hope that the possibility to create graphs without physical access to the RRD files will be welcome by many. The

[rrd-developers] Why / How / When is version 1.2 developed?

2009-04-07 Thread Florian Forster
Hi Tobi, On Mon, Apr 06, 2009 at 05:11:25PM +0200, Tobias Oetiker wrote: > I would want to schedule this for 1.5 though and not rush it into 1.4 I got asked today why 1.2 and 1.3 were developed in parallel. I was about to answer that only bugfixes went into 1.2 and 1.3 and new stuff goes into 1.4

Re: [rrd-developers] [PATCH] add 'flush' to language bindings

2009-03-27 Thread Florian Forster
Hi, On Fri, Mar 27, 2009 at 03:29:07PM +0100, Tobias Oetiker wrote: > > Most of them are already rrdc_*. I don't see a reason to s/^rrdc/rrdcd/. > > sure, rrdc_* is fine too I used the `rrdc_' prefix for all exported functions which connect to the server. The `c' was meant as apprevation for `c

Re: [rrd-developers] [PATCH 4/4] src/rrd_graph.c: Use `rrdc_fetch' if daemon is available.

2009-03-24 Thread Florian Forster
Hi again, On Tue, Mar 24, 2009 at 04:40:16PM +0100, Florian Forster wrote: > + status = rrd_fetch_fn (im->gdes[i].rrd, ... > + else > + status = rrd_fetch_fn (im->gdes[i].rrd, sorry, but this is of course a copy'n'paste error

[rrd-developers] [PATCH 1/4] src/rrd_daemon.c: Add the "FETCH" command.

2009-03-24 Thread Florian Forster
From: Florian Forster The `FETCH' command can be used to execute a `rrd_fetch_r' on the server and will return the data via the network connection. Signed-off-by: Florian Forster --- src/rrd_daemon.c | 180 +- 1 files ch

[rrd-developers] [PATCH 2/4] src/rrd_client.[ch]: Add `rrdc_fetch'.

2009-03-24 Thread Florian Forster
From: Florian Forster The `rrdc_fetch' command has the same interface as `rrd_fetch_r' and behaves just like it, except that it will read the value from the RRD caching daemon, using the `FETCH' command. Signed-off-by: Florian Forster --- src/rrd_

[rrd-developers] [PATCH 3/4] src/rrd_fetch.c: Use `rrdc_fetch' if daemon is available.

2009-03-24 Thread Florian Forster
From: Florian Forster Signed-off-by: Florian Forster --- src/rrd_fetch.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/rrd_fetch.c b/src/rrd_fetch.c index 23be6e0..4d4e7e3 100644 --- a/src/rrd_fetch.c +++ b/src/rrd_fetch.c @@ -167,14 +167,17 @@ int

[rrd-developers] [PATCH 4/4] src/rrd_graph.c: Use `rrdc_fetch' if daemon is available.

2009-03-24 Thread Florian Forster
From: Florian Forster Signed-off-by: Florian Forster --- src/rrd_graph.c | 65 +++--- 1 files changed, 28 insertions(+), 37 deletions(-) diff --git a/src/rrd_graph.c b/src/rrd_graph.c index 19e3c40..cca9a09 100644 --- a/src/rrd_graph.c +++ b

[rrd-developers] FETCH for the RRD caching daemon: The actual patches

2009-03-24 Thread Florian Forster
Apologies for my previous mail, I messed up with `git-format-patch'.. I hope this time the patches come through.. Enjoy, -octo ___ rrd-developers mailing list rrd-developers@lists.oetiker.ch https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[rrd-developers] [PATCH 3/4] src/rrd_fetch.c: Use `rrdc_fetch' if daemon is available.

2009-03-24 Thread Florian Forster
From: Florian Forster Signed-off-by: Florian Forster -- 1.6.2 ___ rrd-developers mailing list rrd-developers@lists.oetiker.ch https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

[rrd-developers] [PATCH 2/4] src/rrd_client.[ch]: Add `rrdc_fetch'.

2009-03-24 Thread Florian Forster
From: Florian Forster The `rrdc_fetch' command has the same interface as `rrd_fetch_r' and behaves just like it, except that it will read the value from the RRD caching daemon, using the `FETCH' command. Signed-off-by: Florian Forster src/rrd_client.c:891: trailing whit

[rrd-developers] [PATCH 1/4] src/rrd_daemon.c: Add the "FETCH" command.

2009-03-24 Thread Florian Forster
From: Florian Forster The `FETCH' command can be used to execute a `rrd_fetch_r' on the server and will return the data via the network connection. Signed-off-by: Florian Forster -- 1.6.2 ___ rrd-developers mailing list rrd-

[rrd-developers] Add `FETCH' command to rrdcached

2009-03-24 Thread Florian Forster
Hi, the following few patches add the `FETCH' command to rrdcached, adds a client interface and changes `rrdtool fetch' and `rrdtool graph' to receive values from the daemon directly if they are connected to one. This allows to create graphs on machines that don't have direct access to the RRD fi

[rrd-developers] [PATCH 4/4] src/rrd_graph.c: Use `rrdc_fetch' if daemon is available.

2009-03-24 Thread Florian Forster
From: Florian Forster Signed-off-by: Florian Forster -- 1.6.2 ___ rrd-developers mailing list rrd-developers@lists.oetiker.ch https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

Re: [rrd-developers] two problem about RRD UPDATE

2009-03-21 Thread Florian Forster
Hi Lily, On Sun, Mar 15, 2009 at 10:39:37AM +0800, lily wrote: > How can I keep the data in memory? Use the mmap ? Is upgrade the > version to 1.3.6 wil be OK or I have to something in my code ? basically, all you have to do is have more memory - the operating system should do the rest.. > My r

Re: [rrd-developers] two problem about RRD UPDATE

2009-03-14 Thread Florian Forster
Hi, On Sat, Mar 14, 2009 at 12:01:42PM +0800, lily wrote: > Recently I use the rrdtool to create about 12 thousand rrd-file, and > update them in 30s . the important metric here is updates per second. Updating 12k RRD files every 30 seconds qeuals 400 updates per second. In my experience, you

[rrd-developers] Improvements to rrd_strerror.

2009-02-12 Thread Florian Forster
Hi Tobi, please consider the attached patch which changes the error handling in `rrd_strerror' a little. A user of collectd got the following error message: mmaping file '...': strerror_r failed. sorry! It would have helped to debug his problem to know which error actually occurred. With the a

Re: [rrd-developers] RFC new DS type DGAUGE

2008-11-16 Thread Florian Forster
Hi Tobi, On Sat, Nov 15, 2008 at 03:56:15PM +0100, Tobias Oetiker wrote: > A new datasource type called DGAUGE. It would always *round down* the > timestamp to the last step. a lot of people tell me: ``I don't want to see emails _per second_ but the actual number of emails!''. When I then chang

Re: [rrd-developers] implementing portable format

2008-11-03 Thread Florian Forster
Hi Dan, On Mon, Nov 03, 2008 at 11:42:27AM -0500, Dan Cech wrote: > This doesn't make sense to me. You're talking about sending a huge > amount of data to the client vs generating the graph on the server > (where you have the data already available) and just sending the > graph. I makes perfect

Re: [rrd-developers] implementing portable format

2008-11-03 Thread Florian Forster
Hi Igor, On Mon, Nov 03, 2008 at 10:35:54AM -0600, Sfiligoi Igor wrote: > Maybe I was not clear what was the use case: I have a server with > O(1) RRDs that are updated ~ once a minute. I have O(2^n) RRD files (for an arbitrary constant `n'). *scnr* > Moreover, I don't want to allow active C

[rrd-developers] src/rrd_open.c: Check arguments in `rrd_dontneed'.

2008-10-07 Thread Florian Forster
From: Florian Forster <[EMAIL PROTECTED]> Daniel Pocock reported that the argument may be NULL in low-diskspace situations, so check for that here to prevent a segmentation fault. --- src/rrd_open.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/rrd_op

Re: [rrd-developers] rrdcached shutdown

2008-09-26 Thread Florian Forster
Hi Tobi, On Fri, Sep 26, 2008 at 02:29:30PM +0200, Tobias Oetiker wrote: > Thirdly speaking as a unix admin, who manages systems where users run > their own daemons: I do not know the right signal for each daemon to > quit. this scenario doesn't apply to the use case I have in mind, where one mac

Re: [rrd-developers] rrdcached daemonize failed, exiting

2008-09-26 Thread Florian Forster
Hi, sorry for tuning in so late, I didn't get to read your mails until just now.. On Wed, Sep 24, 2008 at 02:41:43PM -0500, kevin brintnall wrote: > I see two main install types for rrdcached.. This is what I would target: > > (I1) as a local service > - purpose is largely to ease disk bur

Re: [rrd-developers] rrdcached shutdown

2008-09-26 Thread Florian Forster
Hi Bernard, On Thu, Sep 25, 2008 at 02:55:08PM -0700, Bernard Li wrote: > Not sure if you followed one of our conversations but basically with > Ganglia, it looks like we need to do some hackery with the Unix domain > socket ownership to support multiple user owned processes to > communicate with

Re: [rrd-developers] rrdcached shutdown

2008-09-26 Thread Florian Forster
Hi Tobi, On Thu, Sep 25, 2008 at 11:43:48PM +0200, Tobias Oetiker wrote: > the point of using TERM is that as a system goes down, normally > processes that are still hanging around are sent TERM and shortly > after KILL, so it is a good thing for a process to quickly get ready > to die when he get

Re: [rrd-developers] rrdcached shutdown

2008-09-25 Thread Florian Forster
Hi Kevin, On Thu, Sep 25, 2008 at 12:11:41PM -0500, kevin brintnall wrote: > We could catch SIGTERM for expedited shutdown and SIGINT for full-flush > shutdown? Then, each operator can decide which makes the most sense. I see your point, I'm in the same situation myself. However, I feel somehow

Re: [rrd-developers] [PATCH] Use the same IPv6/IPv4 as for the client as Florian did for the server

2008-09-25 Thread Florian Forster
Hi Kevin, On Thu, Sep 25, 2008 at 08:44:38PM +, kevin brintnall wrote: > src/rrd_client.c | 47 ++- oh, I must have missed that, thanks for fixing it :) > -static int rrdc_connect_network (const char *addr) /* {{{ */ > +static int rrdc_connect_ne

Re: [rrd-developers] src/rrd_daemon.c: Fix the port configuration for IPv6.

2008-09-25 Thread Florian Forster
Oops.. On Thu, Sep 25, 2008 at 07:18:16PM +0200, Florian Forster wrote: > + if (strchr (addr, '.') != NULL) /* Hostname or IPv4 */ > + else if (*addr == '[') /* IPv6+port format */ I just realized that doing it this way around will not work with IPv4-addresses f

[rrd-developers] src/rrd_daemon.c: Fix the port configuration for IPv6.

2008-09-25 Thread Florian Forster
From: Florian Forster <[EMAIL PROTECTED]> Support for IPv6 has been broken with revision 1522: Because IPv6-addresses contain colons, simply checking for a colon and using everything after it does destroy correctly formatted IPv6-addresses. This patch checks for dots '.' in the

[rrd-developers] rrdcached(1): Document how error reporting currently works.

2008-09-23 Thread Florian Forster
From: Florian Forster <[EMAIL PROTECTED]> --- doc/rrdcached.pod |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/doc/rrdcached.pod b/doc/rrdcached.pod index 7631351..e718791 100644 --- a/doc/rrdcached.pod +++ b/doc/rrdcached.pod @@ -128,6 +128,15 @@ th

Re: [rrd-developers] rrdcached daemonize failed, exiting

2008-09-23 Thread Florian Forster
Hi, On Tue, Sep 23, 2008 at 06:55:36AM +0200, Tobias Oetiker wrote: > I guess in the long run it would save us quite some ML traffic if the > rrdcached was more forthcoming about the reasons for its failure to > launch ... the daemon uses a variadic macro, `RRDD_LOG', to log messages. One way to

Re: [rrd-developers] updated rrdcached (a few fixes and enhancements)

2008-09-15 Thread Florian Forster
Hi Bernard, On Mon, Sep 15, 2008 at 03:27:22PM -0700, Bernard Li wrote: > On Sun, Sep 14, 2008 at 3:41 AM, Florian Forster > > looks good, now the only difference between my version and the > > version in SVN is the changes you made to the PODs.. It compiles (as > > ex

[rrd-developers] src/rrd_daemon.c: Updated the usage information.

2008-09-14 Thread Florian Forster
From: Florian Forster <[EMAIL PROTECTED]> --- src/rrd_daemon.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c index 0816526..2bd19a1 100644 --- a/src/rrd_daemon.c +++ b/src/rrd_daemon.c @@ -2033,17 +2033,19 @@ stat

[rrd-developers] src/rrd_client.c: Simplyfied parsing of responses.

2008-09-14 Thread Florian Forster
From: Florian Forster <[EMAIL PROTECTED]> The previous code was broken: The response was read using `read(2)'. If the server wasn't sending fast enough, the client would stop reading before the entire message had been read. This patch changes the communication code to use the (li

Re: [rrd-developers] updated rrdcached (a few fixes and enhancements)

2008-09-14 Thread Florian Forster
Hi Tobi, On Sun, Sep 14, 2008 at 12:36:13PM +0200, Tobias Oetiker wrote: > I have applied the second helping, please test. looks good, now the only difference between my version and the version in SVN is the changes you made to the PODs.. It compiles (as expected ;), so I'd say everything is alri

Re: [rrd-developers] updated rrdcached (a few fixes and enhancements)

2008-09-14 Thread Florian Forster
en updated to include your changes and my changes as outlined above. You can see the individual commits at [1]. Tobi, I've looked through Kevin's changes and if RRDTool was using Git they'd certainly get their Signed-off-by: Florian Forster <[EMAIL PROTECTED]> (meaning I'v

Re: [rrd-developers] rrdtool 1.4 development ready to go

2008-09-08 Thread Florian Forster
ign the API. I didn't even try to compile anything, so there may be syntax errors and stuff all around. It's just to get the basic idea(s) across. Any ideas / comments? Regards, -octo -- Florian octo Forster Hacker in training GnuPG: 0x91523C3D http://verplant.org/ /** * RRDTool - API

Re: [rrd-developers] rrdtool 1.4 development ready to go

2008-09-08 Thread Florian Forster
Hi Tobi, now that `trunk' is open for new stuff, please take a look at my updated patch at [0]. I've just merged in revision 1488, so it should apply cleanly to the current trunk. If you (or anyone else) wants to see the actual commits, you can check out the Git repository I'm using from [1]. My

Re: [rrd-developers] rrd cache work

2008-09-04 Thread Florian Forster
Hi Kevin, sorry for the late reply - the List-ID and addredd of the rrd-developers list has changed. Together with the string `rrd-developers' not appearing in the subject, the mail was filed in my (spam flooded) INBOX.. On Tue, Sep 02, 2008 at 11:15:14AM -0500, kevin brintnall wrote: [Make rrdc_

Re: [rrd-developers] rrd cache work

2008-09-02 Thread Florian Forster
Hi again, On Mon, Sep 01, 2008 at 04:09:42AM -0500, kevin brintnall wrote: > I am working on a few changes... just for the record: I've just merged in the changes to trunk, so the patch should apply cleanly against SVN revision 1476 now. Regards, -octo -- Florian octo Forster Hacker in training

Re: [rrd-developers] rrd cache work

2008-09-02 Thread Florian Forster
Hi Kevin, On Mon, Sep 01, 2008 at 04:09:42AM -0500, kevin brintnall wrote: > I am working on a few changes... Once I have completed testing I will > submit the patch back to you and tobi. great :) > rrdc_flush_if_daemon(opt_daemon, filename); Sounds good :) I'd rather not define that functio

Re: [rrd-developers] rrd cache work

2008-08-29 Thread Florian Forster
Hi Kevin, On Fri, Aug 29, 2008 at 02:48:48PM -0500, kevin brintnall wrote: > I was interested in checking your source, but it doesn't look like the > latest versions are available via your "rrdd.git" repository. Also, I > didn't see them integrated into the rrdtool SVN tree. no, I've continued d

Re: [rrd-developers] rrdtool versioning in trunk / Accelerator daemon

2008-07-23 Thread Florian Forster
Hi Bernard, On Wed, Jul 23, 2008 at 10:34:59AM -0700, Bernard Li wrote: > Thanks for updating the version numbers in the snapshots, I'll give > those a try. due to the versioning changes two hunks of the patch didn't apply cleanly anymore. I've just updated the patch so it applies against the cur

Re: [rrd-developers] Accelerator Daemon

2008-07-18 Thread Florian Forster
Hi Tobi, On Wed, Jul 16, 2008 at 05:23:52PM +0200, Tobias Oetiker wrote: > so if the daemon enablement environment variable is set then the > updatev command will fail ? this is fine too. no it doesn't yet, but that makes sense.. I'll see to it. > Reading between the lines, I sense that you are

Re: [rrd-developers] Accelerator Daemon

2008-07-17 Thread Florian Forster
Hi Bernhard, On Tue, Jul 15, 2008 at 02:55:39PM -0700, Bernard Li wrote: > However, I need to get past the hurdle of setting this up. setting this up is fairly easy: > I assume I need to pull the rrdtool code from trunk and apply your > patch? Right, this is in any case the very first step ;) T

Re: [rrd-developers] Accelerator Daemon

2008-07-15 Thread Florian Forster
Hi again, as before, the newest patch is available from On Fri, Jul 04, 2008 at 03:07:37PM +0200, Tobias Oetiker wrote: > I would like to see that all the functions which read from an rrd file > will flush the daemon prior to re

Re: [rrd-developers] Accelerator Daemon

2008-07-04 Thread Florian Forster
ol-trunk-rrd_update_with_cache.patch> On Tue, Jun 24, 2008 at 10:13:29PM +0200, Florian Forster wrote: > The current status is: > - `rrdcached' understands the `update' and `flush' commands. The daemon > is nowhere near production ready, though: There is no PID file, the > base directory `

Re: [rrd-developers] Accelerator Daemon

2008-07-02 Thread Florian Forster
Hi Tobi, On Wed, Jul 02, 2008 at 05:54:12AM +0200, Tobias Oetiker wrote: > ... use updatev (I wonder how the accelerator daemon deals with that > one) it doesn't. Quoting the rrdupdate(1) manpage (as modified by the patch): ``Since updatev requires direct disk access, the --daemon option cannot

Re: [rrd-developers] Accelerator Daemon

2008-07-02 Thread Florian Forster
Hi Scott, On Tue, Jul 01, 2008 at 04:32:50PM -0700, Scott Brumbaugh wrote: > Rrdtool allows for automated network monitoring through the rrd_xport > function. You can readout the current rate estimates and use them to > update filters to do automated monitoring. For this type of > application it

Re: [rrd-developers] Accelerator Daemon

2008-07-01 Thread Florian Forster
On Tue, Jul 01, 2008 at 08:28:54AM +0100, Hamish Marson wrote: > To be honest, anyone generating graphs that often probably needs to go > back through & examine their code... And their usage. Updating a graph > for a whole day every time you update the RRD is pretty bad... > My newer stuff tends

Re: [rrd-developers] Accelerator Daemon

2008-06-30 Thread Florian Forster
Hi Bernard, On Mon, Jun 30, 2008 at 02:00:57PM -0700, Bernard Li wrote: > > Yes, that's probably right. I didn't expect anyone with such a huge > > number of RRD files to generate graphs periodically/statically > > instead of on demand/dynamically.. Is anyone with a big number of > > files doing t

  1   2   >