[rrd-developers] src/rrd_open.c: Check arguments in `rrd_dontneed'.

2008-10-07 Thread Florian Forster
From: Florian Forster [EMAIL PROTECTED] Daniel Pocock reported that the argument may be NULL in low-diskspace situations, so check for that here to prevent a segmentation fault. --- src/rrd_open.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/rrd_open.c

[rrd-developers] crash - full hard disk

2008-10-07 Thread Daniel.Pocock
As part of the scalability tests I've been doing, I regularly fill up my hard disk with RRDs. I've noticed that rrdtool (trunk, linked with Ganglia 3.1) creates one or more files with size 0 or with other unusual sizes when the disk fills up, and shortly after, there is a seg fault (gdb

Re: [rrd-developers] src/rrd_open.c: Check arguments in `rrd_dontneed'.

2008-10-07 Thread Tobias Oetiker
Today Florian Forster wrote: From: Florian Forster [EMAIL PROTECTED] Daniel Pocock reported that the argument may be NULL in low-diskspace situations, so check for that here to prevent a segmentation fault. --- Thanks, applied tobi -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600

Re: [rrd-developers] [PATCH] improved journal sanity checks, cleanup

2008-10-07 Thread Tobias Oetiker
Hi Kevin, great ... applied tobi -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland http://it.oetiker.ch [EMAIL PROTECTED] ++41 62 775 9902 / sb: -9900 ___ rrd-developers mailing list rrd-developers@lists.oetiker.ch

Re: [rrd-developers] crash - full hard disk

2008-10-07 Thread Bernard Li
Hi Daniel: On Tue, Oct 7, 2008 at 5:18 AM, [EMAIL PROTECTED] wrote: I wanted to create a ticket for this on the Trac system, but I couldn't find the link for creating an account, and the account published on the welcome page doesn't have permissions. http://oss.oetiker.ch/rrdtool-trac/ The

[rrd-developers] [PATCH] rrdcached: better permissions handling

2008-10-07 Thread kevin brintnall
This patch moves the permission handling code around a bit. * moved privilege checks into the command handler functions (possible now that we pass the sock data structures around) * on UPDATE, delay journal_write until after check_file_access(). previously, it was possible for a

[rrd-developers] [PATCH] rrdcached: PENDING and FORGET for cache management

2008-10-07 Thread kevin brintnall
This patch introduces two new commands for cache management: PENDING: shows any un-written updates for a file FORGET : remove a file completely from cache This applies cleanly on top of my previous patch (better permissions handling). --- diff --git a/doc/rrdcached.pod b/doc/rrdcached.pod

Re: [rrd-developers] [PATCH] rrdcached: PENDING and FORGET for cache management

2008-10-07 Thread Tobias Oetiker
Today kevin brintnall wrote: This patch introduces two new commands for cache management: PENDING: shows any un-written updates for a file FORGET : remove a file completely from cache This applies cleanly on top of my previous patch (better permissions handling). thanks tobi -- Tobi

Re: [rrd-developers] [patch] rrdcached init script and spec file

2008-10-07 Thread Bernard Li
Hi all: I have some comments regarding the rrdtool spec file that is in trunk now (which includes changes to incorporate rrdcached). First of all, thanks to Daniel for putting this together (saves me the work, heh). However, I have two comments: 1) I think we should break this out as a

[rrd-developers] [PATCH] Update spec file to include librrd.pc file

2008-10-07 Thread Bernard Li
Hi Tobi: This patch updates the spec file and includes the librrd.pc file in the -devel subpackage so that you can build the RPM again. Thanks, Bernard Index: rrdtool.spec === --- rrdtool.spec (revision 1588) +++ rrdtool.spec

Re: [rrd-developers] [patch] rrdcached init script and spec file

2008-10-07 Thread Bernard Li
Hi Daniel: The init script does not work on my system (CentOS 4.x) as is, because the `daemon` function which I have does not support --pidfile -- is that argument necessary? Also, as discussed previously, I think it would be a good idea to create a 'rrdcached' user and group and start the

[rrd-developers] rrdcached crashed with no logging

2008-10-07 Thread Bernard Li
Hi all: I'm currently working with rrdcached from rrdtool r1588 and am having problems getting it to integrate with Ganglia. This has worked in the past (about 2 weeks ago). Right now I'm trying to figure out what's wrong. It seems that the daemon crashed without logging to syslog. I straced

Re: [rrd-developers] rrdcached crashed with no logging

2008-10-07 Thread kevin brintnall
On Tue, Oct 07, 2008 at 06:01:02PM -0700, Bernard Li wrote: It seems that the daemon crashed without logging to syslog. I straced the rrdcached process and here's what I got: Bernard, Do you have a backtrace? Also, what OS are you using? The interrupted poll() system call is in

Re: [rrd-developers] rrdcached crashed with no logging

2008-10-07 Thread Bernard Li
Hi Kevin: On Tue, Oct 7, 2008 at 7:46 PM, kevin brintnall [EMAIL PROTECTED] wrote: Do you have a backtrace? Also, what OS are you using? Here's the backtrace: (gdb) bt #0 0x002e47a2 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2 #1 0x004a2815 in raise () from /lib/tls/libc.so.6 #2

[rrd-developers] [PATCH] connection_thread_main: avoid double calls to close_connection

2008-10-07 Thread kevin brintnall
--- src/rrd_daemon.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c index 9c8847d..36d418b 100644 --- a/src/rrd_daemon.c +++ b/src/rrd_daemon.c @@ -1844,23 +1844,18 @@ static void *connection_thread_main (void *args) /* {{{ */

Re: [rrd-developers] rrdcached crashed with no logging

2008-10-07 Thread Bernard Li
Hi all: The patch Kevin provided solved my issue: http://www.mail-archive.com/rrd-developers@lists.oetiker.ch/msg02651.html Thanks, Bernard On Tue, Oct 7, 2008 at 8:35 PM, Bernard Li [EMAIL PROTECTED] wrote: Hi Kevin: On Tue, Oct 7, 2008 at 7:46 PM, kevin brintnall [EMAIL PROTECTED] wrote:

Re: [rrd-developers] [patch] rrdcached init script and spec file

2008-10-07 Thread Tobias Oetiker
Hi Bernard, Yesterday Bernard Li wrote: Hi Daniel: The init script does not work on my system (CentOS 4.x) as is, because the `daemon` function which I have does not support --pidfile -- is that argument necessary? Also, as discussed previously, I think it would be a good idea to create