Re: CVE-2022-29154 and v3.2.3

2022-08-17 Thread Wayne Davison via rsync
On Wed, Aug 17, 2022 at 9:30 AM Mark Esler wrote: > I am curious if CVE-2022-29154 affects rsync 3.2.3 or rrsync 3.2.3 and > earlier. The security page covers this: it's all versions prior to 3.2.5. if old_style_args is set to true then the

CVE-2022-29154 and v3.2.3

2022-08-17 Thread Mark Esler via rsync
Greetings all, I am curious if CVE-2022-29154 affects rsync 3.2.3 or rrsync 3.2.3 and earlier. More specifically, I am curious if the commit to use protected arguments as default [0] introduced the CVE (if so, v3.2.4pre1 is not affected). The protect args as default commit affects some of the

[PATCH] Add missing prototypes to function declarations

2022-08-17 Thread Khem Raj via rsync
With Clang 15+ compiler -Wstrict-prototypes is triggering warnings which are turned into errors with -Werror, this fixes the problem by adding missing prototypes Fixes errors like | log.c:134:24: error: a function declaration without a prototype is deprecated in all versions of C