Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread cbarratt
jw schultz writes: I wish we had a better handle on the cygwin hang and craigb-perf but i don't want to slow things down. CVS is solid on *x now. As noted in the follow-up emails, it would be great if craigb-perf goes into CVS just after the next release. That will give it plenty of testing

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread Jim Salter
I wish we had a better handle on the cygwin hang and craigb-perf but i don't want to slow things down. CVS is solid on *x now. I'd really like to get craigb-perf in an easier-to-implement condition. I just reverted from 2.5.7 *back* to 2.5.6 because I tried the craigb-perf patches and they

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread Wayne Davison
On Tue, Dec 16, 2003 at 12:49:48PM -0500, Jim Salter wrote: I just reverted from 2.5.7 *back* to 2.5.6 because I tried the craigb-perf patches and they made an INCREDIBLE difference in performance, and I couldn't get the patches to work right on 2.5.7. I note that the patch appears to apply to

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread Jim Salter
WayneD the [craigb-perf] patch appears to apply to 2.5.7 without problem, so I'm WayneD curious what problem you found (I didn't try to compile or run it). It applies fine, but it won't compile (on my FreeBSD 4.x and 5.x systems). There's a warning that's got something to do with Realloc defined

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread Jim Salter
io.o: In function `read_unbuffered': /home/jimbo/rsync/rsync-2.5.7/io.c:324: undefined reference to `Realloc' *** Error code 1 Stop in /usr/home/jimbo/rsync/rsync-2.5.7. Note: rsync-2.5.7 *without* the craigb-perf patch compiles, installs, and operates without errors on the same

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread Jim Salter
You should be able to change this line in the [craigb-perf] patch: + buffer = Realloc(buffer, remaining); To this line: + buffer = realloc_array(buffer, char, remaining); and that should fix it. Worked fine. Thanks Wayne - recompiling 2.5.7 and reinstalling it on all my systems now.

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread Wayne Davison
On Tue, Dec 16, 2003 at 10:53:56AM -0800, Wayne Davison wrote: I'm working on updating the patch for the 2.6.0 release FYI, I just checked in an update to the patches/craigb-perf.diff file in CVS that makes it apply to the upcoming 2.6.0 version. Some very basic testing showed that it worked

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread Wayne Davison
On Mon, Dec 15, 2003 at 06:42:29PM -0800, jw schultz wrote: Below is a revised file with a TOC at the top. Cool, looks like you did a very thorough edit pass (as compared to my quick once-over). The TOC makes it much friendlier too. Once you get that checked in, I think we may be ready for a

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread jw schultz
On Tue, Dec 16, 2003 at 11:42:58AM -0800, Wayne Davison wrote: On Mon, Dec 15, 2003 at 06:42:29PM -0800, jw schultz wrote: Below is a revised file with a TOC at the top. Cool, looks like you did a very thorough edit pass (as compared to my quick once-over). The TOC makes it much friendlier

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-16 Thread jw schultz
On Tue, Dec 16, 2003 at 12:02:26PM -0800, jw schultz wrote: On Tue, Dec 16, 2003 at 11:42:58AM -0800, Wayne Davison wrote: On Mon, Dec 15, 2003 at 06:42:29PM -0800, jw schultz wrote: Below is a revised file with a TOC at the top. Cool, looks like you did a very thorough edit pass (as

Prepping for a new release (2.5.8? 2.6.0?)

2003-12-15 Thread Wayne Davison
On Sun, Dec 14, 2003 at 11:32:07PM -0600, John Van Essen wrote: would you care to take the bull by the horns and produce a release candidate for 2.5.8 so that the rsync enthusiasts on the rsync mailing list can give it a whirl prior to an official release (hopefully by Christmas)? I was just

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-15 Thread Paul Slootman
On Mon 15 Dec 2003, Wayne Davison wrote: Yes, I'd like to get the CVS version finished up and a new release made. Good to hear! - What should we call the new version? I'm leaning towards 2.6.0 because of the new features (such as --files-from) and the various large changes (such as

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-15 Thread Wayne Davison
On Mon, Dec 15, 2003 at 10:03:28AM -0800, jw schultz wrote: The new wildmatch stuff should probably get a mild caution in the release notes. Yes, it has the potential to trip up advanced users. I'm thinking about a short blurb that explains how to create exlude patterns that behave the same on

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-15 Thread jw schultz
On Mon, Dec 15, 2003 at 10:51:08AM -0800, Wayne Davison wrote: On Mon, Dec 15, 2003 at 10:03:28AM -0800, jw schultz wrote: I wish we had a better handle on the cygwin hang and craigb-perf but i don't want to slow things down. It sounds like Cygwin might be fixing the cause of the hang on

Re: Prepping for a new release (2.5.8? 2.6.0?)

2003-12-15 Thread jw schultz
On Mon, Dec 15, 2003 at 11:51:25AM -0800, jw schultz wrote: On Mon, Dec 15, 2003 at 10:51:08AM -0800, Wayne Davison wrote: I made one pass through the TODO and INSTALL files looking for outdated info. I'd appreciate some other eyes giving these a quick scan. I just did a pass on the TODO