Re: [PATCHv2] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-21 Thread Wayne Davison via rsync
On Tue, May 19, 2020 at 7:29 AM Jorrit Jongma via rsync < rsync@lists.samba.org> wrote: > I've read up some more on the subject, and it seems the proper way to do > this with GCC is g++ and target attributes. I've refactored the patch that > way, and it indeed uses SSSE3 automatically on

Re: [PATCHv2] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-20 Thread Jorrit Jongma via rsync
I haven't found a way to control GCC's target selector at runtime (though in theory it could be possible), so switching between specific optimizations (SSE2 vs SSSE3) may prove difficult or require additional duplication of code. Bypassing the optimizations completely in an all-or-nothing way

Re: [PATCHv2] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-20 Thread Roland via rsync
would it perhaps make sense to have a "--disable-sse2/3" commandline switch in rsync, too - at least for some timeframe until this is considered "rock solid" ? i dislike having automatic cpu feature switching code in a tool which needs to be reliable for me, this new optimization may have issues

Re: [PATCHv2] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-19 Thread Jorrit Jongma via rsync
I've read up some more on the subject, and it seems the proper way to do this with GCC is g++ and target attributes. I've refactored the patch that way, and it indeed uses SSSE3 automatically on supporting CPUs, regardless of the build host, so this should be ideal both for home builders and