[Rails-spinoffs] Shrinking Prototype's timed form observer code

2006-12-09 Thread Peter Michaux
Hello Augmenters, (lighten up! ;-) ) [post order restored] On 12/4/06, Thomas Fuchs [EMAIL PROTECTED] wrote: Am 01.12.2006 um 19:15 schrieb Mislav: Just don't whine - make it work. (And contribute.) Exactly. Ok. Here's a suggestion. Prototype's abstract timed observer code looks a

[Rails-spinoffs] Re: Shrinking Prototype's timed form observer code

2006-12-09 Thread Martin Bialasinski
On 12/9/06, Martin Bialasinski [EMAIL PROTECTED] wrote: On 12/9/06, Peter Michaux [EMAIL PROTECTED] wrote: Note also that in the Prototype code if (this.lastValue != value) { should probably be if (this.lastValue !== value) { because both 0 and the empty string '' typecast to

[Rails-spinoffs] Re: Shrinking Prototype's timed form observer code

2006-12-09 Thread Michael Peters
Peter Michaux wrote: But we are still distributing the code every time it needs to be used so short without being ridiculous is better. [snip] The author written inline documentation will make it abundantly clear what these short-lived identifiers mean. So replace normal descriptive

[Rails-spinoffs] Changes to Form in r5449

2006-12-09 Thread jonathan . viney
Prior to r5449, you could use the Form.* methods on elements that weren't actually forms. I think this was actually a good thing, you could do: Form.disable('my_area') This would disable all form elements in my_area, even though my_area was not a form. As of r5449, Form.disable (as well as