svn commit: samba r12406 - branches/SAMBA_3_0/source/libads trunk/source/libads

2005-12-21 Thread gd
Author: gd Date: 2005-12-21 10:05:39 + (Wed, 21 Dec 2005) New Revision: 12406 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12406 Log: Since w2k3 sp1 we fail to create user accounts using e.g. net ads user add with Server is unwilling to perform. Seems we have

svn commit: samba r12407 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-12-21 Thread gd
Author: gd Date: 2005-12-21 12:52:04 + (Wed, 21 Dec 2005) New Revision: 12407 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12407 Log: Fix returning wrong error codes and better sort out errors and stdout messages. Guenther Modified: branches/SAMBA_3_0

svn commit: samba r12414 - branches/SAMBA_3_0/source/param branches/SAMBA_3_0/source/rpcclient branches/SAMBA_3_0/source/utils trunk/source/param trunk/source/rpcclient trunk/source/utils

2005-12-21 Thread gd
Author: gd Date: 2005-12-21 23:15:57 + (Wed, 21 Dec 2005) New Revision: 12414 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12414 Log: Remove the unnecessary SMB_STRDUP in server_role_str() + reuse the role translation elsewhere. Guenther Modified: branches

svn commit: samba r12415 - branches/SAMBA_3_0/source/param branches/SAMBA_3_0/source/utils trunk/source/param trunk/source/utils

2005-12-21 Thread gd
Author: gd Date: 2005-12-21 23:26:23 + (Wed, 21 Dec 2005) New Revision: 12415 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12415 Log: Forgot newlines. Guenther Modified: branches/SAMBA_3_0/source/param/loadparm.c branches/SAMBA_3_0/source/utils

svn commit: samba r12416 - in trunk/source: .

2005-12-21 Thread gd
Author: gd Date: 2005-12-22 00:00:20 + (Thu, 22 Dec 2005) New Revision: 12416 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12416 Log: Fix (new) unresolved symbols in pam_winbind. Guenther Modified: trunk/source/Makefile.in Changeset: Modified: trunk

svn commit: samba r12417 - in trunk/source/nsswitch: .

2005-12-21 Thread gd
Author: gd Date: 2005-12-22 00:03:30 + (Thu, 22 Dec 2005) New Revision: 12417 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12417 Log: Trying to make pam_winbind a little more easy to read. Guenther Modified: trunk/source/nsswitch/pam_winbind.c Changeset

svn commit: samba r12418 - in trunk/source/nsswitch: .

2005-12-21 Thread gd
Author: gd Date: 2005-12-22 01:07:56 + (Thu, 22 Dec 2005) New Revision: 12418 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12418 Log: Don't add an internal ccache to the refresh queue. Guenther Modified: trunk/source/nsswitch/winbindd_pam.c Changeset

svn commit: samba r12419 - in trunk/source/nsswitch: .

2005-12-21 Thread gd
Author: gd Date: 2005-12-22 01:08:39 + (Thu, 22 Dec 2005) New Revision: 12419 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12419 Log: Minor fixes and lots of reformat for pam_winbind. Guenther Modified: trunk/source/nsswitch/pam_winbind.c Changeset: Sorry

svn commit: samba r12420 - in trunk/source/nsswitch: .

2005-12-21 Thread gd
Author: gd Date: 2005-12-22 01:19:42 + (Thu, 22 Dec 2005) New Revision: 12420 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12420 Log: Fix BOOL mixup in pam_winbind that caused a pam conversation to fail. Guenther Modified: trunk/source/nsswitch

svn commit: samba r12396 - in trunk/source/libads: .

2005-12-20 Thread gd
Author: gd Date: 2005-12-20 12:15:10 + (Tue, 20 Dec 2005) New Revision: 12396 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12396 Log: Fix build warning. Guenther Modified: trunk/source/libads/ldap.c Changeset: Modified: trunk/source/libads/ldap.c

svn commit: samba r12326 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-18 22:45:56 + (Sun, 18 Dec 2005) New Revision: 12326 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12326 Log: Remove the DE/DR records from the winbind cache when the response is read from the tdb. Volker, please verify. Guenther

svn commit: samba r12329 - in trunk/source: . include lib libads libsmb utils

2005-12-18 Thread gd
Author: gd Date: 2005-12-18 23:30:14 + (Sun, 18 Dec 2005) New Revision: 12329 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12329 Log: Add experimental GPO client. The gpo list for the client already looks very close to that of an xp machine, the whole

svn commit: samba r12330 - in trunk/source: . include utils

2005-12-18 Thread gd
Author: gd Date: 2005-12-18 23:34:44 + (Sun, 18 Dec 2005) New Revision: 12330 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12330 Log: Don't use the client GPO. Guenther Modified: trunk/source/Makefile.in trunk/source/include/includes.h trunk/source

svn commit: samba r12331 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-18 23:59:15 + (Sun, 18 Dec 2005) New Revision: 12331 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12331 Log: Add two new winbindd methods to get account lockout and password policies. Guenther Modified: trunk/source/nsswitch

svn commit: samba r12332 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 00:01:56 + (Mon, 19 Dec 2005) New Revision: 12332 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12332 Log: Use the msrpc calls for account_policy/password_policy in the ads-backend. Guenther Modified: trunk/source/nsswitch

svn commit: samba r12333 - in trunk/source: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 00:15:51 + (Mon, 19 Dec 2005) New Revision: 12333 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12333 Log: add missing function check. Guenther Modified: trunk/source/configure.in Changeset: Modified: trunk/source/configure.in

svn commit: samba r12334 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 00:23:42 + (Mon, 19 Dec 2005) New Revision: 12334 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12334 Log: Only cosmetics, no change in behaviour. Guenther Modified: trunk/source/nsswitch/winbindd.c trunk/source/nsswitch

svn commit: samba r12336 - branches/SAMBA_3_0/examples/misc trunk/examples/misc

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 02:15:13 + (Mon, 19 Dec 2005) New Revision: 12336 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12336 Log: A couple of fixes and enhancements for adssearch.pl (espc. to debug GPOs). sid2string fix from Michael James [EMAIL PROTECTED

svn commit: samba r12337 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 02:18:09 + (Mon, 19 Dec 2005) New Revision: 12337 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12337 Log: Add select() and timed_event infrastructure in the winbind child process. Guenther Modified: trunk/source/nsswitch

svn commit: samba r12338 - branches/SAMBA_3_0/source/utils trunk/source/utils

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 02:22:13 + (Mon, 19 Dec 2005) New Revision: 12338 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12338 Log: add ifdef DEBUG_PASSWORD before printing clear text password. Guenther Modified: branches/SAMBA_3_0/source/utils/net_rpc.c

svn commit: samba r12339 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 02:44:26 + (Mon, 19 Dec 2005) New Revision: 12339 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12339 Log: Add lookup_cached_name. Guenther Modified: trunk/source/nsswitch/winbindd_cache.c Changeset: Modified: trunk/source

svn commit: samba r12340 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 02:50:15 + (Mon, 19 Dec 2005) New Revision: 12340 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12340 Log: Basics to add offline capability to winbindd. First, we must not clear the winbind_cache.tdb on each restart, then remember

svn commit: samba r12341 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 03:02:56 + (Mon, 19 Dec 2005) New Revision: 12341 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12341 Log: add DEBUG statement. Guenther Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c trunk/source/nsswitch

svn commit: samba r12342 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 03:15:50 + (Mon, 19 Dec 2005) New Revision: 12342 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12342 Log: request renewable tickets by default in winbind/security = ads. Guenther Modified: trunk/source/nsswitch/winbindd_ads.c

svn commit: samba r12343 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 03:28:10 + (Mon, 19 Dec 2005) New Revision: 12343 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12343 Log: Change a password using rpccli_samr_chgpasswd3 in WINBINDD_PAM_CHAUTHTOK and give back the password policy

svn commit: samba r12344 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 03:37:37 + (Mon, 19 Dec 2005) New Revision: 12344 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12344 Log: Add info3 as text to the winbindd_response (the flag to set this in a request was already there), the info3 is not complete

svn commit: samba r12345 - in trunk/source: . nsswitch

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 04:04:40 + (Mon, 19 Dec 2005) New Revision: 12345 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12345 Log: Add Kerberos authentication to winbindd. This allows a winbindd client to let the winbindd daemon do the PAM_AUTH using

svn commit: samba r12346 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 04:10:02 + (Mon, 19 Dec 2005) New Revision: 12346 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12346 Log: Add Kerberos Ticket Renewal/Refresh to winbindd (hanging in the eventloop of the winbindd child). Guenther Added: trunk

svn commit: samba r12347 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 04:15:33 + (Mon, 19 Dec 2005) New Revision: 12347 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12347 Log: Add WINBINDD_PAM_LOGOFF to destroy a krb5 ccache we created, again uses an ugly seteuid pair (I just don't know how to avoid

svn commit: samba r12348 - in trunk/source: . param

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 04:17:41 + (Mon, 19 Dec 2005) New Revision: 12348 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12348 Log: Forgot to add the lp_winbind_refresh_tickets parameter. Guenther Modified: trunk/source/Makefile.in trunk/source/param

svn commit: samba r12351 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 04:26:14 + (Mon, 19 Dec 2005) New Revision: 12351 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12351 Log: increase the interface version number. Guenther Modified: trunk/source/nsswitch/winbindd_nss.h Changeset: Modified: trunk

svn commit: samba r12352 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 04:27:46 + (Mon, 19 Dec 2005) New Revision: 12352 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12352 Log: Allow to auth against trusted domains when the WBFLAG_PAM_CONTACT_TRUSTDOM flag is set. Guenther Modified: trunk/source

svn commit: samba r12354 - in trunk/source: . nsswitch

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 04:32:05 + (Mon, 19 Dec 2005) New Revision: 12354 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12354 Log: The vastly modified pam_winbind module, now can do krb5 authentication, homedir creation, informs about password policies

svn commit: samba r12355 - in trunk/source/nsswitch: .

2005-12-18 Thread gd
Author: gd Date: 2005-12-19 04:34:04 + (Mon, 19 Dec 2005) New Revision: 12355 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12355 Log: Add my copyright here. Guenther Modified: trunk/source/nsswitch/winbindd_cache.c Changeset: Modified: trunk/source

svn commit: samba r12273 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-12-15 Thread gd
Author: gd Date: 2005-12-16 00:01:15 + (Fri, 16 Dec 2005) New Revision: 12273 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12273 Log: Fix copy paste error. Guenther Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_sid.c trunk/source/nsswitch

svn commit: samba r12193 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-12-12 Thread gd
Author: gd Date: 2005-12-12 14:08:42 + (Mon, 12 Dec 2005) New Revision: 12193 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12193 Log: Fix some typos. Guenther Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_cache.c branches/SAMBA_3_0/source

svn commit: samba r12130 - branches/SAMBA_3_0/source/rpcclient trunk/source/rpcclient

2005-12-08 Thread gd
Author: gd Date: 2005-12-08 16:25:33 + (Thu, 08 Dec 2005) New Revision: 12130 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12130 Log: display domain GUID. Guenther Modified: branches/SAMBA_3_0/source/rpcclient/cmd_lsarpc.c trunk/source/rpcclient

svn commit: samba r12131 - branches/SAMBA_3_0/source/rpcclient trunk/source/rpcclient

2005-12-08 Thread gd
Author: gd Date: 2005-12-08 16:34:57 + (Thu, 08 Dec 2005) New Revision: 12131 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12131 Log: Fix it really, this time :) Guenther Modified: branches/SAMBA_3_0/source/rpcclient/cmd_lsarpc.c trunk/source/rpcclient

svn commit: samba r12106 - branches/SAMBA_3_0/source/rpc_client trunk/source/rpc_client

2005-12-06 Thread gd
Author: gd Date: 2005-12-06 20:22:51 + (Tue, 06 Dec 2005) New Revision: 12106 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12106 Log: Fix return value Guenther Modified: branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c trunk/source/rpc_client

svn commit: samba r12015 - branches/SAMBA_3_0/source/client trunk/source/client

2005-12-02 Thread gd
Author: gd Date: 2005-12-02 10:26:29 + (Fri, 02 Dec 2005) New Revision: 12015 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=12015 Log: When smbspool tries to connect to a printer shared on a standalone Windows XP box, smbspool has to mimic smbclient behaviour

svn commit: samba r11964 - branches/SAMBA_3_0/source/rpc_parse branches/SAMBA_3_0/source/rpc_server branches/SAMBA_3_0/source/rpcclient trunk/source/rpc_parse trunk/source/rpc_server trunk/source/rpcc

2005-11-29 Thread gd
Author: gd Date: 2005-11-29 23:40:01 + (Tue, 29 Nov 2005) New Revision: 11964 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11964 Log: rename flag to password_properties in SAM_UNK_INFO_1 because that's what it is. (SAM_UNK_INFO_1 should get a better name as well

svn commit: samba r11966 - branches/SAMBA_3_0/source/include trunk/source/include

2005-11-29 Thread gd
Author: gd Date: 2005-11-30 00:09:14 + (Wed, 30 Nov 2005) New Revision: 11966 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11966 Log: fix the build\n\nGuenther Modified: branches/SAMBA_3_0/source/include/rpc_samr.h trunk/source/include/rpc_samr.h

svn commit: samba r11874 - branches/SAMBA_3_0/source/lib branches/SAMBA_3_0/source/passdb trunk/source/lib trunk/source/passdb

2005-11-23 Thread gd
Author: gd Date: 2005-11-23 11:17:04 + (Wed, 23 Nov 2005) New Revision: 11874 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11874 Log: Merge LDAP connection setup in lib/smbldap.c and pdb_nds.c. Also allow to use START_TLS in the pdb_nds_update_login_attempts

svn commit: samba r11875 - branches/SAMBA_3_0/source/libads trunk/source/libads

2005-11-23 Thread gd
Author: gd Date: 2005-11-23 11:21:16 + (Wed, 23 Nov 2005) New Revision: 11875 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11875 Log: Allow to use START_TLS (by manually setting ldap ssl = start_tls) for LDAP connections to ADS (Windows 2003). Guenther

svn commit: samba r11876 - branches/SAMBA_3_0/source/lib trunk/source/lib

2005-11-23 Thread gd
Author: gd Date: 2005-11-23 11:29:55 + (Wed, 23 Nov 2005) New Revision: 11876 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11876 Log: When we are using START_TLS to secure the LDAP connection, we *have* to call START_TLS again after rebinding to another LDAP

svn commit: samba r11846 - branches/SAMBA_3_0/source/libads branches/SAMBA_3_0/source/smbd trunk/source/libads trunk/source/smbd

2005-11-22 Thread gd
Author: gd Date: 2005-11-22 10:22:59 + (Tue, 22 Nov 2005) New Revision: 11846 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11846 Log: Destroy the TALLOC_CTX on error in the Kerberos session setup and give a more precise inline comment why PAC verification may

svn commit: samba r11851 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-11-22 Thread gd
Author: gd Date: 2005-11-22 13:33:44 + (Tue, 22 Nov 2005) New Revision: 11851 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11851 Log: Display correct error string. Guenther Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_pam.c trunk/source/nsswitch

svn commit: samba r11852 - branches/SAMBA_3_0/source/include branches/SAMBA_3_0/source/rpc_client branches/SAMBA_3_0/source/rpc_parse branches/SAMBA_3_0/source/rpcclient trunk/source/include trunk/sou

2005-11-22 Thread gd
Author: gd Date: 2005-11-22 13:58:51 + (Tue, 22 Nov 2005) New Revision: 11852 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11852 Log: Fill in samr_get_dom_pwinfo based on Samba4. Guenther Modified: branches/SAMBA_3_0/source/include/rpc_samr.h branches

svn commit: samba r11856 - branches/SAMBA_3_0/source/include branches/SAMBA_3_0/source/rpc_parse branches/SAMBA_3_0/source/rpc_server branches/SAMBA_3_0/source/rpcclient trunk/source/include trunk/sou

2005-11-22 Thread gd
Author: gd Date: 2005-11-22 14:29:14 + (Tue, 22 Nov 2005) New Revision: 11856 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11856 Log: Replace unknown1 with group_attr. Can anyone remember why we initialize groups only with 0x03 instead of 0x07 ? Guenther

svn commit: samba r11858 - branches/SAMBA_3_0/source/rpc_parse branches/SAMBA_3_0/source/rpcclient trunk/source/rpc_parse trunk/source/rpcclient

2005-11-22 Thread gd
Author: gd Date: 2005-11-22 14:38:49 + (Tue, 22 Nov 2005) New Revision: 11858 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11858 Log: Fill in the clientside TRUSTED_DOMAIN_INFO_EX query. Guenther Modified: branches/SAMBA_3_0/source/rpc_parse/parse_lsa.c

svn commit: samba r11859 - branches/SAMBA_3_0/source/rpc_server trunk/source/rpc_server

2005-11-22 Thread gd
Author: gd Date: 2005-11-22 14:41:40 + (Tue, 22 Nov 2005) New Revision: 11859 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11859 Log: Another place where the SE_GROUP constants read better then 7. Guenther Modified: branches/SAMBA_3_0/source/rpc_server

svn commit: samba r11790 - branches/SAMBA_3_0/source/client trunk/source/client

2005-11-18 Thread gd
Author: gd Date: 2005-11-18 14:33:12 + (Fri, 18 Nov 2005) New Revision: 11790 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11790 Log: Avoid infinite retry to gather a connection. Guenther Modified: branches/SAMBA_3_0/source/client/smbspool.c trunk/source

svn commit: samba-docs r846 - in trunk/smbdotconf/winbind: .

2005-10-21 Thread gd
Author: gd Date: 2005-10-21 10:00:35 + (Fri, 21 Oct 2005) New Revision: 846 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-docsrev=846 Log: Document idmap_ad plugin and winbindd nss info. Guenther Added: trunk/smbdotconf/winbind/winbindnssinfo.xml Modified

svn commit: samba r11242 - branches/SAMBA_3_0/source/include branches/SAMBA_3_0/source/nsswitch trunk/source/include trunk/source/nsswitch

2005-10-21 Thread gd
Author: gd Date: 2005-10-21 12:50:39 + (Fri, 21 Oct 2005) New Revision: 11242 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11242 Log: use LDAP bitwise machting rule when searching for groups in ADS. This avoids that each time a full-group-dump is requested from

svn commit: samba r11213 - branches/SAMBA_3_0/source/include branches/SAMBA_3_0/source/smbd trunk/source/include trunk/source/smbd

2005-10-20 Thread gd
Author: gd Date: 2005-10-20 08:13:00 + (Thu, 20 Oct 2005) New Revision: 11213 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11213 Log: Fix the build Guenther Modified: branches/SAMBA_3_0/source/include/includes.h branches/SAMBA_3_0/source/smbd/sesssetup.c

svn commit: samba r11183 - branches/SAMBA_3_0/source/libads branches/SAMBA_3_0/source/smbd trunk/source/libads trunk/source/smbd

2005-10-19 Thread gd
Author: gd Date: 2005-10-19 14:34:17 + (Wed, 19 Oct 2005) New Revision: 11183 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=11183 Log: add small helper function to return a PAC_LOGON_INFO. Guenther Modified: branches/SAMBA_3_0/source/libads/authdata.c

svn commit: samba r10976 - branches/SAMBA_3_0/source/lib trunk/source/lib

2005-10-13 Thread gd
Author: gd Date: 2005-10-13 22:11:18 + (Thu, 13 Oct 2005) New Revision: 10976 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10976 Log: Fix the build with openssl-0.9.8a. Guenther Modified: branches/SAMBA_3_0/source/lib/afs.c branches/SAMBA_3_0/source/lib

svn commit: samba r10977 - branches/SAMBA_3_0/source trunk/source

2005-10-13 Thread gd
Author: gd Date: 2005-10-13 23:03:30 + (Thu, 13 Oct 2005) New Revision: 10977 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10977 Log: Get rid of tons of new warnings when building with OpenLDAP 2.3.7 or higher. Guenther Modified: branches/SAMBA_3_0/source

svn commit: samba r10907 - branches/SAMBA_3_0/source/libads branches/SAMBA_3_0/source/libsmb trunk/source/libads trunk/source/libsmb

2005-10-11 Thread gd
Author: gd Date: 2005-10-11 16:27:05 + (Tue, 11 Oct 2005) New Revision: 10907 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10907 Log: Handle the case when we can't verify the PAC signature because the ticket was encrypted using a DES key (and the Windows KDC

svn commit: samba r10782 - branches/SAMBA_3_0/source/rpc_parse trunk/source/rpc_parse

2005-10-06 Thread gd
Author: gd Date: 2005-10-06 18:00:19 + (Thu, 06 Oct 2005) New Revision: 10782 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10782 Log: Only parse the group rid_array in net_user_info3() when num_group is 0. This fixes the PAC parsing for win2k DCs up to SP3

svn commit: samba r10710 - branches/SAMBA_3_0/source/libads trunk/source/libads

2005-10-04 Thread gd
Author: gd Date: 2005-10-04 11:21:57 + (Tue, 04 Oct 2005) New Revision: 10710 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10710 Log: Fix uninitialized variable. (Thanks to Chengjie Liu [EMAIL PROTECTED]) Guenther Modified: branches/SAMBA_3_0/source/libads

svn commit: samba r10474 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-09-24 Thread gd
Author: gd Date: 2005-09-24 11:33:55 + (Sat, 24 Sep 2005) New Revision: 10474 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10474 Log: We better ignore builtin SIDs from the Active Directory DC to prevent that AD's builtin groups mixup with our own builtin groups

svn commit: samba r10437 - in trunk/source: . auth include lib libads libsmb nsswitch rpc_parse smbd utils

2005-09-22 Thread gd
Author: gd Date: 2005-09-22 23:42:38 + (Thu, 22 Sep 2005) New Revision: 10437 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10437 Log: Use the Kerberos PAC when building the user token in a SPNEGO-Kerberos Session Setup. In a lot of areas this is a direct port

svn commit: samba r10441 - in trunk/source: libads libsmb

2005-09-22 Thread gd
Author: gd Date: 2005-09-23 02:13:27 + (Fri, 23 Sep 2005) New Revision: 10441 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10441 Log: fix the build (until we find a better solution) Guenther Modified: trunk/source/libads/authdata.c trunk/source/libsmb

svn commit: samba r10261 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-09-16 Thread gd
Author: gd Date: 2005-09-16 12:50:24 + (Fri, 16 Sep 2005) New Revision: 10261 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10261 Log: Don't bother to peek rids in builtin-sids. Guenther Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_ads.c trunk

svn commit: samba r10262 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-09-16 Thread gd
Author: gd Date: 2005-09-16 13:01:25 + (Fri, 16 Sep 2005) New Revision: 10262 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10262 Log: * Fix for getgrnam not returning builtin group (which is done by getent group) * Give a better debug message when returning

svn commit: samba r10263 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-09-16 Thread gd
Author: gd Date: 2005-09-16 13:12:08 + (Fri, 16 Sep 2005) New Revision: 10263 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10263 Log: Fix debug which got more instead of less confusing. Guenther Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_group.c

svn commit: samba r10270 - branches/SAMBA_3_0/source/nsswitch trunk/source/nsswitch

2005-09-16 Thread gd
Author: gd Date: 2005-09-16 16:37:45 + (Fri, 16 Sep 2005) New Revision: 10270 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10270 Log: lowercase groupnames and groupmembers again. Guenther Modified: branches/SAMBA_3_0/source/nsswitch/winbindd_util.c trunk

svn commit: samba r10205 - branches/SAMBA_3_0/source/rpc_parse trunk/source/rpc_parse

2005-09-13 Thread gd
Author: gd Date: 2005-09-13 17:03:03 + (Tue, 13 Sep 2005) New Revision: 10205 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10205 Log: fix obvious typo in the NET_USER_INFO_3 parsing Guenther Modified: branches/SAMBA_3_0/source/rpc_parse/parse_net.c trunk

svn commit: samba r10210 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

2005-09-13 Thread gd
Author: gd Date: 2005-09-13 21:21:43 + (Tue, 13 Sep 2005) New Revision: 10210 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10210 Log: Fix memleak. Guenther Modified: branches/SAMBA_3_0/source/libsmb/clikrb5.c trunk/source/libsmb/clikrb5.c Changeset

svn commit: samba r10211 - branches/SAMBA_3_0/source/libads trunk/source/libads

2005-09-13 Thread gd
Author: gd Date: 2005-09-13 21:26:25 + (Tue, 13 Sep 2005) New Revision: 10211 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10211 Log: Fix another memleak (this time in the kerberos keytab code) Guenther Modified: branches/SAMBA_3_0/source/libads

svn commit: samba r10170 - branches/SAMBA_3_0/source/sam trunk/source/sam

2005-09-12 Thread gd
Author: gd Date: 2005-09-12 11:56:36 + (Mon, 12 Sep 2005) New Revision: 10170 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10170 Log: Fix for #3056: Allow to include BUILTIN to the mapping table also when allow trusted domains is disabled. Guenther Modified

svn commit: samba r10154 - branches/SAMBA_3_0/source/printing trunk/source/printing

2005-09-11 Thread gd
Author: gd Date: 2005-09-11 20:53:21 + (Sun, 11 Sep 2005) New Revision: 10154 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=10154 Log: Fix crash bug on security descriptor upgrade (as seen on x86_64). Guenther Modified: branches/SAMBA_3_0/source/printing

svn commit: samba r9944 - branches/SAMBA_3_0/source/python trunk/source/python

2005-09-02 Thread gd
Author: gd Date: 2005-09-02 09:06:33 + (Fri, 02 Sep 2005) New Revision: 9944 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9944 Log: fix python build Guenther Modified: branches/SAMBA_3_0/source/python/setup.py trunk/source/python/setup.py Changeset

svn commit: samba r9953 - in branches/SAMBA_3_0/source/lib: .

2005-09-02 Thread gd
Author: gd Date: 2005-09-02 13:07:42 + (Fri, 02 Sep 2005) New Revision: 9953 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9953 Log: get rid of compiler warning. Guenther Modified: branches/SAMBA_3_0/source/lib/smbldap.c Changeset: Modified: branches

svn commit: samba r9955 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

2005-09-02 Thread gd
Author: gd Date: 2005-09-02 13:39:39 + (Fri, 02 Sep 2005) New Revision: 9955 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9955 Log: Fix misleading comments. Guenther Modified: branches/SAMBA_3_0/source/libsmb/clidfs.c trunk/source/libsmb/clidfs.c

svn commit: samba r9958 - branches/SAMBA_3_0/source/libsmb trunk/source/libsmb

2005-09-02 Thread gd
Author: gd Date: 2005-09-02 14:12:04 + (Fri, 02 Sep 2005) New Revision: 9958 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9958 Log: revert last commit. Guenther Modified: branches/SAMBA_3_0/source/libsmb/clidfs.c trunk/source/libsmb/clidfs.c Changeset

svn commit: samba r9888 - in branches/SAMBA_4_0/source: librpc/idl rpc_server/lsa torture/rpc

2005-09-01 Thread gd
Author: gd Date: 2005-09-01 10:36:48 + (Thu, 01 Sep 2005) New Revision: 9888 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9888 Log: add IDL for lsa_QueryDomainInformationPolicy to query Kerberos Settings. Guenther Modified: branches/SAMBA_4_0/source/librpc

svn commit: samba r9736 - branches/SAMBA_3_0/source/client trunk/source/client

2005-08-29 Thread gd
Author: gd Date: 2005-08-29 13:10:20 + (Mon, 29 Aug 2005) New Revision: 9736 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9736 Log: be a little more verbose on error. Guenther Modified: branches/SAMBA_3_0/source/client/smbspool.c trunk/source/client

svn commit: samba r9522 - branches/SAMBA_3_0/source/passdb trunk/source/passdb

2005-08-23 Thread gd
Author: gd Date: 2005-08-23 13:58:05 + (Tue, 23 Aug 2005) New Revision: 9522 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9522 Log: Give better error-message when NDS Universal Password change fails. Guenther Modified: branches/SAMBA_3_0/source/passdb

svn commit: samba r9523 - branches/SAMBA_3_0/examples/LDAP trunk/examples/LDAP

2005-08-23 Thread gd
Author: gd Date: 2005-08-23 14:02:12 + (Tue, 23 Aug 2005) New Revision: 9523 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9523 Log: Fix password history for eDirectory (by allowing to store more then 1 password history entry in LDAP...) Thanks to Bernhard

svn commit: samba r9229 - in branches/SAMBA_3_0/source/rpc_server: .

2005-08-10 Thread gd
Author: gd Date: 2005-08-10 16:02:32 + (Wed, 10 Aug 2005) New Revision: 9229 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9229 Log: merge from trunk: allow admins to uncheck the User must change Password at next Logon checkbox in Usermanager. Guenther Modified

svn commit: samba r9163 - branches/SAMBA_3_0/source/include branches/SAMBA_3_0/source/libads trunk/source/include trunk/source/libads

2005-08-05 Thread gd
Author: gd Date: 2005-08-06 04:35:11 + (Sat, 06 Aug 2005) New Revision: 9163 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9163 Log: Rename UNKNOWN_TYPE_10 to PAC_LOGON_NAME (merge from samba4) Guenther Modified: branches/SAMBA_3_0/source/include/authdata.h

svn commit: samba r9076 - branches/SAMBA_3_0/source/rpcclient branches/SAMBA_3_0/source/utils trunk/source/rpcclient trunk/source/utils

2005-08-04 Thread gd
Author: gd Date: 2005-08-04 23:20:48 + (Thu, 04 Aug 2005) New Revision: 9076 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9076 Log: fix two other issues invented along the cli_spoolss_enumprinterkey-changes. Guenther Modified: branches/SAMBA_3_0/source

svn commit: samba r9021 - branches/SAMBA_3_0/source/rpc_server trunk/source/rpc_server

2005-08-03 Thread gd
Author: gd Date: 2005-08-03 22:07:57 + (Wed, 03 Aug 2005) New Revision: 9021 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9021 Log: Fix smbd-crash bug in openprinter (found by samba4 smbtorture RPC-SPOOLSS). Guenther Modified: branches/SAMBA_3_0/source

svn commit: samba r9029 - branches/SAMBA_3_0/source/lib trunk/source/lib

2005-08-03 Thread gd
Author: gd Date: 2005-08-04 01:41:03 + (Thu, 04 Aug 2005) New Revision: 9029 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9029 Log: Another crash bug when enumerating privileges. Thanks Volker! Guenther Modified: branches/SAMBA_3_0/source/lib/privileges.c

svn commit: samba r9041 - branches/SAMBA_3_0/source/rpc_client trunk/source/rpc_client

2005-08-03 Thread gd
Author: gd Date: 2005-08-04 03:25:33 + (Thu, 04 Aug 2005) New Revision: 9041 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=9041 Log: typo. Thanks jerry. Guenther Modified: branches/SAMBA_3_0/source/rpc_client/cli_spoolss.c trunk/source/rpc_client

svn commit: samba r8911 - branches/SAMBA_3_0/source/utils trunk/source/utils

2005-08-02 Thread gd
Author: gd Date: 2005-08-02 06:24:45 + (Tue, 02 Aug 2005) New Revision: 8911 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8911 Log: cosmetic fixes. Guenther Modified: branches/SAMBA_3_0/source/utils/net.c branches/SAMBA_3_0/source/utils/net_rpc.c

svn commit: samba r8914 - in trunk/source: lib param

2005-08-02 Thread gd
Author: gd Date: 2005-08-02 07:08:04 + (Tue, 02 Aug 2005) New Revision: 8914 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8914 Log: remove some unused variables Guenther Modified: trunk/source/lib/account_pol.c trunk/source/param/loadparm.c Changeset

svn commit: samba r8924 - in trunk/source/param: .

2005-08-02 Thread gd
Author: gd Date: 2005-08-02 17:02:01 + (Tue, 02 Aug 2005) New Revision: 8924 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8924 Log: remove more leftovers. Guenther Modified: trunk/source/param/loadparm.c Changeset: Modified: trunk/source/param/loadparm.c

svn commit: samba r8929 - in trunk/source: include lib

2005-08-02 Thread gd
Author: gd Date: 2005-08-02 18:14:01 + (Tue, 02 Aug 2005) New Revision: 8929 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8929 Log: fix build-issue when building without LDAP (found by Jeremy) Guenther Modified: trunk/source/include/smbldap.h trunk/source

svn commit: samba r8937 - branches/SAMBA_3_0/source/rpcclient trunk/source/rpcclient

2005-08-02 Thread gd
Author: gd Date: 2005-08-02 19:46:11 + (Tue, 02 Aug 2005) New Revision: 8937 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8937 Log: allow to use non-default smb.conf in rpcclient Guenther Modified: branches/SAMBA_3_0/source/rpcclient/rpcclient.c trunk

svn commit: samba r8938 - branches/SAMBA_3_0/source/rpcclient trunk/source/rpcclient

2005-08-02 Thread gd
Author: gd Date: 2005-08-02 19:48:42 + (Tue, 02 Aug 2005) New Revision: 8938 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8938 Log: fix querydispinfo search semantics. Just in case some uses rpcclient for code-testing... Guenther Modified: branches

svn commit: samba r8971 - branches/SAMBA_3_0/source/rpc_server trunk/source/rpc_server

2005-08-02 Thread gd
Author: gd Date: 2005-08-03 01:08:42 + (Wed, 03 Aug 2005) New Revision: 8971 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8971 Log: Fix querydispinfo (still need to look at enumdomusers) to allow to list more then 511 users. After the rewrite, the old NT_STATUS

svn commit: samba r8906 - in trunk/source: include lib passdb registry rpc_server

2005-08-01 Thread gd
Author: gd Date: 2005-08-02 01:41:03 + (Tue, 02 Aug 2005) New Revision: 8906 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8906 Log: rework account policies in passdb (ldapsam): there are now stored on a per attribute basis inside the sambaDomain-object which

svn commit: samba r8908 - in trunk/examples/LDAP: .

2005-08-01 Thread gd
Author: gd Date: 2005-08-02 04:37:03 + (Tue, 02 Aug 2005) New Revision: 8908 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8908 Log: forgot to add modified LDAP-schema. Guenther Modified: trunk/examples/LDAP/samba.schema Changeset: Modified: trunk/examples

svn commit: samba r8786 - branches/SAMBA_3_0/source/utils trunk/source/utils

2005-07-26 Thread gd
Author: gd Date: 2005-07-26 20:11:37 + (Tue, 26 Jul 2005) New Revision: 8786 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8786 Log: Fix amazing and long-standing bug where user-accounts are just crippled accounts (accounts without AcctCtrl set) after a vampire

svn commit: samba r8787 - branches/SAMBA_3_0/source/passdb trunk/source/passdb

2005-07-26 Thread gd
Author: gd Date: 2005-07-26 21:57:49 + (Tue, 26 Jul 2005) New Revision: 8787 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8787 Log: Make enumeration of builtin-aliases work again. Guenther Modified: branches/SAMBA_3_0/source/passdb/pdb_ldap.c trunk/source

svn commit: samba r8675 - branches/SAMBA_3_0/source/libads branches/SAMBA_3_0/source/utils trunk/source/libads trunk/source/utils

2005-07-21 Thread gd
Author: gd Date: 2005-07-21 09:28:12 + (Thu, 21 Jul 2005) New Revision: 8675 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8675 Log: fix some compile warnings. Guenther Modified: branches/SAMBA_3_0/source/libads/ldap_printer.c branches/SAMBA_3_0/source

svn commit: samba r8686 - branches/SAMBA_3_0/source/lib branches/SAMBA_3_0/source/printing trunk/source/lib trunk/source/printing

2005-07-21 Thread gd
Author: gd Date: 2005-07-21 17:40:20 + (Thu, 21 Jul 2005) New Revision: 8686 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=8686 Log: Revert %LOGONSERVER%-substitution. The substition is done on the client, not on the server. We now preserve this windows variable

<    4   5   6   7   8   9   10   11   >