> The patch seems to do some unneeded / unrelated changes though. Why
> do
> you move the boot_add() call? Why the desc changes? Why return the
> namespace? Just returning a int or bool telling whenever the namespace
> is active or not should be enough, no?
You're right, these changes are
> > [ just back from vacation ]
> >
> > Well, assuming the first namespace is the one you want actually boot
> > from. Which I expect is the common case, but who knows how people
> > use their machines ...
> >
> > IIRC there is some work in progress to add bootorder support for
> > namespaces,
> -Original Message-
> From: Gerd Hoffmann
> Sent: 21 July 2021 15:57
> To: Thanos Makatos
> Cc: seabios@seabios.org; Thanos Makatos
> Subject: Re: [PATCH] nvme: don't keep probing namespaces after an active
> one has been found
>
> On Thu, Jul 01, 2021 at 02:20:47PM +, Thanos
On Thu, Jul 01, 2021 at 02:20:47PM +, Thanos Makatos wrote:
> From: Thanos Makatos
>
> The current implementation keeps probing NVMe namespaces even if an
> active one has been found. This is unnecessary and most importantly
> results in memory allocation failure if the are more than a few