[SeaBIOS] Re: [PATCH v2] src/hw/virtio-blk: add feature VIRTIO_BLK_F_SIZE_MAX and VIRTIO_BLK_F_SEG_MAX

2021-11-30 Thread Gerd Hoffmann
On Tue, Nov 30, 2021 at 05:23:52AM +, Pei, Andy wrote: > Hi Gerd, > > Yes, you are right. > I think reading these two config register is fine during init and align with > the virtio blk spec. It is not wrong but also pointless. > In the near future, we will working on some related work on

[SeaBIOS] Re: [PATCH v2] src/hw/virtio-blk: add feature VIRTIO_BLK_F_SIZE_MAX and VIRTIO_BLK_F_SEG_MAX

2021-11-29 Thread Pei, Andy
Hi Gerd, Yes, you are right. I think reading these two config register is fine during init and align with the virtio blk spec. In the near future, we will working on some related work on these two value. To be specific, we will do some modification in virtio blk driver. If driver reads data

[SeaBIOS] Re: [PATCH v2] src/hw/virtio-blk: add feature VIRTIO_BLK_F_SIZE_MAX and VIRTIO_BLK_F_SEG_MAX

2021-11-29 Thread Gerd Hoffmann
On Fri, Nov 26, 2021 at 04:06:23PM +0800, Andy Pei wrote: > according to virtio spec, add feature VIRTIO_BLK_F_SIZE_MAX > and VIRTIO_BLK_F_SEG_MAX parse to virtio blk driver. Why is this needed? The code never actually uses max_segment_size and max_segments (other than logging the values) ...