Reply in line
> +if (features & max_segment_size)
> +vdrive->drive.max_segment_size =
> +vp_read(>device, struct virtio_blk_config,
> + size_max);
> +else
> +vdrive->drive.max_segment_size = 0;
Not needed, there is a memset(0) for the
Reply in line
> +} else {
> +struct vring_list *p_sg = [1];
Not needed, you can just use sg[1].addr
Andy: I used to think sg[1]. Length, but I am not sure. Could you please tell
me why sg[1]. Length is not needed ?
> +void *p = op->buf_fl;
> +u16 count =
Thanks Kevin
-Original Message-
From: Kevin O'Connor
Sent: Sunday, December 19, 2021 12:55 AM
To: Pei, Andy
Cc: seabios@seabios.org; kra...@redhat.com
Subject: Re: [PATCH v4 0/3] virtio-blk: add feature VIRTIO_BLK_F_SIZE_MAX
On Tue, Dec 07, 2021 at 09:31:05AM +0800, Andy Pei wrote
Hi Paul,
Reply inline.
-Original Message-
From: Paul Menzel
Sent: Friday, November 26, 2021 4:33 PM
To: Pei, Andy
Cc: dingli...@cmss.chinamobile.com; seabios ; Kevin
O'Connor ; Gerd Hoffmann
Subject: Re: [SeaBIOS] [PATCH] src/hw/virtio-blk: add feature
VIRTIO_BLK_F_SIZE_MAX
Hi Paul,
Thanks for your response.
Reply inline.
-Original Message-
From: Paul Menzel
Sent: Friday, November 26, 2021 4:08 PM
To: Pei, Andy
Cc: dingli...@cmss.chinamobile.com; seabios@seabios.org; Kevin O'Connor
; Gerd Hoffmann
Subject: Re: [SeaBIOS] [PATCH] src/hw/virtio-blk: add
To: Pei, Andy
Cc: seabios@seabios.org; ke...@koconnor.net; Ding Limin
Subject: Re: [PATCH v2] src/hw/virtio-blk: add feature VIRTIO_BLK_F_SIZE_MAX
and VIRTIO_BLK_F_SEG_MAX
On Fri, Nov 26, 2021 at 04:06:23PM +0800, Andy Pei wrote:
> according to virtio spec, add feature VIRTIO_BLK_F_SIZE_
Hi,
Terribly sorry for sending out a wrong patch.
A V2 series will be sent, please ignore this patch set.
Sorry for confusing.
-Original Message-
From: Pei, Andy
Sent: Wednesday, December 1, 2021 9:11 PM
To: seabios@seabios.org
Cc: kra...@redhat.com; ke...@koconnor.net; Pei, Andy
Hi Gerd,
Thanks for your effort.
-Original Message-
From: Gerd Hoffmann
Sent: Tuesday, December 7, 2021 4:28 PM
To: Pei, Andy
Cc: seabios@seabios.org; ke...@koconnor.net; Ding Limin
Subject: Re: [PATCH v4 3/3] virtio-blk.: split large IO according to size_max
On Tue, Dec 07, 2021
