; pci_pad_mem64 && is64
> -&& (type == PCI_REGION_TYPE_PREFMEM))
> -align = pci_mem64_top >> 11;
> +&& (type == PCI_REGION_TYPE_PREFMEM) && (top_align > align)
On Sat, Feb 10, 2024 at 08:39:15PM +, Riku Viitanen via SeaBIOS wrote:
> romfile_loadfile_g:
> Based on romfile_loadfile but more flexible. User has to supply pointer
> to a malloc function and the number of trailing padding bytes. Thus, any
> memory region may be used.
I'd suggest to add a
On Sun, Feb 11, 2024 at 09:49:21AM +0300, Michael Tokarev wrote:
> Hello! Thank you for the reply!
>
> > Just a random idea, maybe there is something wrong with windows failing to
> > emulate stuff?
> > (the vgafixup.py)
>
> Well.
>
> Windows might fail to emulate something. The prob with
On Mon, Feb 12, 2024 at 01:06:34PM +0100, Fiona Ebner wrote:
> Am 10.02.24 um 21:17 schrieb Michael Tokarev:
> > So.. the difference is vgabios only, not seabios (vgabios-stdvga in this
> > case).
> >
> > And I can't get it to work with debugging vgabios, it always fails even
> > with
Hi,
> > Cc'ing qemu-devel: Are there any qemu changes pending or
> > planned for 8.2 which need changes in seabios?
/me notes that nobody raised his hand.
> Hello Gerd,
>
> The QEMU 8.2 devel cycle has started.
>
> I do not want to stress you, but if we want to get additional fixes in,
>
Hi,
> -struct usb_pipe *keyboard_pipe VARFSEG;
> +struct keyboard_list {
> +struct usb_pipe *keyboard_pipe;
> +struct keyboard_list *next;
> +};
seabios has list macros (see src/list.h), please use them to implement a
linked list.
thanks,
Gerd
On Thu, Aug 24, 2023 at 10:57:50AM +0200, Gerd Hoffmann wrote:
> v4 changes:
> - fix handling of 32bit memory bars.
> v3 changes:
> - rename variables, use u8 for CPULongMode.
> v2 changes:
> - e820 conflict fix
>
> Gerd Hoffmann (6):
> better kvm detection
>
Add support to check for overlaps with e820 entries.
In case the 64bit pci io window has conflicts move it down.
The only known case where this happens is AMD processors
with 1TB address space which has some space just below
1TB reserved for HT.
Signed-off-by: Gerd Hoffmann
---
src/e820map.h
With loglevel 1 (same we use for RAM entries),
so it is included in the firmware log by default.
Signed-off-by: Gerd Hoffmann
---
src/fw/paravirt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/fw/paravirt.c b/src/fw/paravirt.c
index 3aee4c0d4e6b..e5d4eca0cb5a 100644
window.
The total mmio window size is 1/8 of the physical address space.
Minimum bridge windows size is 1/256 of the total mmio window size.
Signed-off-by: Gerd Hoffmann
---
src/fw/pciinit.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/fw/pciinit.c b/src
enable this by default, and most likely the qemu default will
change in near future too.
Signed-off-by: Gerd Hoffmann
---
src/fw/paravirt.h | 2 ++
src/fw/paravirt.c | 57 +++
2 files changed, 59 insertions(+)
diff --git a/src/fw/paravirt.h b/src/fw
When the size of the physical address space is known (PhysBits is not
zero) move the 64bit pci io window to the end of the address space.
Signed-off-by: Gerd Hoffmann
---
src/fw/pciinit.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
index
v4 changes:
- fix handling of 32bit memory bars.
v3 changes:
- rename variables, use u8 for CPULongMode.
v2 changes:
- e820 conflict fix
Gerd Hoffmann (6):
better kvm detection
detect physical address space size
move 64bit pci window to end of address space
be less conservative
.
Signed-off-by: Gerd Hoffmann
---
src/fw/paravirt.c | 30 +-
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/src/fw/paravirt.c b/src/fw/paravirt.c
index fba4e52db684..42abac8460c5 100644
--- a/src/fw/paravirt.c
+++ b/src/fw/paravirt.c
@@ -53,23 +53,35
On Mon, Aug 07, 2023 at 10:51:33AM +, Niklas Cassel via SeaBIOS wrote:
> Hello Seabios maintainers,
>
>
> I was wondering, is there any chance of getting a new release tag
> (e.g. rel-1.16.3) anytime soon?
> Or is there any plan on when it will be tagged?
>
> I'm waiting to send out a (AHCI
On Mon, Aug 07, 2023 at 07:52:57AM +0100, Mark Cave-Ayland wrote:
> Whilst trying to improve QEMU's ESP SCSI implementation with regard to the
> NCR datasheet, I noticed that SeaBIOS would fail to boot one of my Debian
> test images with my patches applied.
>
> Further investigation revealed that
On Fri, Jul 28, 2023 at 04:41:48AM +, Tony Titus via SeaBIOS wrote:
> For platforms with high number of numa nodes, 32 e820 entries are not
> enough. Linux kernel sets the maximum e820 entries to a base value of
> 128. Setting BUILD_MAX_E820 to 128 to be in sync with this base value.
>
>
he
> > AHCI command to timeout.
>
> Gerd, would you be able to review this patch?
Description and patch look good to me, testing with qemu works fine.
Tested-by: Gerd Hoffmann
Acked-by: Gerd Hoffmann
take care,
Gerd
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
Hi,
> I'm running a x86 QEMU with Ubuntu. On this system we want to emulate
> a PCIe device which contains a large 32-bit BAR (2 GiB). This is not
> working and I get following error:
Why a 32-bit bar, not a 64-bit bar?
A 2G 32-bit bar simply can't be mapped anywhere on x86. It must be
below
Hi,
> Ok, we have as of today two changes:
>
> kraxel@sirius ~/projects/seabios (master)# git log --oneline rel-1.16.1..
> ea1b7a073390 xen: require Xen info structure at 0x1000 to detect Xen
> 645a64b4911d usb: fix wrong init of keyboard/mouse's if first interface is
> not boot
On Tue, Mar 07, 2023 at 08:42:18AM +, David Woodhouse wrote:
> On Thu, 2023-02-02 at 10:10 +0100, Gerd Hoffmann wrote:
> > > Thanks, Kevin.
> > >
> > > I'd like to get the rest of the Xen platform support in to qemu 8.0
> > > if
> > >
On Tue, Jan 24, 2023 at 12:58:26PM +0100, Marek Marczykowski-Górecki wrote:
> Hello,
>
> I see rel-1.16.1 tag on
> https://review.coreboot.org/plugins/gitiles/seabios/, but that's about
> the only place where it's visible - no tarball, no info on
> https://www.seabios.org/Releases etc. Is 1.16.1
> Thanks, Kevin.
>
> I'd like to get the rest of the Xen platform support in to qemu 8.0 if
> possible. Which is currently scheduled for March.
>
> Is there likely to be a SeaBIOS release before then which Gerd would
> pull into qemu anyway, or should I submit a submodule update to a
> snapshot
relax that a bit. In case we find memory above
4G it should be safe to assume that PCI bars above 4G are fine too.
take care,
Gerd
commit c7074250e6faaeffc5e8966a8a0ecdfe8a5c2af3
Author: Gerd Hoffmann
Date: Fri Sep 9 10:17:15 2022 +0200
[testing] force 64bit pci window
diff --git a/
On Thu, Jul 07, 2022 at 11:13:52AM -0400, Kevin O'Connor wrote:
> On Thu, Jul 07, 2022 at 12:06:16PM +0200, Gerd Hoffmann wrote:
> > Bump default from 8 to 64 blocks. Using 8 by default leads
> > to requests being splitted on qemu, which slows down boot.
> >
> > Som
.
Signed-off-by: Gerd Hoffmann
---
src/hw/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/hw/virtio-blk.c b/src/hw/virtio-blk.c
index 929ba8873dc0..9b4a05a4c424 100644
--- a/src/hw/virtio-blk.c
+++ b/src/hw/virtio-blk.c
@@ -95,7 +95,7 @@ virtio_blk_op(struct
On Thu, Jun 30, 2022 at 12:46:39PM -0400, Felix Freeman via SeaBIOS wrote:
> On Thu Jun 30, 2022 at 7:29 AM -04, Gerd Hoffmann wrote:
> > > So, my first question is: what is needed to force SeaBIOS/SeaVGABIOS
> > > to display a resolution of 1024x768 instead of 640x480 whe
On Wed, Jun 29, 2022 at 02:50:10AM -0400, Felix Freeman via SeaBIOS wrote:
> Hello,
>
> I have noticed several problems when using coreboot native graphics ("high
> resolution" linear framebuffer) with a resolution of 1024x768, on SeaBIOS +
> SeaVGABIOS:
>
> - Boot menus (GRUB, Syslinux) look
On Tue, Jun 07, 2022 at 09:37:21AM -0600, Kevin Locke wrote:
> Hi All,
>
> With QEMU 7.0.0 and SeaBIOS 1.16.0, virtual machines with a PCIe
> graphics card connected to a PCIe Root Port, rather than the Root
> Complex, as recommended by the QEMU PCI Express Guidelines[1], are
> unable to use VESA
On Wed, Apr 27, 2022 at 10:24:16AM -0400, Kevin O'Connor wrote:
> On Wed, Apr 27, 2022 at 09:22:02AM +0200, Gerd Hoffmann wrote:
> > v4:
> > - make calculations more robust.
> >
> > v3:
> > - check size instead of end address.
>
> The series looks good
Hi,
> I do think your new v4 version of the code is easier to understand
> though.
Great, that was precisely the point of doing a v4 ;)
take care,
Gerd
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to
In case there is enough memory installed use a large ZoneHigh.
Signed-off-by: Gerd Hoffmann
---
src/config.h | 3 ++-
src/malloc.c | 14 +-
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/src/config.h b/src/config.h
index 93c8dbc2d530..9abe355b6c47 100644
--- a/src
Use the variable highram_size instead of the BUILD_MAX_HIGHTABLE #define
for the ZoneHigh size. Initialize the new variable with the old #define,
so behavior does not change.
This allows to easily adjust the ZoneHigh size at runtime in a followup
patch.
Signed-off-by: Gerd Hoffmann
---
src
v4:
- make calculations more robust.
v3:
- check size instead of end address.
Gerd Hoffmann (2):
malloc: use variable for ZoneHigh size
malloc: use large ZoneHigh when there is enough memory
src/config.h | 3 ++-
src/malloc.c | 23 ++-
2 files changed, 16 insertions
> > if (!highram_start) {
> > +if (e - s > BUILD_MAX_HIGHTABLE * 16)
> > +highram_size = BUILD_MAX_HIGHTABLE;
> > u32 newe = ALIGN_DOWN(e - highram_size, MALLOC_MIN_ALIGN);
> > if (newe <= e && newe >= s) {
> >
Use the variable highram_size instead of the BUILD_MAX_HIGHTABLE #define
for the ZoneHigh size. Initialize the new variable with the old #define,
so behavior does not change.
This allows to easily adjust the ZoneHigh size at runtime in a followup
patch.
Signed-off-by: Gerd Hoffmann
---
src
In case there is enough memory installed use a large ZoneHigh.
Signed-off-by: Gerd Hoffmann
---
src/config.h | 3 ++-
src/malloc.c | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/config.h b/src/config.h
index 93c8dbc2d530..9abe355b6c47 100644
--- a/src/config.h
v3:
- check size instead of end address.
Gerd Hoffmann (2):
malloc: use variable for ZoneHigh size
malloc: use large ZoneHigh when there is enough memory
src/config.h | 3 ++-
src/malloc.c | 18 +++---
2 files changed, 13 insertions(+), 8 deletions(-)
--
2.35.1
> > u32 s = en->start, e = end;
> > if (!highram_start) {
> > +if (e > BUILD_MAX_HIGHTABLE * 16)
> > +highram_size = BUILD_MAX_HIGHTABLE;
> > u32 newe = ALIGN_DOWN(e - highram_size, MALLOC_MIN_ALIGN);
> > if (newe <= e && newe
Gerd Hoffmann (2):
malloc: use variable for ZoneHigh size
malloc: use large ZoneHigh when there is enough memory
src/config.h | 3 ++-
src/malloc.c | 18 +++---
2 files changed, 13 insertions(+), 8 deletions(-)
--
2.35.1
In case there is enough memory installed use a large ZoneHigh.
Signed-off-by: Gerd Hoffmann
---
src/config.h | 3 ++-
src/malloc.c | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/config.h b/src/config.h
index 93c8dbc2d530..9abe355b6c47 100644
--- a/src/config.h
Use the variable highram_size instead of the BUILD_MAX_HIGHTABLE #define
for the ZoneHigh size. Initialize the new variable with the old #define,
so behavior does not change.
This allows to easily adjust the ZoneHigh size at runtime in a followup
patch.
Signed-off-by: Gerd Hoffmann
---
src
Bump BUILD_MAX_HIGHTABLE from 256k to 1M to avoid running
out of memory with very large smbios tables.
Signed-off-by: Gerd Hoffmann
---
src/config.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/config.h b/src/config.h
index 93c8dbc2d530..f4b19898a1f0 100644
--- a/src
Hi,
> Unused space gets returned to the e820 map before boot, so there is
> generally not much harm in increasing it.
Ah, missed that detail ...
So simply bumping it to 1M or so is fine and does not waste memory?
> What's using the ZoneHigh region that is so large that we need to
> expand
the fallbacks into dead code.
This patch flips the default for the config options controlling
the fallback smbios and acpi tables from 'Yes' to 'No'. Eventually
the code will be removed altogether at some point in the future.
Signed-off-by: Gerd Hoffmann
---
src/Kconfig | 8
1 file changed, 4
This reverts commit a638acfa4cc772b42093c8bfe55669829a641293.
Not needed any more now that ZoneHigh is expanded on demand.
Signed-off-by: Gerd Hoffmann
---
src/pmm.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/src/pmm.c b/src/pmm.c
index 28b253b2d33c..640341472486 100644
When running out of memory in ZoneHigh go alloc memory from ZoneTmpHigh,
add it as reserved to the e820 map and expand ZoneHigh
Signed-off-by: Gerd Hoffmann
---
src/malloc.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/malloc.c b/src/malloc.c
index 3733855caf2c
.
Gerd Hoffmann (2):
malloc: add on demand ZoneHigh expansion support
Revert "pmm: use tmp zone on oom"
src/malloc.c | 16
src/pmm.c| 13 -
2 files changed, 16 insertions(+), 13 deletions(-)
-
> > diff --git a/src/fw/mptable.c b/src/fw/mptable.c
> > index 47385cc..3a7b02f 100644
> > --- a/src/fw/mptable.c
> > +++ b/src/fw/mptable.c
>
> If you look at the top of that file you'll see the notice:
>
> // DO NOT ADD NEW FEATURES HERE. (See paravirt.c / biostables.c instead.)
>
> The
ndard PCI configuration access
Series looks good to me.
Reviewed-by: Gerd Hoffmann
take care,
Gerd
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
On Thu, Jan 27, 2022 at 05:43:32PM +0100, Paul Menzel wrote:
> Dear SeaBIOS folks,
>
>
> with the latest NVMe fixes, would it make sense to tag a 1.15.1 release?
>
> The 1.16.0 release is planned for end of February, as far as I understand
> it. Maybe that could be moved up two weeks?
Going
On Thu, Jan 13, 2022 at 11:21:18AM -0500, Kevin O'Connor wrote:
> On Thu, Jan 13, 2022 at 11:56:35AM +0100, Gerd Hoffmann wrote:
> > Hi,
> >
> > > 2. Commit the smbios 3 changes (and pcie-pci-bridge changes) and
> > >release v1.15.0 in early January.
>
On Thu, Jan 13, 2022 at 12:06:06PM +0100, Paul Menzel wrote:
> Dear Gerd,
>
>
> Am 13.01.22 um 11:56 schrieb Gerd Hoffmann:
>
> > > 2. Commit the smbios 3 changes (and pcie-pci-bridge changes) and
> > > release v1.15.0 in early January.
> >
> >
Hi,
> 2. Commit the smbios 3 changes (and pcie-pci-bridge changes) and
>release v1.15.0 in early January.
I think all pending patches have been applied meanwhile.
So time to enter 1.15 freeze and release in ~2 weeks?
take care,
Gerd
___
Add all three 4k modes. Computer monitors typically use
the first one (3840x2160).
Add 16 and 32 bpp variants. 24bpp is dead these days, and
software which is so old that still uses those modes most
likely doesn't even know what 4k is.
Signed-off-by: Gerd Hoffmann
---
vgasrc/svgamodes.c | 8
large
> request into multiple smaller ones.
>
> Signed-off-by: Andy Pei
> Signed-off-by: Ding Limin
Reviewed-by: Gerd Hoffmann
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
On Tue, Dec 07, 2021 at 09:31:07AM +0800, Andy Pei wrote:
> abstract virtio-blk queue operation to form a function named
> virtio_blk_op_one_segment
>
> Signed-off-by: Andy Pei
> Signed-off-by: Ding Limin
Reviewed-by: Gerd Hoffmann
On Tue, Dec 07, 2021 at 09:31:06AM +0800, Andy Pei wrote:
> according to virtio spec, add feature VIRTIO_BLK_F_SIZE_MAX
> and VIRTIO_BLK_F_SEG_MAX parse to virtio blk driver.
>
> Signed-off-by: Andy Pei
> Signed-off-by: Ding Limin
Reviewed-by
On Mon, Dec 06, 2021 at 01:38:16PM +, Pei, Andy wrote:
> Reply in line
>
>
> > +} else {
> > +struct vring_list *p_sg = [1];
>
> Not needed, you can just use sg[1].addr
> Andy: I used to think sg[1]. Length, but I am not sure. Could you please
> tell me why sg[1]. Length is
> +} else {
> +struct vring_list *p_sg = [1];
Not needed, you can just use sg[1].addr
> +void *p = op->buf_fl;
> +u16 count = op->count;
> +
> +while (count > blk_num_max) {
while (count > 0) {
u16 blk_num = min(count, blk_num_max);
On Fri, Dec 03, 2021 at 01:22:43PM +0800, Andy Pei wrote:
> abstract virtio-blk queue operation to form a function named
> virtio_blk_op_one_segment
>
> Signed-off-by: Andy Pei
> Signed-off-by: Ding Limin
Reviewed-by: Gerd Hoffmann
Hi,
> +if (features & max_segment_size)
> +vdrive->drive.max_segment_size =
> +vp_read(>device, struct virtio_blk_config, size_max);
> +else
> +vdrive->drive.max_segment_size = 0;
Not needed, there is a memset(0) for the complete vdrive
Hi,
> I'm not sure what you'd prefer to do with the SeaBIOS release though.
> We have a couple of high-level options:
>
> 1. Release v1.15.0 this week without these changes (tag 64f37cc5).
>
> 2. Commit the smbios 3 changes (and pcie-pci-bridge changes) and
>release v1.15.0 in early
On Tue, Nov 30, 2021 at 05:23:52AM +, Pei, Andy wrote:
> Hi Gerd,
>
> Yes, you are right.
> I think reading these two config register is fine during init and align with
> the virtio blk spec.
It is not wrong but also pointless.
> In the near future, we will working on some related work on
Hi,
> Reason for this is that commit [1] didn't take into account
> pcie-pci-bridge, marking bridge as non hotpluggable instead of
> handling it as possibly SHPC capable bridge.
> Fix issue by checking if pcie-pci-bridge is SHPC capable and
> if it is mark it as hotpluggable.
Fix #1
> With
On Fri, Nov 26, 2021 at 04:06:23PM +0800, Andy Pei wrote:
> according to virtio spec, add feature VIRTIO_BLK_F_SIZE_MAX
> and VIRTIO_BLK_F_SEG_MAX parse to virtio blk driver.
Why is this needed? The code never actually uses max_segment_size and
max_segments (other than logging the values) ...
Hi,
> > Damn. Support for smbiod 3.0 fall completely through the cracks:
> >
> > https://www.mail-archive.com/seabios@seabios.org/msg12438.html
> >
> > The qemu-side changes have long been merged (except for flipping the
> > default to 3.0), but I didn't pay attention so the seabios patches
On Thu, Oct 21, 2021 at 09:43:39PM -0400, Kevin O'Connor wrote:
> On Thu, Oct 21, 2021 at 03:01:23PM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > It's been a while since the last release, we have some nice but
> > unreleased bits in the master branch (tpm and nvme i
On Thu, Oct 21, 2021 at 09:43:39PM -0400, Kevin O'Connor wrote:
> On Thu, Oct 21, 2021 at 03:01:23PM +0200, Gerd Hoffmann wrote:
> > Hi,
> >
> > It's been a while since the last release, we have some nice but
> > unreleased bits in the master branch (tpm and nvme i
Hi,
It's been a while since the last release, we have some nice but
unreleased bits in the master branch (tpm and nvme improvements
for example), time for a new release I think.
How about freeze in a week, release by roughly mid-november?
take care,
Gerd
Hi,
> > IMHO this must be fixed in vhost-user-scsi no matter what. Host
> > processes crashing in case the guest doesn't behave as expected
> > is a security problem.
> Yes, the backend should be fixed.
> However, we may as well initialize these two vqs, because other virtio
> frontend drivers
On Tue, Aug 31, 2021 at 08:23:39PM +0800, Li Feng wrote:
> Currently, virtio-scsi doesn't support any control or event message, this
> patch
> adds the basic initialization.
>
> Some backends need this feature, like dpdk/spdk vhost-user backend.
>
> Reproduce:
> 1. Start spdk vhost-user-scsi
Hi,
> -static void
> +int
> nvme_probe_ns(struct nvme_ctrl *ctrl, u32 ns_idx, u8 mdts)
Why drop the static?
> -/* Populate namespace IDs */
> +/* Find first active namespace. */
> int ns_idx;
> -for (ns_idx = 0; ns_idx < ctrl->ns_count; ns_idx++) {
> -
> > [ just back from vacation ]
> >
> > Well, assuming the first namespace is the one you want actually boot
> > from. Which I expect is the common case, but who knows how people
> > use their machines ...
> >
> > IIRC there is some work in progress to add bootorder support for
> > namespaces,
On Thu, Jul 01, 2021 at 02:20:47PM +, Thanos Makatos wrote:
> From: Thanos Makatos
>
> The current implementation keeps probing NVMe namespaces even if an
> active one has been found. This is unnecessary and most importantly
> results in memory allocation failure if the are more than a few
On Tue, Jul 13, 2021 at 05:32:27AM -0400, Elliot Killick via SeaBIOS wrote:
> Add support for all high-definition and quad extended graphics array
> resolutions as listed on Wikipedia.
>
> https://en.wikipedia.org/wiki/Graphics_display_resolution
>
> Signed-off-by: Elliot Killick
> ---
>
On Wed, Jun 02, 2021 at 11:31:46AM -0400, Kevin O'Connor wrote:
> On Mon, May 31, 2021 at 07:55:28AM +0200, Gerd Hoffmann wrote:
> > BUILD_MIN_BIOSTABLE reserves space in the f-segment. Some data
> > structures -- for example disk drives known to seabios -- must be
> > store
On Mon, May 31, 2021 at 08:02:52AM +0200, Paul Menzel wrote:
> Dear Gerd,
>
>
> Am 31.05.21 um 07:55 schrieb Gerd Hoffmann:
>
> Small nit for the commit message summary: Increa*s*e.
>
> > BUILD_MIN_BIOSTABLE reserves space in the f-segment. Some data
> > stru
or
larger in size. 32bit code is moved off in that case, so we have more
room in the f-segment then.
Signed-off-by: Gerd Hoffmann
---
scripts/layoutrom.py | 4
1 file changed, 4 insertions(+)
diff --git a/scripts/layoutrom.py b/scripts/layoutrom.py
index 6616721d1b58..abebf0211fa9 100755
of
the reservation can be configured at build time. Default is 8k for bios
images being 256k or larger in size (32bit code is moved off then so we
have more room in the f-segment), 2k (current value) otherwise.
Signed-off-by: Gerd Hoffmann
---
Makefile | 2 +-
scripts/layoutrom.py
Instead of allocating a big array upfront go probe the namespaces and
only allocate an nvme_namespace struct for those namespaces which are
actually active.
Signed-off-by: Gerd Hoffmann
---
src/hw/nvme-int.h | 1 -
src/hw/nvme.c | 40
2 files
Signed-off-by: Gerd Hoffmann
---
src/hw/nvme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/hw/nvme.c b/src/hw/nvme.c
index f64eba880a83..746e4682d318 100644
--- a/src/hw/nvme.c
+++ b/src/hw/nvme.c
@@ -297,11 +297,11 @@ nvme_probe_ns(struct nvme_ctrl *ctrl, u32
Gerd Hoffmann (2):
nvme: improve namespace allocation
nvme: drive desc should not include the newline
src/hw/nvme-int.h | 1 -
src/hw/nvme.c | 44 ++--
2 files changed, 18 insertions(+), 27 deletions(-)
--
2.31.1
Hi,
> >> No, tested with qemu.git. Plus the code the patch touches in
> >> nvme_controller_enable comes after where the alloc failure happens.
> >
> > I haven't upstreamed the relevant QEMU patch yet as I'm waiting for the
> > SeaBIOS part to be reviewed first.
> >
> > The alloc failure can
Hi,
> > No, tested with qemu.git. Plus the code the patch touches in
> > nvme_controller_enable comes after where the alloc failure happens.
>
> I haven't upstreamed the relevant QEMU patch yet as I'm waiting for
> the SeaBIOS part to be reviewed first.
Just send it to qemu-devel. The usual
Hi,
> Where can I file this so it doesn't get lost?
> Anyone know a qemu command line workaround?
Does
https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/2Q7NPH7TJNHK6JGPHQL7755HILO23ISN/
help?
take care,
Gerd
___
SeaBIOS
Hi,
> > As far I know there is no policy on that written down somewhere. In
> > general we try avoid breaking backward compatibility (and thus requiring
> > lockstep updates). But maintaining backward compatibility has a cost
> > too, so this isn't set in stone.
>
> Sure, but backwards
On Thu, May 20, 2021 at 01:55:12PM -0400, Kevin O'Connor wrote:
> On Tue, May 04, 2021 at 07:43:35PM -0400, Elliot Killick via SeaBIOS wrote:
> > Hi,
> >
> > This patch series adds support for all HD and QXGA resolutions.
> >
> > I've taken Gerd's advice on the v1 patch and split the formatting
On Thu, May 20, 2021 at 06:09:55PM +, Peter Stuge wrote:
> Arthur Heymans wrote:
> > This breaks compatibility with very old coreboot build (build before
> > fb5d5b16 "2015-07-14, cbtable: describe boot media").
>
> Is that really acceptable in SeaBIOS master at some random time?
As far I
Add config option for BUILD_MIN_BIOSTABLE. Default is 8k for bios
images being 256k or larger in size, 2k (current value) otherwise.
Signed-off-by: Gerd Hoffmann
---
Makefile | 2 +-
scripts/layoutrom.py | 3 ++-
src/Kconfig | 7 +++
3 files changed, 10 insertions
Hi,
> Regarding the failure cases, will things break during build
> (BUILD_MIN_BIOSTABLE=16K), e.g:
>
> [seabios] Error! ROM doesn't fit (135584 > 131072)
> [seabios]You have to either increase the size (CONFIG_ROM_SIZE)
> [seabios]or turn off some features (such as hardware support
Hi,
> Is QEMU still shipping images limited to 128KiB? If so, that would be
> another restriction.
Ah, right, maybe that was the reason.
Yes, there still is a 128k variant, for backward compatibility with qemu
version 1.7 & older.
Backward compatibility support for qemu version 1.3 & older
Hi,
> > > I changed the number of namespaces my controller reports to 1 and it
> > > worked fine. Is there an easy way to get around this or do I have to
> > > fix the code? I haven't looked at the code in detail, but I think we
> > > don't have to allocate the array of namespaces in
> > >
Hi,
> > -#define VBE_DISPI_MAX_XRES 2560
> > -#define VBE_DISPI_MAX_YRES 1600
> > +#define VBE_DISPI_MAX_XRES 3840
> > +#define VBE_DISPI_MAX_YRES 2160
> > +{ 0x199, { MM_DIRECT, 3840, 2160, 32, 8, 16, SEG_GRAPH } },
> I'm not sure
On Thu, Apr 01, 2021 at 12:42:18PM +, Thanos Makatos wrote:
> I'm using SeaBIOS (b0d61ec) to boot from a virtual NVMe controller that has
> relatively many namespaces (64). The exact error is :
>
> /3ff9f000\ Start thread
> |3ff9f000| Searching bootorder for: /pci@i0cf8/*@6
>
Hi,
> > > > Add a config option for fast device init (i.e. skip non-bootable
> > > > devices). This optimization breaks boot in some rare configurations,
> > > > specifically in case the boot loader needs access to secondary disks.
>
> Unfortunately, I missed the initial email due to seabios
> |7ffa7000| WARNING - Unable to allocate resource at vp_find_vq:301!
> I wonder how can I diagnose this problem and how to deal with?
seabios runs out of memory.
You can try update to 1.14 and use "qemu -boot strict=on". seabios will
only initialize devices with bootindex then, which should
On Tue, Mar 23, 2021 at 04:31:41PM +0100, Paul Menzel wrote:
> Dear Gerd,
>
>
> On 2021-03-23 15:18, Gerd Hoffmann wrote:
> > Add a config option for fast device init (i.e. skip non-bootable
> > devices). This optimization breaks boot in some rare configurations,
Add a config option for fast device init (i.e. skip non-bootable
devices). This optimization breaks boot in some rare configurations,
specifically in case the boot loader needs access to secondary disks.
Signed-off-by: Gerd Hoffmann
---
src/boot.c | 2 ++
src/Kconfig | 10 ++
2 files
On Sun, Feb 28, 2021 at 02:22:53PM -, Yiguang Chen wrote:
> Most time, When a vm with seabios start. The bios will display such info:
> -
> Seabios (version rel-1.13-0 ..)
> Machine UUID ...
>
> IPXE ..
>
> IPXE..
>
> Booting from DVD/CD...
> Press any key to boot from CD or DVD.
>
1 - 100 of 1248 matches
Mail list logo
