On Mon, 18 Dec 2023 22:48:18 GMT, Kim Barrett wrote:
>> @eme64 Is it feasible to split this up to solve each of the problems you
>> identify in stages? There is also overlap here with JDK-8319709 IIUC. Thanks.
>
>> @dholmes-ora These are the "parts":
>>
>> 1. initialize up to capacity vs
On Fri, 1 Dec 2023 07:56:04 GMT, Emanuel Peter wrote:
> Before this patch, we always initialized the GrowableArray up to its
> `capacity`, and not just up to `length`. This is problematic for a few
> reasons:
>
> - It is not expected. `std::vector` also only initializes the elements up to
>
On Tue, 19 Dec 2023 04:09:47 GMT, Alex Menkov wrote:
>> src/hotspot/share/services/heapDumper.cpp line 1647:
>>
>>> 1645: static bool is_vthread_mounted(oop vt) {
>>> 1646: return JvmtiEnvBase::get_JavaThread_or_null(vt) != nullptr;
>>> 1647: }
>>
>> It doesn't seem appropriate to
On Tue, 19 Dec 2023 01:17:10 GMT, David Holmes wrote:
>> HeapDumper dumps virtual threads in 2 places:
>> - dumping platform threads (mounted virtual threads are dumped as separate
>> thread object);
>> - dumping heap objects when the object is `java.lang.VirtualThread`.
>>
>> In the 2nd case
On Fri, 1 Dec 2023 07:56:04 GMT, Emanuel Peter wrote:
> Before this patch, we always initialized the GrowableArray up to its
> `capacity`, and not just up to `length`. This is problematic for a few
> reasons:
>
> - It is not expected. `std::vector` also only initializes the elements up to
>
On Sat, 16 Dec 2023 02:15:16 GMT, Alex Menkov wrote:
> HeapDumper dumps virtual threads in 2 places:
> - dumping platform threads (mounted virtual threads are dumped as separate
> thread object);
> - dumping heap objects when the object is `java.lang.VirtualThread`.
>
> In the 2nd case mounted
On Fri, 15 Dec 2023 10:49:56 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`,
HeapDumper dumps virtual threads in 2 places:
- dumping platform threads (mounted virtual threads are dumped as separate
thread object);
- dumping heap objects when the object is `java.lang.VirtualThread`.
In the 2nd case mounted virtual threads should be skipped (as they are already
dumped
On Mon, 18 Dec 2023 11:12:23 GMT, Joachim Kern wrote:
>> src/hotspot/os/aix/porting_aix.cpp line 1097:
>>
>>> 1095: }
>>> 1096:
>>> 1097: pthread_mutex_lock(_handletable_mutex);
>>
>> You can make your life a lot easier by defining an RAII object at the start
>> of the file:
>>
>>
On Mon, 18 Dec 2023 10:25:57 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hotspot/os/aix/os_aix.cpp line 1113:
>
>>
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote:
>> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map:
>> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a
>> file name.
>>
>> `jcmd PID help Compiler.perfmap` shows the following usage.
>>
>>
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote:
>> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map:
>> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a
>> file name.
>>
>> `jcmd PID help Compiler.perfmap` shows the following usage.
>>
>>
On Fri, 15 Dec 2023 19:43:36 GMT, Alex Menkov wrote:
> The fix updated JdwpAllowTest to test negative scenarios (debugger tries to
> attach from not allowed address).
>
> MaskTest ctor incorrectly calculates prefix length for negative tests and
> test main() calls `positiveTest` instead of
On Mon, 18 Dec 2023 10:35:48 GMT, Joachim Kern wrote:
>> src/hotspot/os/aix/porting_aix.cpp line 990:
>>
>>> 988: if (env == nullptr) {
>>> 989: // no LIBPATH, try with LD_LIBRARY_PATH
>>> 990: env = getenv("LD_LIBRARY_PATH");
>>
>> Is LD_LIBRARY_PATH a thing on AIX? I thought it is
On Thu, 21 Sep 2023 20:43:56 GMT, Yi-Fan Tsai wrote:
> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map:
> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a
> file name.
>
> `jcmd PID help Compiler.perfmap` shows the following usage.
>
>
>
On Mon, 18 Dec 2023 10:19:24 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hotspot/os/aix/porting_aix.cpp line 1101:
>
On Mon, 18 Dec 2023 10:25:50 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hotspot/os/aix/os_aix.cpp line 30:
>
>> 28:
On Mon, 18 Dec 2023 10:16:07 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hotspot/os/aix/porting_aix.cpp line 1005:
>
On Mon, 18 Dec 2023 11:30:59 GMT, Joachim Kern wrote:
>> On AIX, repeated calls to dlopen referring to the same shared library may
>> result in different, unique dl handles to be returned from libc. In that it
>> differs from typical libc implementations that cache dl handles.
>>
>> This
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`,
On Mon, 18 Dec 2023 10:54:31 GMT, Thomas Stuefe wrote:
>> Yes it is, It's the fallback if LIBPATH is not defined
>
> In that case there may be errors in other places, since so far we assumed its
> either one or the other, but not both. Example:
>
>
> On AIX, repeated calls to dlopen referring to the same shared library may
> result in different, unique dl handles to be returned from libc. In that it
> differs from typical libc implementations that cache dl handles.
>
> This causes problems in the JVM with code that assumes equality of
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote:
>> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map:
>> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a
>> file name.
>>
>> `jcmd PID help Compiler.perfmap` shows the following usage.
>>
>>
> On AIX, repeated calls to dlopen referring to the same shared library may
> result in different, unique dl handles to be returned from libc. In that it
> differs from typical libc implementations that cache dl handles.
>
> This causes problems in the JVM with code that assumes equality of
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote:
>> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map:
>> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a
>> file name.
>>
>> `jcmd PID help Compiler.perfmap` shows the following usage.
>>
>>
On Sat, 16 Dec 2023 04:36:57 GMT, Denghui Dong wrote:
>> Hi,
>>
>> Could I have a review of this patch?
>>
>> In the current implementation, HeapDumpBeforeFullGC/AfterFullGC will
>> generate dumps for every FGC, increasing the risk of disk full.
>>
>> This patch introduces a new option
On Sat, 16 Dec 2023 17:25:20 GMT, Alan Bateman wrote:
> A lot of test changes have accumulated in the loom repo, this includes both
> new tests and updates to existing tests. Some of these updates can be brought
> to the main line. This update brings over:
>
> - The existing tests for pinning
On Mon, 18 Dec 2023 11:30:59 GMT, Joachim Kern wrote:
>> On AIX, repeated calls to dlopen referring to the same shared library may
>> result in different, unique dl handles to be returned from libc. In that it
>> differs from typical libc implementations that cache dl handles.
>>
>> This
On Mon, 18 Dec 2023 07:49:04 GMT, David Holmes wrote:
>> Before this patch, we always initialized the GrowableArray up to its
>> `capacity`, and not just up to `length`. This is problematic for a few
>> reasons:
>>
>> - It is not expected. `std::vector` also only initializes the elements up
On Mon, 18 Dec 2023 10:14:42 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hotspot/os/aix/porting_aix.cpp line 990:
>
>>
On Mon, 18 Dec 2023 10:06:34 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hotspot/os/aix/porting_aix.cpp line 934:
>
>>
On Fri, 15 Dec 2023 11:57:51 GMT, Joachim Kern wrote:
>> On AIX, repeated calls to dlopen referring to the same shared library may
>> result in different, unique dl handles to be returned from libc. In that it
>> differs from typical libc implementations that cache dl handles.
>>
>> This
On Mon, 18 Dec 2023 09:55:30 GMT, Johan Sjölen wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - David's review comments - reduce if blocks and release the array outside
>> if block
>> - David's review comment -
On Fri, 15 Dec 2023 06:08:33 GMT, David Holmes wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - David's review comments - reduce if blocks and release the array outside
>> if block
>> - David's review comment -
> Can I please get a review of this change which proposes to improve the code
> in `get_user_name_slow` function, which is used to identify the target JVM
> owner's user name? This addresses https://bugs.openjdk.org/browse/JDK-8321971.
>
> As noted in that JBS issue, in its current form, the
On Thu, 14 Dec 2023 10:13:51 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to improve the code
> in `get_user_name_slow` function, which is used to identify the target JVM
> owner's user name? This addresses https://bugs.openjdk.org/browse/JDK-8321971.
>
>
On Mon, 18 Dec 2023 07:49:04 GMT, David Holmes wrote:
>> Before this patch, we always initialized the GrowableArray up to its
>> `capacity`, and not just up to `length`. This is problematic for a few
>> reasons:
>>
>> - It is not expected. `std::vector` also only initializes the elements up
37 matches
Mail list logo
