On Tue, 27 Feb 2024 07:48:00 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library
> J2SE agent does not start and throws error when it tries to find the shared
> library ibm_16_am.
> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
> fails.It fails to identify the shared library ibm_16_am.a shared archive file
> on AIX.
> Hence we are providing a
On Mon, 26 Feb 2024 20:21:55 GMT, Magnus Ihse Bursie wrote:
>> The idea of setting up general "toolchains" in the native build was good,
>> but it turned out that we really only need a single toolchain, with a single
>> twist: if it should use CC or CPP to link. This is better described by a
On Mon, 26 Feb 2024 11:24:13 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library
On Mon, 26 Feb 2024 11:24:13 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library
On Tue, 26 Dec 2023 14:15:17 GMT, Taizo Kurashige wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is no such
>> typo in this repository. So
On Tue, 26 Dec 2023 14:15:17 GMT, Taizo Kurashige wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop
>> documentation, but I couldn't find that. I confirmed that there is no such
>> typo in this repository. So
On Mon, 26 Feb 2024 20:20:31 GMT, Jiangli Zhou wrote:
> Please help review this trivial fix for resolving `ld: error: duplicate
> symbol: closeDescriptors` when static linking with both libjdwp and libjava,
> thanks.
This pull request has now been integrated.
Changeset: 0901dede
Author:
On Tue, 27 Feb 2024 00:34:49 GMT, Serguei Spitsyn wrote:
>> Jiangli Zhou has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address plummercj's comment and make forkedChildProcess static.
>> - Revert
On Wed, 31 Jan 2024 14:22:44 GMT, Kevin Walls wrote:
> Introduce the jcmd "VM.debug" to implement access to a useful set of the
> established debug.cpp utilities, with "jcmd PID VM.debug subcommand ...".
>
> Not recommended for live production use. Calling these "debug" utilities,
> and not
On Mon, 26 Feb 2024 22:55:06 GMT, Jiangli Zhou wrote:
>> Please help review this trivial fix for resolving `ld: error: duplicate
>> symbol: closeDescriptors` when static linking with both libjdwp and libjava,
>> thanks.
>
> Jiangli Zhou has updated the pull request incrementally with two
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Mon, 26 Feb 2024 23:50:11 GMT, Chris Plummer wrote:
> Looks good.
Thanks for the quick review, @plummercj.
-
PR Comment: https://git.openjdk.org/jdk/pull/18013#issuecomment-1965539618
On Mon, 26 Feb 2024 22:55:06 GMT, Jiangli Zhou wrote:
>> Please help review this trivial fix for resolving `ld: error: duplicate
>> symbol: closeDescriptors` when static linking with both libjdwp and libjava,
>> thanks.
>
> Jiangli Zhou has updated the pull request incrementally with two
On Wed, 21 Feb 2024 21:13:36 GMT, Alex Menkov wrote:
> VirtualMachine.loadAgentPath/loadAgentLibrary can fail with
> AgentLoadException in 2 cases:
> - attach listener returns error; in the case the exception is thrown from
> HotSpotVirtualMachine.processCompletionStatus (called from
>
On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn wrote:
> This enhancement replaces uses of NULL with nullptr in the XML-description
> files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
> `hotspot/share/prims/jvmti*.xls`.
>
> The following files are auto-generated from
On Mon, 26 Feb 2024 20:37:45 GMT, Chris Plummer wrote:
>> Jiangli Zhou has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address plummercj's comment and make forkedChildProcess static.
>> - Revert
On Mon, 26 Feb 2024 22:15:00 GMT, Jiangli Zhou wrote:
>> src/java.base/unix/native/libjava/childproc.h line 134:
>>
>>> 132: int closeSafely(int fd);
>>> 133: int isAsciiDigit(char c);
>>> 134: int closeDescriptors(void);
>>
>> It seems that most of the APIs in this file should be static. I
On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn wrote:
> This enhancement replaces uses of NULL with nullptr in the XML-description
> files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
> `hotspot/share/prims/jvmti*.xls`.
>
> The following files are auto-generated from
> Please help review this trivial fix for resolving `ld: error: duplicate
> symbol: closeDescriptors` when static linking with both libjdwp and libjava,
> thanks.
Jiangli Zhou has updated the pull request incrementally with two additional
commits since the last revision:
- Address
On Mon, 26 Feb 2024 20:40:52 GMT, Chris Plummer wrote:
>> Please help review this trivial fix for resolving `ld: error: duplicate
>> symbol: closeDescriptors` when static linking with both libjdwp and libjava,
>> thanks.
>
> src/java.base/unix/native/libjava/childproc.h line 134:
>
>> 132:
On Mon, 26 Feb 2024 20:20:31 GMT, Jiangli Zhou wrote:
> Please help review this trivial fix for resolving `ld: error: duplicate
> symbol: closeDescriptors` when static linking with both libjdwp and libjava,
> thanks.
src/java.base/unix/native/libjava/childproc.h line 134:
> 132: int
Please help review this trivial fix for resolving `ld: error: duplicate symbol:
closeDescriptors` when static linking with both libjdwp and libjava, thanks.
-
Commit messages:
- Make closeDescriptors() as static function in
src/java.base/unix/native/libjava/childproc.c and
On Sat, 24 Feb 2024 06:04:40 GMT, Julian Waters wrote:
>> The idea of setting up general "toolchains" in the native build was good,
>> but it turned out that we really only need a single toolchain, with a single
>> twist: if it should use CC or CPP to link. This is better described by a
>>
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
> specific argument to SetupNativeCompilation, LANG := C++ or
On Sat, 24 Feb 2024 11:22:17 GMT, Dmitry Chuyko wrote:
>> Compiler Control (https://openjdk.org/jeps/165) provides method-context
>> dependent control of the JVM compilers (C1 and C2). The active directive
>> stack is built from the directive files passed with the
>>
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
> specific argument to SetupNativeCompilation, LANG := C++ or
On Wed, 20 Dec 2023 07:29:07 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to improve the code
>> in `get_user_name_slow` function, which is used to identify the target JVM
>> owner's user name? This addresses
>>
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Fri, 23 Feb 2024 04:29:47 GMT, Kim Barrett wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/Deallocate/dealloc001/dealloc001.cpp
>> line 28:
>>
>>> 26: #include "jvmti.h"
>>> 27: #include "agent_common.hpp"
>>> 28: #include "JVMTITools.h"
>>
>> Why don't you change all of these together?
On Sun, 25 Feb 2024 06:32:20 GMT, Thomas Stuefe wrote:
>> Suchismith Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>>remove space
>
> src/hotspot/os/aix/os_aix.cpp line 1173:
>
>> 1171: char* const pointer_to_dot =
> J2SE agent does not start and throws error when it tries to find the shared
> library ibm_16_am.
> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
> fails.It fails to identify the shared library ibm_16_am.a shared archive file
> on AIX.
> Hence we are providing a
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
>
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
>
34 matches
Mail list logo