Re: [sheepdog] [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-30 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 18:50, Eric Blake wrote: On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. As mentioned elsewhere in the thread, this states 'what' but not 'why'; adding a

Re: [sheepdog] [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-30 Thread Vladimir Sementsov-Ogievskiy
29.04.2020 18:50, Eric Blake wrote: On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. As mentioned elsewhere in the thread, this states 'what' but not 'why'; adding a

Re: [sheepdog] [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-29 Thread Eric Blake
On 4/27/20 3:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. As mentioned elsewhere in the thread, this states 'what' but not 'why'; adding a bit more of the 'why' can be useful

Re: [sheepdog] [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 1:26 PM, Vladimir Sementsov-Ogievskiy wrote: 27.04.2020 13:11, Philippe Mathieu-Daudé wrote: On 4/27/20 10:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. This doesn't

Re: [sheepdog] [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
27.04.2020 13:11, Philippe Mathieu-Daudé wrote: On 4/27/20 10:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. This doesn't seem a strong justification... If I understand correctly

Re: [sheepdog] [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
27.04.2020 11:23, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- include/block/block_int.h | 4 ++--

Re: [sheepdog] [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Philippe Mathieu-Daudé
On 4/27/20 10:23 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. This doesn't seem a strong justification... If I understand correctly this patch, it is safer to use positive signed

[sheepdog] [PATCH v2 02/17] block: use int64_t as bytes type in tracked requests

2020-04-27 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Convert tracked requests now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Hajnoczi --- include/block/block_int.h | 4 ++-- block/io.c| 11 ++- 2 files changed,