Re: [sigrok-devel] Pull request libsigrokdecode "Fix sdcard_sdd: Decode commands always as command" #127

2025-12-09 Thread Ladislav Laska
Hi! I'll have a look and review the PR. Dan, before you go and write a completely new system, I'd like to note there already is a test suite for the decoders that would have covered this: https://github.com/sigrokproject/sigrok-test https://github.com/sigrokproject/sigrok-dumps Or did you have

Re: [sigrok-devel] Pull request libsigrokdecode "Fix sdcard_sdd: Decode commands always as command" #127

2025-12-09 Thread Dan Horák
On Mon, 8 Dec 2025 19:01:16 +0100 Helge Kruse via sigrok-devel wrote: > Hi, > > I have found a problem with the SD card decoder while implementing a > driver stack for an embedded platform. When the SD card doesn't send a > response, the host controller sends the next command after a timeout.

[sigrok-devel] Pull request libsigrokdecode "Fix sdcard_sdd: Decode commands always as command" #127

2025-12-08 Thread Helge Kruse via sigrok-devel
Hi, I have found a problem with the SD card decoder while implementing a driver stack for an embedded platform. When the SD card doesn't send a response, the host controller sends the next command after a timeout. But the decoder expects a response and decodes the next token as a response. Th

Re: [sigrok-devel] Pull request for fixing wrong calculation in vc96.c

2025-02-19 Thread ttnp--- via sigrok-devel
Hi to All, sorry for exhuming that old issue. But still the problem handled in that Pull Request remains unsolved. The patch was overlooked by harper23 and Soeren Apel and finally found to be acceptable. Is there something what has to be done (what I can/have to do) to fix that issue? Or would

[sigrok-devel] Pull request to libsigrok - adding support for ISF input format

2024-02-06 Thread Filip Koseček
Hello, I added an input module to libsigrok which handles input files in Tektronix ISF format that is used by Tektronix devices ( https://www.tek.com/en/support/faqs/what-format-isf-file). The main advantage of this format is that data is loaded faster than, for instance, data stored in a CSV file

[sigrok-devel] Pull request for fixing wrong calculation in vc96.c

2023-11-24 Thread ttnp--- via sigrok-devel
Hi All, I created a new pull request which fixes the wrong calculation for in vc96.c https://github.com/sigrokproject/libsigrok/pull/234 ___ sigrok-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/si

Re: [sigrok-devel] Pull Request: Driver for Uni-t UT8802E

2023-07-30 Thread Konrad Tagowski
Hello everyone, I created a driver for the UNI-T UT8803e bench multimeter and made a pull request on GitHub. I made improving the code after review for the Uni-t ut8802e driver. Please review the code again. Best regards, Konrad On 6/20/23 15:00, Konrad Tagowski wrote: Hello everyone,

[sigrok-devel] Pull Request: Driver for Uni-t UT8802E

2023-06-20 Thread Konrad Tagowski
Hello everyone, I am glad to support this project. It is awesome. I created a driver for the Uni-t UT8802E bench multimeter. My git repository: https://github.com/KonradTagowski/libsigrok. I created a pull request in the draft. Please make a review. I'm also working on a driver for Uni-t UT

[sigrok-devel] [PULL REQUEST] libsigrok SDL2 soundcard oscilloscope support

2023-05-11 Thread Tomas Mudrunka
Hello, more than year ago i've posted PR adding SDL2 support to libsigrok github page: https://github.com/sigrokproject/libsigrok/pull/185 I wanted to ask if there are some chances of geting that merged. Previously i've managed to get stuff merged to sigrok via github, but nowadays there seem

Re: [sigrok-devel] Pull request for libsigrok driver for Raspberry PI PICO rp2040 board

2022-03-02 Thread Shawn Walker
I've been working with jr-oss on some code cleanup and other updates, and now have official pull request here: https://github.com/sigrokproject/libsigrok/pull/181 On Mon, Feb 21, 2022 at 5:18 PM Shawn Walker wrote: > All, > I've developed a libsigrok driver for the Raspberry PI PICO board. > Gi

Re: [sigrok-devel] Pull request for libsigrok driver for Raspberry PI PICO rp2040 board

2022-02-22 Thread guy colin
Hi Shawn This sounds very good news. I'm eager to test it (currently I cannot because not at home) I had previously tried this project: https://www.hackster.io/markkomus/using-a-raspberry-pi-pico-as-a-logic-analyzer-with-pulseview-e12543 But as said by the author himself it was quite limited becau

[sigrok-devel] Pull request for libsigrok driver for Raspberry PI PICO rp2040 board

2022-02-21 Thread Shawn Walker
All, I've developed a libsigrok driver for the Raspberry PI PICO board. Github repo https://github.com/pico-coder/sigrok-pico/tree/main/raspberrypi-pico Features: -3 ADC channels (up to 500khz), 21 digital channels (up to 120Mhz) -Hardware based digital only trigger -Software based triggering -Uses

[sigrok-devel] Pull Request => std: Remove device closure in acquisition stop

2019-09-16 Thread Abdulkerim Altuntas
Hello. We have been using your libraries for a long time and we are very thankful to you for developing such a nice project! Recently, in our test setups we ran into an error and upon investigation of your libsigrok project we think that we might have found an issue. In our test setups we use two

Re: [sigrok-devel] Pull request sigrok-firmware-fx2lafw: bugfix in hantek 6022BL voltage range selection #2

2019-06-01 Thread Uwe Hermann
Hi, On Tue, Apr 23, 2019 at 09:37:37PM +0200, Martin Homuth-Rosemann wrote: > I have found this pull request, which has been available for some time now: > https://github.com/sigrokproject/sigrok-firmware-fx2lafw/pull/2/commits/1e4f9813bd749eb091430ab4347091020445442e > Please check if this patch

[sigrok-devel] Pull request sigrok-firmware-fx2lafw: bugfix in hantek 6022BL voltage range selection #2

2019-04-23 Thread Martin Homuth-Rosemann
Hi, I have found this pull request, which has been available for some time now: https://github.com/sigrokproject/sigrok-firmware-fx2lafw/pull/2/commits/1e4f9813bd749eb091430ab4347091020445442e Please check if this patch can be pulled. Martin ___ sig

Re: [sigrok-devel] Pull request: driver for RDTech DPS/DPH series PSUs

2018-04-07 Thread Uwe Hermann
Hi, On Sun, Feb 18, 2018 at 05:30:57PM +1000, James Churchill wrote: > I've just written a new driver for the programmable powersupplies sold by > RDTech (http://rdtech.aliexpress.com/) and the branch is available at > https://github.com/pelrun/libsigrok/tree/rdtech. Quick update for book-keeping

[sigrok-devel] Pull request for siglent-sds driver

2018-02-24 Thread Marchel H
Hello all, I have added the Average function and fixed a problem with the vdiv, which was hard-coded to value 2 in the header read code. Also bus 1120 is solved where the timebase setting was incorrectly parsed. Please checkout commit ce4f6f28348fe8e8b7b8066f0a47c28aa8ba59e7 @ https://github.com/

[sigrok-devel] Pull request: driver for RDTech DPS/DPH series PSUs

2018-02-18 Thread James Churchill
Hi! I've just written a new driver for the programmable powersupplies sold by RDTech (http://rdtech.aliexpress.com/) and the branch is available at https://github.com/pelrun/libsigrok/tree/rdtech. They use Modbus RTU over USB or BT serial, and I've needed to make a couple of minor changes to the

Re: [sigrok-devel] Pull request Siglent SDS series driver

2018-02-11 Thread Uwe Hermann
Hi, On Sun, Feb 11, 2018 at 10:42:59PM +0100, Uwe Hermann wrote: > Actually, nevermind. Gerhard Sittig has done some rebasing etc. already > so the driver will be merged shortly. No need to update anything on your > side for the moment. And the driver is merged now, thanks a lot! There are still

Re: [sigrok-devel] Pull request Siglent SDS series driver

2018-02-11 Thread Uwe Hermann
Hi, On Sat, Feb 10, 2018 at 06:18:46PM +0100, Uwe Hermann wrote: > Independently of that, could you please Actually, nevermind. Gerhard Sittig has done some rebasing etc. already so the driver will be merged shortly. No need to update anything on your side for the moment. Cheers, Uwe. -- http:

Re: [sigrok-devel] Pull request Siglent SDS series driver

2018-02-10 Thread Uwe Hermann
Hi Marchel, On Sat, Feb 03, 2018 at 02:14:52PM +0100, Marchel H wrote: > Hello Sigrok team, > > The following driver is ready in its basic functions for release. The code > is up2date with the latest build of libsigrok 0.5.0. Great, thanks a lot for writing this driver! I'll be able to test this

[sigrok-devel] Pull request Siglent SDS series driver

2018-02-03 Thread Marchel H
Hello Sigrok team, The following driver is ready in its basic functions for release. The code is up2date with the latest build of libsigrok 0.5.0. The code is available on github: https://github.com/marchelh/libsigrok Commit with SHA 4285c67266313bc7590fbc6e163c7cad7cb94f4d is the clean commit.

Re: [sigrok-devel] Pull request - cleanup udev rules

2017-11-22 Thread Uwe Hermann
Hi, On Sun, Oct 29, 2017 at 09:19:20PM +0100, Stefan Bruens wrote: > contrib: rename udev rules for correct rule ordering on systemd systems > contrib: remove duplicate rules for fx2lafw DSOs > contrib: Split device access policy from the device database > cleanup udev part

[sigrok-devel] Pull request - cleanup udev rules

2017-10-29 Thread Stefan Bruens
The following changes since commit 095eba19d6ddda139f01eeb36e81f06bd2d91748: hantek-6xxx: use lower MAX_PACKET_SIZE on Windows (2017-10-19 15:01:06 +0200) are available in the Git repository at: https://github.com/StefanBruens/libsigrok.git udev_rules_cleanup for you to fetch changes up to

Re: [sigrok-devel] [PULL REQUEST] baylibre-acme: Performance improvements.

2015-07-06 Thread Uwe Hermann
Hi, On Wed, Jul 01, 2015 at 10:50:21AM +0200, Bartosz Golaszewski wrote: > 2015-07-01 0:13 GMT+02:00 Uwe Hermann : > > + tspec.it_interval.tv_nsec = (10L / devc->samplerate); > > > > You could use SR_HZ_TO_NS() here, I think (not strictly needed, but it > > might be it a bit clearer)

Re: [sigrok-devel] [PULL REQUEST] baylibre-acme: Performance improvements.

2015-07-01 Thread Bartosz Golaszewski
2015-07-01 0:13 GMT+02:00 Uwe Hermann : > + tspec.it_interval.tv_nsec = (10L / devc->samplerate); > > You could use SR_HZ_TO_NS() here, I think (not strictly needed, but it > might be it a bit clearer). > Done, you can pull from the same branch. Best regards, Bartosz Golaszewski --

Re: [sigrok-devel] [PULL REQUEST] baylibre-acme: Performance improvements.

2015-06-30 Thread Uwe Hermann
Hi, On Tue, Jun 30, 2015 at 03:44:21PM +0200, Bartosz Golaszewski wrote: > We worked together with Daniel on some improvements of ACME's > performance. Daniel authored two nice patches: one that makes use of > sysfs attribute's seekability to avoid doing an open/close on each > measurement and one

[sigrok-devel] [PULL REQUEST] baylibre-acme: Performance improvements.

2015-06-30 Thread Bartosz Golaszewski
Hi Uwe, please consider pulling: http://git.baylibre.com/pub/acme/libsigrok/acme-pull We worked together with Daniel on some improvements of ACME's performance. Daniel authored two nice patches: one that makes use of sysfs attribute's seekability to avoid doing an open/close on each meas

Re: [sigrok-devel] Pull Request

2012-03-11 Thread Bert Vermeulen
On 03/04/2012 11:58 PM, Joel Holdsworth wrote: > Hi, Can I have a pull for both sigrok and fx2lafw This and Matt Ranostay's pull request were done. Great contributions, thanks! -- Bert [email protected] email/xmpp

Re: [sigrok-devel] Pull Request

2012-03-09 Thread Joel Holdsworth
Hi Matt, I've got a pull request pending as well. It seems that Uwe does most of the pull requests, but he hasn't been around much this week. I should think our work will go in over the weekend. Joel On 09/03/12 18:32, Matt Ranostay wrote: Can I have a pull on my Sigrok tree? It contains bug

[sigrok-devel] Pull Request

2012-03-09 Thread Matt Ranostay
Can I have a pull on my Sigrok tree? It contains bug fixes for the OLS device. git://github.com/mranostay/sigrok.git : public Thanks, Matt -- Virtualization & Cloud Management Using Capacity Planning Cloud computing make

[sigrok-devel] Pull Request

2012-03-04 Thread Joel Holdsworth
Hi, Can I have a pull for both sigrok and fx2lafw git://github.com/joelholdsworth/fx2lafw.git : public git://github.com/joelholdsworth/sigrok.git : public Thanks Joel -- Virtualization & Cloud Management Using Capacity P

[sigrok-devel] Pull request

2012-02-25 Thread Joel Holdsworth
Can I issue a pull request for my initial work on the fx2lafw driver: https://github.com/joelholdsworth/sigrok/commits/public At the moment it detects the presence of fx2lafw devices - i.e. the CWAV USBee AX. The next step is firmware loading, command and control. Comments and criticisms are we

[sigrok-devel] Pull request.

2011-01-10 Thread Daniel Ribeiro
The following changes since commit 9fb461d1e1e82817fd13dad006a6f1b581a70bdc: Daniel Ribeiro (1): Merge branch 'master' of git://sigrok.git.sourceforge.net/gitroot/sigrok/sigrok are available in the git repository at: git://github.com/drwyrm/sigrok.git master Daniel Ribeiro (5):