[Spacewalk-devel] making log statment debug as it was intended to be

2009-03-17 Thread jmrodri
Please wrap the log.debug() with if (log.isDebugEnabled()) {... log.debug(); } jesus Sent to you by jmrodri via Google Reader: making log statment debug as it was intended to be via Fedora Hosted Git Repositories - spacewalk.git/rss log by Justin Sherrill jsher...@redhat.com on 3/16/09 making

[Spacewalk-devel] Made page sizes configurable so that one can now not rely on schema every time we...

2009-03-17 Thread Jesus Rodriguez
I've got a number of issues with this commit. Config.java * what problem are we solving that we need the list of page sizes in the config file? * please remove the getPageSizes() and getDefaultPageSize() methods from Config. Based on the javadoc comment they are used by

[Spacewalk-devel] 484879 - warn if you are connection using ISS to parent which do not know ISS

2009-03-17 Thread Pradeep Kilambi
Looking at your commit: http://git.fedoraproject.org/git/?p=spacewalk.git;a=commitdiff;h=c587ddb52000ea2ec2635bccf6729cdf7f6dc0a2 You're missing the fact that even with CFG.ISS_PARENT set, we can still talk to RHN with my commandline url options. Which means you'll be raising an iss error

Re: [Spacewalk-devel] making log statment debug as it was intended to be

2009-03-17 Thread Jesus M. Rodriguez
It avoids the creation of the debug string, over time this can get costly. We had a huge problem with this at my last job and we improved performance quite a bit by simply wrapping our debug logs in an if statement. the JIT pretty much compiles out the block at runtime. We are NOT that good at