[Spacewalk-devel] [Fwd: [Bug 490438] Review Request: rhn-client-tools - Support programs and libraries for Red Hat Network or Spacewalk]

2009-03-24 Thread Miroslav Suchý
Do we have reason why we have python code in /usr/share/rhn and not in %{python_sitelib}? Original Message Subject: [Bug 490438] Review Request: rhn-client-tools - Support programs and libraries for Red Hat Network or Spacewalk Date: Tue, 24 Mar 2009 08:02:28 -0400 From:

Re: [Spacewalk-devel] Automatic commit of package [spacewalk-java] release [0.5.36-1]

2009-03-24 Thread Michael Mraka
Miroslav Suchý wrote: % Commit 65c8964a14bd176a9141df0af0d86e654f73e690 % I do not see tag attached to this commit. Jesus did you forget git push % --tags, or it is my problem? Same for commit 981acb2b45e3650270e60d218bf442650f638092 Automatic commit of package [smartpm] release [0.1-0].

Re: [Spacewalk-devel] [Fwd: [Bug 490438] Review Request: rhn-client-tools - Support programs and libraries for Red Hat Network or Spacewalk]

2009-03-24 Thread Pradeep Kilambi
Miroslav Suchý wrote: Do we have reason why we have python code in /usr/share/rhn and not in %{python_sitelib}? Well as the guidelines say, we have our python *modules* (eg: rhnlib) in python_sitelib. I don't really consider our server/client code to be a utility module that belongs to

[Spacewalk-devel] PGPORT: Query tagging commits to cherry-pick into master

2009-03-24 Thread Devan Goodwin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I think cherry-picking these commits would help reduce the conflicts in the pgsql branch: 22fae9993b39a35f882131ce7ae5c4b9024744cf 5e147ad535493c8209b28cb3c8d21bc1e3a78893 9cad4715e3e3945a886f0581b1eb6f00d2468620

[Spacewalk-devel] [Fwd: 489616 - update NewChannelHelper.clone to create channel family, if none exists]

2009-03-24 Thread Jason Dobies
http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=f811e59d177e6922c54eea65123d9782b324bac7 Can we move the second lookup to inside of the if? That way, since most times the family will not be null we remove the duplicate load from the normal case. ChannelFamily family

Re: [Spacewalk-devel] [Fwd: 489616 - update NewChannelHelper.clone to create channel family, if none exists]

2009-03-24 Thread Brad Buckingham
Jason Dobies wrote: http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=f811e59d177e6922c54eea65123d9782b324bac7 Can we move the second lookup to inside of the if? That way, since most times the family will not be null we remove the duplicate load from the normal case.

Re: [Spacewalk-devel] Re: 491762 - ProfileManager.epochcmp incorrectly handling null epoch value

2009-03-24 Thread Jesus M. Rodriguez
agreed, we've become quite lax with our unit tests (present company included). jesus 2009/3/24 Mike McCune mmcc...@redhat.com: http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=1aad37f79cfc242aa4a3752f46b0d70f4a1bef4c this simple fix screams for a unit test Mike -- Mike

[Spacewalk-devel] 474774 - updating deps for jfree

2009-03-24 Thread jmrodri
Did we update the spacewalk-java.spec file? Sent to you by jmrodri via Google Reader: 474774 - updating deps for jfree via Fedora Hosted Git Repositories - spacewalk.git/rss log by Mike McCune mmcc...@gmail.com on 3/24/09 474774 - updating deps for jfree - [DH] java/ivy.xml Things you can do

Re: [Spacewalk-devel] PGPORT: Query tagging commits to cherry-pick into master

2009-03-24 Thread Jesus M. Rodriguez
On Tue, Mar 24, 2009 at 1:20 PM, Devan Goodwin dgood...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I think cherry-picking these commits would help reduce the conflicts in the pgsql branch: 22fae9993b39a35f882131ce7ae5c4b9024744cf