Did we update the spacewalk-java.spec file?
Sent to you by jmrodri via Google Reader: 474774 - updating deps for
jfree via Fedora Hosted Git Repositories - spacewalk.git/rss log by
Mike McCune mmcc...@gmail.com on 3/24/09 474774 - updating deps for
jfree
- [DH] java/ivy.xml
Things you can do
Great this looks good. One thing, can you add javadoc comments to the
EnforcementDoclet?
right now it says TestDoclet which is less than useful.
jesus
Sent to you by jmrodri via Google Reader: adding the enforce task to
the checkstyle task, and making our calls to javadoc a... via Fedora
Hosted
Please wrap the log.debug() with if (log.isDebugEnabled()) {...
log.debug(); }
jesus
Sent to you by jmrodri via Google Reader: making log statment debug as
it was intended to be via Fedora Hosted Git Repositories -
spacewalk.git/rss log by Justin Sherrill jsher...@redhat.com on
3/16/09 making
Why do we have to pass in the /rhn/ to the url here where we don't on
the others?
jesus
Sent to you by jmrodri via Google Reader: Fixed a iprange issue where
the iprange delete URLs weren't being correctly rendered via Fedora
Hosted Git Repositories - spacewalk.git/rss log by Partha Aji
p
together. That avoids
having to
loop through the list simply to change the keys.
Also, remove the empty // line.
jesus
Sent to you by jmrodri via Google Reader: 489792- fixing incorrect api
return types via Fedora Hosted Git Repositories - spacewalk.git/rss log
by Justin Sherrill jsher
why is this a BAD query? I think this was done on purpose to return the
issue_date as date.
jesus
Sent to you by jmrodri via Google Reader: 489775 - fixing listERrata
api due to bad query via Fedora Hosted Git Repositories -
spacewalk.git/rss log by Justin Sherrill jsher...@redhat.com on
3/12
final.
Actually where is it even being used? you set it to 0 in the ctor but
never increment or use it.
jesus
Sent to you by jmrodri via Google Reader: adding taskomatic task to
regenerate deleted kickstart wizard files via Fedora Hosted Git
Repositories - spacewalk.git/rss log by Justin Sherrill
If isInterpreter() returns a string you could've used
StringUtils.isEmpty(kss.getInterpreter()) to avoid
having to do the null and empty checks as isEmpty does both for you.
jesus
Sent to you by jmrodri via Google Reader: 481180 - update
KickstartFormatter to not include --interpetter
entry, then one for the constant.
Am I the only one this annoys?
jesus
Sent to you by jmrodri via Google Reader: 487563 - switching
take_snapshots to enable_snapshots via Fedora Hosted Git Repositories -
spacewalk.git/rss log by Justin Sherrill jlshe...@mac.lan on 3/4/09
487563 - switching
(suite) {
protected void setUp() throws Exception {
oneTimeSetup();
}
protected void tearDown() throws Exception {
oneTimeTeardown();
}
};
return wrapper;
}
That allows you to avoid Junit's default call of setUp() and tearDown()
after each testXXX run.
jesus
Sent to you by jmrodri via Google
wrong commit message format :)
remove the bz and add a dash :)
483802 - Changed mode and ownership of /etc/rhn to match those which
The proper format makes my life easier when building the packages and
creating
changelog entries.
jesus
Sent to you by jmrodri via Google Reader: bz483802
.
jesus
Sent to you by jmrodri via Google Reader: 486982 - fixed ise on
software upgrade list via Fedora Hosted Git Repositories -
spacewalk.git/rss log by Justin Sherrill jsher...@redhat.com on
2/24/09 486982 - fixed ise on software upgrade list
- [DH]
java/code/src/com/redhat/rhn/frontend/dto
new build? um that's not very descriptive :)
jesus
Sent to you by jmrodri via Google Reader: new build via Fedora Hosted
Git Repositories - spacewalk.git/rss log by Pradeep Kilambi
pkila...@redhat.com on 2/24/09 new build
- [DH] java/spacewalk-java.spec
Things you can do from here:
- Subscribe
Thanks for the cleanup, and yes final is unnecessary on static methods
because you can't override them.
jesus
Sent to you by jmrodri via Google Reader: Random cleanup while I was in
here. Final is unnecessary for static methods; technica... via Fedora
Hosted Git Repositories - spacewalk.git/rss
reuse? what are you mad? Kidding, great work.
jesus
Sent to you by jmrodri via Google Reader: Extracted out the custom name
generation so it can be used outside of creating a... via Fedora Hosted
Git Repositories - spacewalk.git/rss log by Jason Dobies
jason.dob...@redhat.com on 2/23/09
Did I miss these in my checkin?
jesus
Sent to you by jmrodri via Google Reader: checkstyle for new license
format via Fedora Hosted Git Repositories - spacewalk.git/rss log by
Mike McCune mmcc...@gmail.com on 2/23/09 checkstyle for new license
format
- [DH]
java/code/src/com/redhat/rhn/domain
This commit has the wrong commit message in it.
Sent to you by jmrodri via Google Reader: 481766: Added the example
text as require dint he bug .. Forgot abt it... via Fedora Hosted Git
Repositories - spacewalk.git/rss log by Partha Aji p...@redhat.com on
2/15/09 481766: Added the example text
17 matches
Mail list logo
