Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-02-04 Thread Maximilian Meister
On 01/29/2014 02:22 PM, Michael Mraka wrote: I see :(, I was not aware of it. Anyway I'd still prefer not to use javascript if not necessary. So in this particular case I'd replace html:password with direct html input tag: input type=password name=desiredpassword class=form-control

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-02-04 Thread Michael Mraka
Maximilian Meister wrote: % Hi Michael, % % i changed the patch. So no additional javascript. % % * I replaced the struts tag with the standard html input tag to use % the placeholder attribute % * Some changes to the logic in % spacewalk-pwstrength-handler.js:updateTickIcon() % * Johannes

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-01-29 Thread Michael Mraka
Maximilian Meister wrote: % Hi, % % after the password strength meter went through, I have another enhancement % related to the password field. % On the edit user page, there are placeholders in the password fields. % The placeholders are plain *'s, so if I add some characters after % the

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-01-29 Thread Maximilian Meister
On 01/29/2014 10:35 AM, Michael Mraka wrote: Hello Maximilian, I think there's an easier way to do it in a plain html without new javascript file. If you replace input type=password name=desiredpassword maxlength=32 value=** class=form-control with input type=password

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-01-29 Thread Maximilian Meister
On 01/29/2014 01:19 PM, Maximilian Meister wrote: Hi Michael, I have tried this in my first attempt, but the html:password struts tag doesn't accept the attribute placeholder=**. to reformulate my statement a bit, the html:password struts tag doesn't know any placeholder attribute.

Re: [Spacewalk-devel] [PATCH] Adding a password placeholder check when editing a user.

2014-01-29 Thread Michael Mraka
Maximilian Meister wrote: % On 01/29/2014 01:19 PM, Maximilian Meister wrote: % % Hi Michael, % % I have tried this in my first attempt, but the html:password % struts tag doesn't accept the attribute placeholder=**. % % to reformulate my statement a bit, the html:password struts tag %