Re: [Spacewalk-devel] [PATCH] Added NULL checks in setMaxFlex() and setMaxMembers()
On Thu, Jan 27, 2011 at 10:07:57AM +0530, Paresh Mutha wrote: Hello, I am proposing a patch which includes NULL checks for setMaxFlex() and setMaxMembers() in ChannelOverview.java. Without that, in few cases where maxFlex or maxMembers were null, it led to NullPointerException and page https://server.example.com/rhn/admin/multiorg/OrgSoftwareSubscriptions.do?oid=orgid failed with an ISE. We already have a bugzilla created for RHN Satellite v5.4 - https://bugzilla.redhat.com/show_bug.cgi?id=671450 Paresh, did you investigate why (in which situation) does the setMaxFlex and/or setMaxMembers get called with null? Shouldn't/couldn't we handle this on the caller's side, rather than in the setter? -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Added NULL checks in setMaxFlex() and setMaxMembers()
Yes but couldn't reach to any conclusion. In reply to your query, I just posted a comment in the satellite bugzilla - https://bugzilla.redhat.com/show_bug.cgi?id=671450#c6 - Paresh On 01/27/2011 01:19 PM, Jan Pazdziora wrote: On Thu, Jan 27, 2011 at 10:07:57AM +0530, Paresh Mutha wrote: Hello, I am proposing a patch which includes NULL checks for setMaxFlex() and setMaxMembers() in ChannelOverview.java. Without that, in few cases where maxFlex or maxMembers were null, it led to NullPointerException and page https://server.example.com/rhn/admin/multiorg/OrgSoftwareSubscriptions.do?oid=orgid failed with an ISE. We already have a bugzilla created for RHN Satellite v5.4 - https://bugzilla.redhat.com/show_bug.cgi?id=671450 Paresh, did you investigate why (in which situation) does the setMaxFlex and/or setMaxMembers get called with null? Shouldn't/couldn't we handle this on the caller's side, rather than in the setter? ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] (contribution) ZYpp-based Spacewalk client for SUSE systems
Hi guys, The following code allows a openSUSE/SUSE system (= 11.4/Factory) to talk to a Spacewalk-compatible server. We pushed the source code to this repository: http://gitorious.org/opensuse/spacewalk-testsuite-base This is SUSE specific. We could keep it in gitorious.org/opensuse, but if you think spacewalk's git /client/suse is a better place, please let us know! Other patches will follow. Regards, -- Duncan Mac-Vicar P. - Novell® Making IT Work As One™ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] Password with less than minlength characters accepted
Hello,
There seems to be a bug in the Spacewalk Java code that allows a user
to set whatever password regardless of any errors (e.g. length
minlength), as long as the desired and confirm password are equal. It
is even possible to set a user's password to the empty string, which
results in not being able to login anymore after sign out! Attached is
a patch that fixes the problem.
Greetings,
Johannes Renner
--
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
From 57bac09f19795e5fc4c21514da4ac20bef9cc79d Mon Sep 17 00:00:00 2001
From: Johannes Renner jren...@suse.de
Date: Tue, 18 Jan 2011 15:58:23 +0100
Subject: [PATCH] Password with less than minlength characters accepted
---
.../frontend/action/user/UserEditActionHelper.java | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/java/code/src/com/redhat/rhn/frontend/action/user/UserEditActionHelper.java b/java/code/src/com/redhat/rhn/frontend/action/user/UserEditActionHelper.java
index 79529b4..68f6ce0 100644
--- a/java/code/src/com/redhat/rhn/frontend/action/user/UserEditActionHelper.java
+++ b/java/code/src/com/redhat/rhn/frontend/action/user/UserEditActionHelper.java
@@ -45,12 +45,13 @@ public abstract class UserEditActionHelper extends RhnAction {
form.get(UserActionHelper.DESIRED_PASS))) {
String pw = (String)form.get(UserActionHelper.DESIRED_PASS);
String conf = (String)form.get(UserActionHelper.DESIRED_PASS_CONFIRM);
-if (pw.equals(conf)) {
-targetUser.setPassword(pw);
-}
-else {
+if (!pw.equals(conf)) {
errors.add(ActionMessages.GLOBAL_MESSAGE,
- new ActionMessage(error.password_mismatch));
+new ActionMessage(error.password_mismatch));
+}
+else if (errors.isEmpty()) {
+//Set the password only if there are no errors at all
+targetUser.setPassword(pw);
}
}
--
1.7.1
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] (contribution) ZYpp-based Spacewalk client for SUSE systems
On 01/27/2011 04:14 PM, Duncan Mac-Vicar P. wrote: We pushed the source code to this repository: http://gitorious.org/opensuse/spacewalk-testsuite-base Sorry, the repo for this one is http://gitorious.org/opensuse/zypp-plugin-spacewalk -- Duncan Mac-Vicar P. - Novell® Making IT Work As One™ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] XML-RPC testsuite proposal
On 01/20/2011 04:07 PM, Jan Vlček wrote: Hi, I have started working on XML-RPC testsuite for Spacewalk as a part of my bachelor thesis. Few ideas are concentrated in following Google Docs document. https://docs.google.com/Doc?docid=0AfRvg1ST7uS2ZGMzOG5ycm5fMjZjZ3YzMzhmcwhl=csauthkey=CIWYod8F https://docs.google.com/Doc?docid=0AfRvg1ST7uS2ZGMzOG5ycm5fMjZjZ3YzMzhmcwhl=csauthkey=CIWYod8F Hi Jan, we just pushed our testsuite to the open and we already test some stuff over XML-RPC there. It is based on cucumber, so tests can be human readable steps, and the steps itself can be implemented with various strategies: we control a browser to test the user interface, or ssh to the target machine to test that processes are running, and use a XML-RPC client to test the API. It would make a lot of sense if you could help us improve it. A pending feature is to make the branding configurable so that it works with all flavors of Spacewalk (ie, Satellite, or our SUSE port), but that is not much work. -- Duncan Mac-Vicar P. - Novell® Making IT Work As One™ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] New records get born in RHNDAEMONSTATE
On 01/26/2011 08:51 AM, Jan Pazdziora wrote: On Tue, Jun 15, 2010 at 11:44:55AM -0400, Tomas Lestach wrote: Right, this approach is really not the best one. As this is a part of the taskomatic, I'll investigate it more in detail. I'd touch the code anyway. Not sure if somebody makes use out of the rhnDaemonState table content, but if not (what I suppose), I'd remove the table and the appropriate code. Tomáš, I've noticed that you've dropped the table for 1.3. However, doing git grep -i rhnDaemonState still shows it mentioned in the comments in multiple java/code/src/com/redhat/rhn/taskomatic/task/*.java files. Frankly, I'm a bit unsure that the comment refers to -- the whole class, the DISPLAY_NAME string, the getLogger ... Could you please look at it and clean it up or something? Done. Thanks for letting me know, Tomas -- Tomas Lestach RHN Satellite Engineering, Red Hat Thank you, ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Cannot find buildconf/build-props-${tomcat}.xml
On 01/09/2011 01:07 PM, Jan Pazdziora wrote:
On Sun, Jan 09, 2011 at 01:58:05PM +0800, Colin Coe wrote:
I've run into a problem with ant on SW v1.3 nightly and F14 (x86_64).
---
[coec@sw-ora java]$ ant all
Buildfile: build.xml
[echo] Importing buildconf/build-props-${tomcat}.xml
BUILD FAILED
/home/coec/git/spacewalk/java/build.xml:8: Cannot find
buildconf/build-props-${tomcat}.xml imported from
/home/coec/git/spacewalk/java/build.xml
Total time: 0 seconds
[coec@sw-ora java]$
---
Could someone point me in the right direction?
Looking at
java/spacewalk-java.spec
and its %build section, you should define
-Dtomcat=tomcat6
when running ant.
It's not required any more to define the tomcat version.
Removed in commit: e10fd990c9019ebd3fb5fffe3954ed48e20abeb9
Regards,
Tomas
--
Tomas Lestach
RHN Satellite Engineering, Red Hat
___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Spacewalk 1.3 delayed
Folks, we have hit an issue with recent change to Fedora 14 selinux-policy which became a blocker for the Spacewalk 1.3 release. We are working with the SELinux guys to resolve the issue but currently Spacewalk release is blocked. -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] (contribution) ZYpp-based Spacewalk client for SUSE systems
Duncan Mac-Vicar P. wrote: On 01/27/2011 04:14 PM, Duncan Mac-Vicar P. wrote: We pushed the source code to this repository: http://gitorious.org/opensuse/spacewalk-testsuite-base Sorry, the repo for this one is http://gitorious.org/opensuse/zypp-plugin-spacewalk Hi Duncan and Johannes, I find the proposed items - this is good news :) In general (such as spacecmd) and other chunks of work created outside of the core team we like to see steady growth/stability before agreeing to apply into our own git repo. Continued submissions of good quality patches to spacewalk in general can lead to direct commit access once we have confidence in providing that. This obviously would allow you to help resolve issues direct, along with sub-projects you'd like to help maintain in our own repos. Thank you for reaching out, give us some time to review the two submissions and determine if we agree merging into our code base sooner than later. Regards, Cliff ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] - fix typo in spacewalk-koan/spacewalkkoan/spacewalkkoan.py
On Thu, Jan 27, 2011 at 11:34:53PM -0200, Marcelo Moreira de Mello wrote: This proposed patch fixed a typo when importing subprocess module in spacewalkkoan.py Applied, thanks! -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
