On Tue, Nov 01, 2011 at 04:53:15PM +0100, Tomas Lestach wrote: > Great patch! > I committed it with minor changes (renamed scriptname to script_name > and scriptName) as > http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=be7996f4740fd642b1c92068ac96b8abfbd1f1b4 > Wonderful, that you've included also the schema upgrade scripts with > appropriate sha1s. :-)
I second the praise. The only tiny issue was with > >+++ > >b/schema/spacewalk/upgrade/spacewalk-schema-1.5-to-spacewalk-schema-1.6/101-add_rhnKickstartScript_scriptname.sql.postgresql > >@@ -0,0 +1,2 @@ > >+-- oracle equivalent source sha1 ebfe8df38b1935e67ea3ddd3d5937cef6de9ae91 > >+alter table rhnKickstartScript add column scriptname varchar2(40); where the PostgreSQL version of the upgrade script needs varchar, not varchar2. I've fixed it now. Thanks, -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
