Re: [Spacewalk-devel] [PATCH] Bug about cloned channels and errata

2012-03-07 Thread Tomas Lestach
I will find time for that in the next days and I can then come up with a new patch for that file after I verified the behavior. Great! Thank you Johannes, -- Tomas Lestach RHN Satellite Engineering, Red Hat Regards, Johannes ___ Spacewalk-devel

Re: [Spacewalk-devel] API Documentation patch review request

2012-03-07 Thread Michael Mraka
Steven Hardy wrote: % Hi All, % % I've got some trivial patches to commit for API documentation cleanups % and an addition to the spacewalk-repo-sync manpage. % % As these are outside of my normal area of contribution (spacecmd), can I % get review/approval/permission that I can go ahead and

Re: [Spacewalk-devel] [PATCH] Naming of cloned errata

2012-03-07 Thread Johannes Renner
On 03/06/2012 05:42 PM, Johannes Renner wrote: Hey, I want to propose a change concerning the names of cloned errata. Currently, names of cloned errata are generated like this: String clonedAdvisoryName = CL + published.getAdvisoryName().substring(3); String clonedAdvisory = CL +

[Spacewalk-devel] Exceptions, i18n and error messages

2012-03-07 Thread Duncan Mac-Vicar P.
I have been working on NewChannelHelper, CreateChannelCommand, ChannelSoftwareHandler and EditChannelAction. Right now NewChannelHelper does some verifying and implements cloning, while new channel creation is implemented in CreateChannelCommand. Basic validation is in two places,

Re: [Spacewalk-devel] Exceptions, i18n and error messages

2012-03-07 Thread Tomas Lestach
On Wednesday 07 of March 2012 13:43:53 Duncan Mac-Vicar P. wrote: I have been working on NewChannelHelper, CreateChannelCommand, ChannelSoftwareHandler and EditChannelAction. Right now NewChannelHelper does some verifying and implements cloning, while new channel creation is implemented in

Re: [Spacewalk-devel] API Documentation patch review request

2012-03-07 Thread Steven Hardy
Hi Michael, On Wed, 2012-03-07 at 10:10 +0100, Michael Mraka wrote: Steven Hardy wrote: % Hi All, % % I've got some trivial patches to commit for API documentation cleanups % and an addition to the spacewalk-repo-sync manpage. % % As these are outside of my normal area of contribution