Re: [Spacewalk-devel] [Spacewalk-list] SSM: Lock and Unlock Perl page port to JSP patch

2013-08-14 Thread Bo Maryniuk
Hi, Tomáš! On Tue, Aug 13, 2013 at 11:31:34AM +0200, Tomáš Kašpárek wrote: Selecting systems to lock or unlock as a subset of SSM looks bit weird. The purpose of SSM is that once you've selected a set of systems you work with them with them as with a batch. Take a look at other pages of SSM

Re: [Spacewalk-devel] [Spacewalk-list] SSM: Lock and Unlock Perl page port to JSP patch

2013-08-14 Thread Tomáš Kašpárek
Hello Bo, On 08/14/2013 11:58 AM, Bo Maryniuk wrote: Hi, Tomáš! On Tue, Aug 13, 2013 at 11:31:34AM +0200, Tomáš Kašpárek wrote: Selecting systems to lock or unlock as a subset of SSM looks bit weird. The purpose of SSM is that once you've selected a set of systems you work with them with them

[Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-14 Thread Silvio Moioli
Hi, Some downstream unit-testing highlighted a cause of non-determinism in the MethodUtil class that made tests fail during some runs but not all of them, without apparent changes in environment conditions. An example is MethodUtilTest.testCallMethod(), which sometimes failed with actual output

Re: [Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-14 Thread Tomáš Kašpárek
Hello Silvio! Your patch has been committed into spacewalk.git as 30c6bdf0fb24f440010556a697e74b383682b8a5. Thank you for your contribution! On 08/14/2013 03:17 PM, Silvio Moioli wrote: Hi, Some downstream unit-testing highlighted a cause of non-determinism in the MethodUtil class that

[Spacewalk-devel] Patch: adapt LocalizationServiceTest to run on all JDKs

2013-08-14 Thread Silvio Moioli
Hi, after bug 6609737[1] was fixed LocalizationServiceTest was updated to expect MEZ instead of CET as timezone for the German-locale timestamp format assertion. This is correct in those JDKs that contain a fix, but the test actually fails when run on some older JDKs. As we use IBM j9

Re: [Spacewalk-devel] [Spacewalk-list] SSM: Lock and Unlock Perl page port to JSP patch

2013-08-14 Thread Bo Maryniuk
On Wed, Aug 14, 2013 at 01:16:59PM +0200, Tomáš Kašpárek wrote: In this case I would at least except all of the checkboxes to be checked by default with option to unselect systems you don't want to have there. When I am working with SSM I am expecting that I am not forced to do any more