Re: [Spacewalk-devel] Patch: adapt LocalizationServiceTest to run on all JDKs

2013-08-15 Thread Tomas Lestach
Hello Silvio, I committed your patch as: https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=ec5abc7162569df9c4fc037a855905145a756d48 Thank you, -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To:

Re: [Spacewalk-devel] [Spacewalk-list] SSM: Lock and Unlock Perl page port to JSP patch

2013-08-15 Thread Tomáš Kašpárek
Hi Bo! I've committed your patch into spacewalk: https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=6b098c7d10ce49c1c0e4b3fdf9a4e5eed7a5a360 I've fixed one issue when unlocked systems had the same icon, independent on whether they're physical, virtual host or virtual guest, also

Re: [Spacewalk-devel] [Spacewalk-list] SSM: Lock and Unlock Perl page port to JSP patch

2013-08-15 Thread Bo Maryniuk
On Thu, Aug 15, 2013 at 10:58:16AM +0200, Tomáš Kašpárek wrote: I've fixed one issue when unlocked systems had the same icon, independent on whether they're physical, virtual host or virtual guest, also system icons had title Security errata so I removed that. Also the page had errata pages

Re: [Spacewalk-devel] [Spacewalk-list] SSM: Lock and Unlock Perl page port to JSP patch

2013-08-15 Thread Tomáš Kašpárek
On 08/15/2013 11:29 AM, Bo Maryniuk wrote: On Thu, Aug 15, 2013 at 10:58:16AM +0200, Tomáš Kašpárek wrote: I've fixed one issue when unlocked systems had the same icon, independent on whether they're physical, virtual host or virtual guest, also system icons had title Security errata so I

Re: [Spacewalk-devel] [Spacewalk-list] SSM: Lock and Unlock Perl page port to JSP patch

2013-08-15 Thread Bo Maryniuk
On Thu, Aug 15, 2013 at 11:32:11AM +0200, Tomáš Kašpárek wrote: I've also removed old Perl code in these two patches: https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=89dbf1c2dd5947253bb0af3433f7154f2b5185ae

Re: [Spacewalk-devel] patch to allow pgp signed rpms to be displayed in webui

2013-08-15 Thread Tomas Lestach
Hey Shannon, sorry it took me so long. I checked your patch and I rather completely removed the package key type limit. Actually possible key types are gpg, pgp, rsa and dsa and I see no reason, why there's the limit. And if anybody signs a package with a rsa key, it shall work by default.

Re: [Spacewalk-devel] Patch: improve MethodUtil determinism

2013-08-15 Thread Tomas Lestach
Hello Silvio, I reverted your patch from Spacewalk due to the negative impact on performance. As I wrote directly within the commit message displaying /rhn/channels/ChannelPackages.do page with 15 000 packages takes over 1.5 minutes with your patch in comparison to 3-4secs without the patch.

[Spacewalk-devel] SSM: Remote Command Perl page port to JSP patch

2013-08-15 Thread Bo Maryniuk
Hi! I am happy to introduce you another Perl page port to JSP: Remote Command in System Set Manager section. Differences from the Perl version: 1. Removed one more time confirmation. Page schedules script instantly. 2. Additional optional field Command label to put custom name for the label. 3.