[Spacewalk-devel] [PATCH] Make taskomatic max memory configurable via rhn.conf

2013-09-13 Thread Johannes Renner
Hello, the attached patch is supposed to enable users to override the taskomatic config option 'wrapper.java.maxmemory' via the global rhn.conf file. As the key I chose 'taskomatic.maxmemory', but feel free to propose something else in case you don't like it. Some of our users had issues with

Re: [Spacewalk-devel] [PATCH] Frontend monitoring tests: ensure a Monitoring Scout exists

2013-09-13 Thread Grant Gainey
- Original Message - Hi, In some frontend tests it is assumed that at least one Monitoring Scout exists, and those tests will fail if there is none. The proposed attached patch creates a test Monitoring Scout before any operation that requires one, thus eliminating this

Re: [Spacewalk-devel] [PATCH] DownloadActionTest: do not assume file to be downloaded exists

2013-09-13 Thread Grant Gainey
- Original Message - See attached patch. commit 24bbc79a3bdf7c73e6a6d27760177a1d78264fef Thanks for the contribution! G Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___

Re: [Spacewalk-devel] [PATCH] OrgHandlerTest: don't depend on a channel family with free entitlement slots

2013-09-13 Thread Grant Gainey
- Original Message - OrgHandlerTest apparently required an official Red Hat channel family with free slots: /** * Lookup an official Red Hat channel family with free slots. * Fail the test if none can be found. [...] private ChannelFamily lookupRedHatChannelFamily() { [...] }

Re: [Spacewalk-devel] [PATCH] VirtualGuestsActionTest: do not rely on query string parameter ordering

2013-09-13 Thread Grant Gainey
- Original Message - Hi, The attached patch relaxes an assertion condition not to require a certain query string parameter order, which was in fact not respected in our test environment. commit e101391876ab21505ec080b4af29f5feb5caeb6b Thanks for contributing! G Regards, --

[Spacewalk-devel] [PATCH] Add support for uploaded files in mocked requests, fix CryptoKeyCreateActionTest

2013-09-13 Thread Silvio Moioli
Hi, In our environment we noticed that CryptoKeyCreateActionTest was failing. AFAIU, failure was due to the fact that the mocked request did not have the uploaded file in it, that is, it was not a multipart request. In order to fix that I added some code to support multipart requests in

[Spacewalk-devel] [PATCH] SystemEntitlementsSetupActionTest: do not assume Org has virtualization entitlement

2013-09-13 Thread Silvio Moioli
SystemEntitlementsSetupActionTest was failing in our environment, as the tested Org missed a virtualization entitlement. The proposed attached patch fixes the problem. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From

[Spacewalk-devel] [PATCH] MethodsSetupActionTest: do not assume that method command exists

2013-09-13 Thread Silvio Moioli
See attached patch. Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany From d49e62923f34a64e5c2caac619d751d9e6010ac4 Mon Sep 17 00:00:00 2001 From: Silvio Moioli smoi...@suse.de Date: Mon, 9 Sep 2013 10:56:06 +0200 Subject: [PATCH 05/22]

Re: [Spacewalk-devel] [PATCH] RequestContext.buildPageLink: force parameter ordering

2013-09-13 Thread Grant Gainey
- Original Message - Hi, I noticed that buildPageLink() uses a HashMap to keep track of query string parameters. While this is perfectly okay from a web application point of view, it makes testing a little more difficult and in particular, RequestContextTest could break because it

Re: [Spacewalk-devel] [PATCH] TestUtils: use the same temporary filename for the same file

2013-09-13 Thread Grant Gainey
- Original Message - Hi, The attached patch fixes a previous contribution of mine to transparently get resources either from the filesystem or from a jar file. When accessing a file from a jar that files gets decompressed in a temporary location which name was generated at random

Re: [Spacewalk-devel] [PATCH] AuthFilterTest: mocked request object updated

2013-09-13 Thread Grant Gainey
- Original Message - AuthFilterTest was failing in our setup, apparently because the mocked request object was missing some methods that were added after the test itself was written. I added those methods and now it passes. See attached patch. commit

Re: [Spacewalk-devel] [PATCH] Added Oracle GPG key used to sign Oracle Linux 6 packages.

2013-09-13 Thread Avi Miller
On 13/09/2013, at 9:46 AM, Avi Miller avi.mil...@oracle.com wrote: So, I've now tried this on Oracle Linux 6 (x86_64) with both Oracle Database 11.2.0.4 and PostgreSQL (embedded) and both times, with the following changes: As a test, I downloaded the -release RPMs from OL4, OL5, OL6, CenOS

Re: [Spacewalk-devel] [PATCH] Make taskomatic max memory configurable via rhn.conf

2013-09-13 Thread Stephen Herr
On 09/13/2013 06:07 AM, Johannes Renner wrote: Hello, the attached patch is supposed to enable users to override the taskomatic config option 'wrapper.java.maxmemory' via the global rhn.conf file. As the key I chose 'taskomatic.maxmemory', but feel free to propose something else in case you

[Spacewalk-devel] [PATCH] Fix field length of erratum-advisory-name

2013-09-13 Thread Michael Calmer
Hi, in ISS export the field length in erratum-advisory-name is too short. The DB can store 100, while the code expect only 32. This will strip errata names to 32 chars and produce possible dupplicate key errors while it could store 100 chars without a problem. -- Regards Michael

Re: [Spacewalk-devel] [PATCH] junit tests: some logging cleanups

2013-09-13 Thread Grant Gainey
- Original Message - Hi, As previously discussed the new logging feature requires calling LoggingFactory.clearLogId() at the beginning of each transaction, and there were some places in test code where that was missing. I confirm that the latest patches from Grant actually

Re: [Spacewalk-devel] [PATCH] junit tests: do not rely on Cobbler

2013-09-13 Thread Grant Gainey
- Original Message - Hi, We propose some patches to avoid the junit testsuite to depend on Cobbler. With those, we are able to run all the tests using only a database instance seeded with the latest schema version. Details: commit bf05d8e0c6811a6bfed7f6c49091a56cabf8513d - patch

Re: [Spacewalk-devel] [PATCH] SystemHandlerTest: do not rely on hardcoded sequence ids

2013-09-13 Thread Grant Gainey
- Original Message - SystemHandlerTest was failing in our environment and, AFAIU, it expects that the underlying database will always return 1 as the id of a persisted test object. This is normally not the case, as the value is taken from a sequence and there is no code to ensure it

Re: [Spacewalk-devel] [PATCH] KickstartScriptActionTest: missing parameters added

2013-09-13 Thread Grant Gainey
- Original Message - Apparently some form parameters were missing and the test failed, at least in our environment. See attached patch. commit 12233d90d130eb739d80fbd53eb7c9dfc6493af7 Thanks for your contribution! G Regards, -- Silvio Moioli SUSE LINUX Products GmbH

Re: [Spacewalk-devel] [PATCH] MethodsSetupActionTest: do not assume that method command exists

2013-09-13 Thread Grant Gainey
- Original Message - See attached patch. commit 365c1834aa451aba3fb039f93034828dd2063c78 Thanks for your contribution! G Regards, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___

Re: [Spacewalk-devel] [PATCH] OrgSoftwareSubscriptionsActionTest: always create test channel families

2013-09-13 Thread Grant Gainey
- Original Message - In OrgSoftwareSubscriptionsActionTest, a test channel family is correctly set up for a test method but not in another. I simply moved common initialization code in setUp(). See attached patch. commit 6796a8be523752b212173c0ce4f14106a8d63f97 Thanks for your

Re: [Spacewalk-devel] [PATCH] Add support for uploaded files in mocked requests, fix CryptoKeyCreateActionTest

2013-09-13 Thread Grant Gainey
- Original Message - Hi, In our environment we noticed that CryptoKeyCreateActionTest was failing. AFAIU, failure was due to the fact that the mocked request did not have the uploaded file in it, that is, it was not a multipart request. In order to fix that I added some code to

Re: [Spacewalk-devel] [PATCH] VirtualGuestsActionTest: do not rely on translation messages

2013-09-13 Thread Grant Gainey
- Original Message - VirtualGuestsActionTest had some localized messages hardcoded in English, I removed them to actually look up their value from LocalizationService. See attached patch. commit ff4f40accefe349c122301b9b44572cfa479bff2 Thanks for your contribution! G

Re: [Spacewalk-devel] [PATCH] SystemEntitlementsSetupActionTest: do not assume Org has virtualization entitlement

2013-09-13 Thread Grant Gainey
- Original Message - SystemEntitlementsSetupActionTest was failing in our environment, as the tested Org missed a virtualization entitlement. The proposed attached patch fixes the problem. commit c9b4477aadb9eff33befc91d079e47b1a8bbefa2 Thanks for your contribution! G