Re: [Spacewalk-devel] [PATCH] Date/Time picker

2014-02-10 Thread Silvio Moioli
On 02/06/2014 11:12 AM, Duncan Mac-Vicar P. wrote: See attached patches. [...] On a slightly unrelated note, I have just noticed the current date picker allows incorrect dates to be picked, such as February 31. In the SSM errata scheduling page, among other things, such values cause a NPE.

Re: [Spacewalk-devel] UI: Errata pages ASAP removal missing patches

2014-02-10 Thread Matej Kollar
Pushed to master as 1ae33e052ef7b449ed34b8bea9411bc45631c0e6. Two little things were fixed in following two commits: * 31d358af3f9707771107ed6887989d30e50f Consistent closing of void tags (as you said that you completely rewritten the page so I thought it would be nice co have

Re: [Spacewalk-devel] UI: Errata pages ASAP removal missing patches

2014-02-10 Thread Bo Maryniuk
On Mon, Feb 10, 2014 at 07:49:48AM -0500, Matej Kollar wrote: Nevertheless I have a note for mentioned #0009: If you really insist on reformatting .jsp-s, please * do it in separate step to make review simpler, * do not introduce trailing white-spaces, * make consistent use of space